{"thread":{"id":"33261","subject":"Git.pm with recent File::Temp fail","startedAt":"2013-03-22T19:57:58Z","lastAt":"2013-04-29T08:32:17Z","messageCount":9,"participants":["H.Merijn Brand","Jeff King","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"211978","messageId":"20130322205758.09ca9107@pc09.procura.nl","threadId":"33261","inReplyTo":null,"subject":"Git.pm with recent File::Temp fail","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2013-03-22T19:57:58Z","receivedAt":"2013-03-22T19:57:58Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"git-1.8.2, perl-5.16.3, File::Temp-0.23\n\nWithout patch:\n\n$ git svn fetch\n'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.\n\nAfter patch:\n\n$ git svn fetch\n M t/06virtual.t\nr15506 = 6c65be7ff36ffc6fd9b960a4b470ca297103004e (refs/remotes/git-svn)\n⋮\n\npatch attached\n\n-- \nH.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/\nusing perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n\n\n>From e78bf3e99deb26050f8515076db63075f6d0d171 Mon Sep 17 00:00:00 2001\nFrom: \"H.Merijn Brand - Tux\" \nDate: Fri, 22 Mar 2013 20:56:53 +0100\nSubject: [PATCH] Syntax error in Git.pm for File::Temp-0.23\nMIME-Version: 1.0\nContent-Type: multipart/mixed; boundary=\"------------1.8.2\"\n\nThis is a multi-part message in MIME format.\n--------------1.8.2\nContent-Type: text/plain; charset=UTF-8; format=fixed\nContent-Transfer-Encoding: 8bit\n\n\nTesting with perl-5.16.3 and most recent File::Temp-0.23 revealed:\n\n$ git svn fetch\n'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.\n---\n perl/Git.pm | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\n--------------1.8.2\nContent-Type: text/x-patch; name=\"0001-Syntax-error-in-Git.pm-for-File-Temp-0.23.patch\"\nContent-Transfer-Encoding: 8bit\nContent-Disposition: attachment; filename=\"0001-Syntax-error-in-Git.pm-for-File-Temp-0.23.patch\"\n\ndiff --git a/perl/Git.pm b/perl/Git.pm\nindex 96cac39..cf4f54a 100644\n--- a/perl/Git.pm\n+++ b/perl/Git.pm\n@@ -1265,7 +1265,7 @@ sub _temp_cache {\n \t\t\t$tmpdir = $self->repo_path();\n \t\t}\n \n-\t\t($$temp_fd, $fname) = File::Temp->tempfile(\n+\t\t($$temp_fd, $fname) = File::Temp::tempfile(\n \t\t\t'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,\n \t\t\t) or throw Error::Simple(\"couldn't open new temp file\");\n \n\n--------------1.8.2--\n\n\n"},{"id":"213495","messageId":"20130408084310.2963648c@pc09.procura.nl","threadId":"33261","inReplyTo":"CAP30j14=_U8iEZAodnfACnBHgF0+j0_OK7n7PvsUnwSDj_Y40A@mail.gmail.com","subject":"Re: Git.pm with recent File::Temp fail","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2013-04-08T06:43:10Z","receivedAt":"2013-04-08T06:43:10Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Sat, 23 Mar 2013 16:32:47 +0000, Ben Walton \nwrote:\n\n> Hello,\n\nStill failing in 1.8.2.1\n\n> On Fri, Mar 22, 2013 at 7:57 PM, H.Merijn Brand wrote:\n> > git-1.8.2, perl-5.16.3, File::Temp-0.23\n> >\n> > Without patch:\n> >\n> > $ git svn fetch\n> > 'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.\n> >\n> > After patch:\n> >\n> > $ git svn fetch\n> > M t/06virtual.t\n> > r15506 = 6c65be7ff36ffc6fd9b960a4b470ca297103004e (refs/remotes/git-svn)\n> > ⋮\n> >\n> > patch attached\n> \n> This list prefers patches to be inline so that they can easily be\n> commented on, etc. I took a quick look at your patch and while it\n> looks fine to me, fwiw.\n> \n> You may want to resubmit using git send-email though so that others\n> will look at it and possibly apply it.\n\n-- \nH.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/\nusing perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"215790","messageId":"20130428110933.436786bd@pc09.procura.nl","threadId":"33261","inReplyTo":"CAP30j14=_U8iEZAodnfACnBHgF0+j0_OK7n7PvsUnwSDj_Y40A@mail.gmail.com","subject":"Re: Git.pm with recent File::Temp fail","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2013-04-28T09:09:33Z","receivedAt":"2013-04-28T09:09:33Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Sat, 23 Mar 2013 16:32:47 +0000, Ben Walton \nwrote:\n\n> Hello,\n\nStill failing in 1.8.2.2\n\nShort fix:\n--8<---\ndiff --git a/perl/Git.pm b/perl/Git.pm\nindex dc48159..7a252ef 100644\n--- a/perl/Git.pm\n+++ b/perl/Git.pm\n@@ -1265,7 +1265,7 @@ sub _temp_cache {\n $tmpdir = $self->repo_path();\n }\n\n- ($$temp_fd, $fname) = File::Temp->tempfile(\n+ ($$temp_fd, $fname) = File::Temp::tempfile(\n 'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,\n ) or throw Error::Simple(\"couldn't open new temp file\");\n\n-->8---\n\nLong fix inlined\n\n> On Fri, Mar 22, 2013 at 7:57 PM, H.Merijn Brand wrote:\n> > git-1.8.2, perl-5.16.3, File::Temp-0.23\n> >\n> > Without patch:\n> >\n> > $ git svn fetch\n> > 'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.\n> >\n> > After patch:\n> >\n> > $ git svn fetch\n> > M t/06virtual.t\n> > r15506 = 6c65be7ff36ffc6fd9b960a4b470ca297103004e (refs/remotes/git-svn)\n> > ⋮\n> >\n> > patch attached\n> \n> This list prefers patches to be inline so that they can easily be\n> commented on, etc. I took a quick look at your patch and while it\n> looks fine to me, fwiw.\n> \n> You may want to resubmit using git send-email though so that others\n> will look at it and possibly apply it.\n\nFrom b3be713101469f8bea14b854eb7840132ffdca8a Mon Sep 17 00:00:00 2001\nFrom: \"H.Merijn Brand - Tux\" \nDate: Sun, 28 Apr 2013 11:03:15 +0200\nSubject: [PATCH] Git.pm with recent File::Temp fail\nMIME-Version: 1.0\nContent-Type: multipart/mixed; boundary=\"------------1.8.2.1\"\n\nThis is a multi-part message in MIME format.\n--------------1.8.2.1\nContent-Type: text/plain; charset=UTF-8; format=fixed\nContent-Transfer-Encoding: 8bit\n\n\ngit-1.8.2{,.1,.2}, perl-5.16.3, File::Temp-0.23\n\nWithout patch:\n\n$ git svn fetch\n'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.\n\nAfter patch:\n\n$ git svn fetch\n M t/06virtual.t\nr15506 = 6c65be7ff36ffc6fd9b960a4b470ca297103004e (refs/remotes/git-svn)\n---\n perl/Git.pm | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\n--------------1.8.2.1\nContent-Type: text/x-patch; name=\"0001-Git.pm-with-recent-File-Temp-fail.patch\"\nContent-Transfer-Encoding: 8bit\nContent-Disposition: attachment; filename=\"0001-Git.pm-with-recent-File-Temp-fail.patch\"\n\ndiff --git a/perl/Git.pm b/perl/Git.pm\nindex dc48159..7a252ef 100644\n--- a/perl/Git.pm\n+++ b/perl/Git.pm\n@@ -1265,7 +1265,7 @@ sub _temp_cache {\n $tmpdir = $self->repo_path();\n }\n\n- ($$temp_fd, $fname) = File::Temp->tempfile(\n+ ($$temp_fd, $fname) = File::Temp::tempfile(\n 'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,\n ) or throw Error::Simple(\"couldn't open new temp file\");\n\n\n--------------1.8.2.1--\n\n\n-- \nH.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/\nusing perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"215815","messageId":"20130429021651.GA2751@sigill.intra.peff.net","threadId":"33261","inReplyTo":"20130428110933.436786bd@pc09.procura.nl","subject":"Re: Git.pm with recent File::Temp fail","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-04-29T02:16:51Z","receivedAt":"2013-04-29T02:16:51Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Apr 28, 2013 at 11:09:33AM +0200, H.Merijn Brand wrote:\n\n> Still failing in 1.8.2.2\n> \n> Short fix:\n> --8<---\n> diff --git a/perl/Git.pm b/perl/Git.pm\n> index dc48159..7a252ef 100644\n> --- a/perl/Git.pm\n> +++ b/perl/Git.pm\n> @@ -1265,7 +1265,7 @@ sub _temp_cache {\n> $tmpdir = $self->repo_path();\n> }\n> \n> - ($$temp_fd, $fname) = File::Temp->tempfile(\n> + ($$temp_fd, $fname) = File::Temp::tempfile(\n> 'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,\n> ) or throw Error::Simple(\"couldn't open new temp file\");\n\nI think this fix is the right thing. Your patch probably didn't get\napplied because it did not follow the guidelines in SubmittingPatches.\nPlease make sure the subject-line of your email says \"[PATCH]\".\n\nI.e., this part:\n\n> From b3be713101469f8bea14b854eb7840132ffdca8a Mon Sep 17 00:00:00 2001\n> From: \"H.Merijn Brand - Tux\" \n> Date: Sun, 28 Apr 2013 11:03:15 +0200\n> Subject: [PATCH] Git.pm with recent File::Temp fail\n\nShould be your actual email header, not just in the body of the message.\n\n> git-1.8.2{,.1,.2}, perl-5.16.3, File::Temp-0.23\n> \n> Without patch:\n> \n> $ git svn fetch\n> 'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.\n> \n> After patch:\n> \n> $ git svn fetch\n> M t/06virtual.t\n> r15506 = 6c65be7ff36ffc6fd9b960a4b470ca297103004e (refs/remotes/git-svn)\n\nI think the relevant thing is that File::Temp 0.23 started complaining\nabout this. From their Changes file:\n\n 2013-03-14 Tim Jenness \n\n ---- Release V0.23 CPAN ----\n\n [...]\n * Temp.pm: Calling tempfile or tempdir as a class method now\n produce a more useful fatal error message\n\nSo I think the right commit message is something like:\n\n We call File::Temp's \"tempfile\" function as a class method, but it was\n never designed to be called this way. Older versions seemed to\n tolerate it, but as of File::Temp 0.23, it blows up like this:\n\n $ git svn fetch\n 'tempfile' can't be called as a method at .../Git.pm line 1117.\n\n Fix it by calling it as a regular function, just inside the File::Temp\n namespace.\n\n-Peff\n"},{"id":"215819","messageId":"7vr4hung17.fsf@alter.siamese.dyndns.org","threadId":"33261","inReplyTo":"20130429021651.GA2751@sigill.intra.peff.net","subject":"Re: Git.pm with recent File::Temp fail","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-29T03:59:16Z","receivedAt":"2013-04-29T03:59:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Sun, Apr 28, 2013 at 11:09:33AM +0200, H.Merijn Brand wrote:\n>\n>> Still failing in 1.8.2.2\n>> \n>> Short fix:\n>> --8<---\n>> diff --git a/perl/Git.pm b/perl/Git.pm\n>> index dc48159..7a252ef 100644\n>> --- a/perl/Git.pm\n>> +++ b/perl/Git.pm\n>> @@ -1265,7 +1265,7 @@ sub _temp_cache {\n>> $tmpdir = $self->repo_path();\n>> }\n>> \n>> - ($$temp_fd, $fname) = File::Temp->tempfile(\n>> + ($$temp_fd, $fname) = File::Temp::tempfile(\n>> 'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,\n>> ) or throw Error::Simple(\"couldn't open new temp file\");\n>\n> I think this fix is the right thing. Your patch probably didn't get\n> applied because it did not follow the guidelines in SubmittingPatches.\n\nIt was more like \"It managed to miss people's attention because the\nsubject didn't say [PATCH]\", but yes you are right that the change\nthe patch text itself shows looks reasonable and that I cannot apply\na patch that is not signed off (and worse yet in multipart/mixed).\n\n> ...\n> So I think the right commit message is something like:\n>\n> We call File::Temp's \"tempfile\" function as a class method, but it was\n> never designed to be called this way. Older versions seemed to\n> tolerate it, but as of File::Temp 0.23, it blows up like this:\n>\n> $ git svn fetch\n> 'tempfile' can't be called as a method at .../Git.pm line 1117.\n>\n> Fix it by calling it as a regular function, just inside the File::Temp\n> namespace.\n>\n> -Peff\n\nThanks.\n"},{"id":"215831","messageId":"20130429074620.17fbf129@pc09.procura.nl","threadId":"33261","inReplyTo":"7vr4hung17.fsf@alter.siamese.dyndns.org","subject":"Re: Git.pm with recent File::Temp fail","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2013-04-29T05:46:20Z","receivedAt":"2013-04-29T05:46:20Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Sun, 28 Apr 2013 20:59:16 -0700, Junio C Hamano \nwrote:\n\n> Jeff King writes:\n> \n> > On Sun, Apr 28, 2013 at 11:09:33AM +0200, H.Merijn Brand wrote:\n> >\n> >> Still failing in 1.8.2.2\n> >> \n> >> Short fix:\n> >> --8<---\n> >> diff --git a/perl/Git.pm b/perl/Git.pm\n> >> index dc48159..7a252ef 100644\n> >> --- a/perl/Git.pm\n> >> +++ b/perl/Git.pm\n> >> @@ -1265,7 +1265,7 @@ sub _temp_cache {\n> >> $tmpdir = $self->repo_path();\n> >> }\n> >> \n> >> - ($$temp_fd, $fname) = File::Temp->tempfile(\n> >> + ($$temp_fd, $fname) = File::Temp::tempfile(\n> >> 'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,\n> >> ) or throw Error::Simple(\"couldn't open new temp file\");\n> >\n> > I think this fix is the right thing. Your patch probably didn't get\n> > applied because it did not follow the guidelines in SubmittingPatches.\n> \n> It was more like \"It managed to miss people's attention because the\n> subject didn't say [PATCH]\", but yes you are right that the change\n> the patch text itself shows looks reasonable and that I cannot apply\n> a patch that is not signed off (and worse yet in multipart/mixed).\n\nMy first attempt (when git-1.8.2 was released) had the patch attached\nand the reply was\n\nOn Sat, 23 Mar 2013 16:32:47 +0000, Ben Walton \nwrote:\n\n> This list prefers patches to be inline so that they can easily be\n> commented on, etc. I took a quick look at your patch and while it\n> looks fine to me, fwiw.\n> \n> You may want to resubmit using git send-email though so that others\n> will look at it and possibly apply it.\n\nSo I retried inlining. No mention about *how* to inline or that the\nsubject should have the word \"PATCH\".\n\nI don't need any credits. I just want git to work from scratch :)\n\n> > ...\n> > So I think the right commit message is something like:\n> >\n> > We call File::Temp's \"tempfile\" function as a class method, but it was\n> > never designed to be called this way. Older versions seemed to\n> > tolerate it, but as of File::Temp 0.23, it blows up like this:\n> >\n> > $ git svn fetch\n> > 'tempfile' can't be called as a method at .../Git.pm line 1117.\n> >\n> > Fix it by calling it as a regular function, just inside the File::Temp\n> > namespace.\n\nSounds about right.\n\n> > -Peff\n> \n> Thanks.\n\n-- \nH.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/\nusing perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"215832","messageId":"7vy5c1narj.fsf@alter.siamese.dyndns.org","threadId":"33261","inReplyTo":"20130429074620.17fbf129@pc09.procura.nl","subject":"Re: Git.pm with recent File::Temp fail","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-29T05:53:04Z","receivedAt":"2013-04-29T05:53:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"H.Merijn Brand\" writes:\n\n> I don't need any credits. I just want git to work from scratch :)\n\nThe sign-off procedure is not about giving credits to you. It is to\nprotect us from others (e.g. your employer) by having a record that\nyou claimed that you had the authority to give us the change.\n\nFor a single-liner change like this, this often does not matter in\npractice, but we try to be consistent as it makes everybody's life\nsimpler to have a single procedure for all the patches.\n\nThanks\n\n>\n>> > ...\n>> > So I think the right commit message is something like:\n>> >\n>> > We call File::Temp's \"tempfile\" function as a class method, but it was\n>> > never designed to be called this way. Older versions seemed to\n>> > tolerate it, but as of File::Temp 0.23, it blows up like this:\n>> >\n>> > $ git svn fetch\n>> > 'tempfile' can't be called as a method at .../Git.pm line 1117.\n>> >\n>> > Fix it by calling it as a regular function, just inside the File::Temp\n>> > namespace.\n>\n> Sounds about right.\n>\n>> > -Peff\n>> \n>> Thanks.\n"},{"id":"215836","messageId":"7vd2tdn41h.fsf@alter.siamese.dyndns.org","threadId":"33261","inReplyTo":"7vy5c1narj.fsf@alter.siamese.dyndns.org","subject":"Re: Git.pm with recent File::Temp fail","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-29T08:18:18Z","receivedAt":"2013-04-29T08:18:18Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here is what I'll queue.\n\nThanks for the help, all of you.\n\n-- >8 --\nFrom: H. Merijn Brand \nSubject: Git.pm: call tempfile from File::Temp as a regular function\n\nWe call File::Temp's \"tempfile\" function as a class method, but it was\nnever designed to be called this way. Older versions seemed to\ntolerate it, but as of File::Temp 0.23, it blows up like this:\n\n $ git svn fetch\n 'tempfile' can't be called as a method at .../Git.pm line 1117.\n\nFix it by calling it as a regular function, just inside the File::Temp\nnamespace.\n\nSigned-off-by: H. Merijn Brand \nHelped-by: Jeff King \n---\n perl/Git.pm | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/perl/Git.pm b/perl/Git.pm\nindex 497f420..76383b9 100644\n--- a/perl/Git.pm\n+++ b/perl/Git.pm\n@@ -1039,7 +1039,7 @@ sub _temp_cache {\n \t\t\t$tmpdir = $self->repo_path();\n \t\t}\n \n-\t\t($$temp_fd, $fname) = File::Temp->tempfile(\n+\t\t($$temp_fd, $fname) = File::Temp::tempfile(\n \t\t\t'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,\n \t\t\t) or throw Error::Simple(\"couldn't open new temp file\");\n \n"},{"id":"215837","messageId":"20130429103217.5f50525b@pc09.procura.nl","threadId":"33261","inReplyTo":"7vd2tdn41h.fsf@alter.siamese.dyndns.org","subject":"Re: Git.pm with recent File::Temp fail","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2013-04-29T08:32:17Z","receivedAt":"2013-04-29T08:32:17Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Mon, 29 Apr 2013 01:18:18 -0700, Junio C Hamano \nwrote:\n\n> Here is what I'll queue.\n> \n> Thanks for the help, all of you.\n\nThank you. I will keep this conversation as a guide for possible next\npatches\n\n> -- >8 --\n> From: H. Merijn Brand \n> Subject: Git.pm: call tempfile from File::Temp as a regular function\n> \n> We call File::Temp's \"tempfile\" function as a class method, but it was\n> never designed to be called this way. Older versions seemed to\n> tolerate it, but as of File::Temp 0.23, it blows up like this:\n> \n> $ git svn fetch\n> 'tempfile' can't be called as a method at .../Git.pm line 1117.\n> \n> Fix it by calling it as a regular function, just inside the File::Temp\n> namespace.\n> \n> Signed-off-by: H. Merijn Brand \n> Helped-by: Jeff King \n> ---\n> perl/Git.pm | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/perl/Git.pm b/perl/Git.pm\n> index 497f420..76383b9 100644\n> --- a/perl/Git.pm\n> +++ b/perl/Git.pm\n> @@ -1039,7 +1039,7 @@ sub _temp_cache {\n> \t\t\t$tmpdir = $self->repo_path();\n> \t\t}\n> \n> -\t\t($$temp_fd, $fname) = File::Temp->tempfile(\n> +\t\t($$temp_fd, $fname) = File::Temp::tempfile(\n> \t\t\t'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,\n> \t\t\t) or throw Error::Simple(\"couldn't open new temp file\");\n> \n\n\n-- \nH.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/\nusing perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"}]}