{"thread":{"id":"33250","subject":"[PATCH] diff.c: diff.renamelimit => diff.renameLimit in message","startedAt":"2013-03-21T19:53:38Z","lastAt":"2013-03-21T22:14:38Z","messageCount":3,"participants":["Max Nanasy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"211889","messageId":"CAM998vHDay2o55Q3v4tfh=tvcmpOHHCPX-Ya5KxVxsn3=jzs3A@mail.gmail.com","threadId":"33250","inReplyTo":null,"subject":"[PATCH] diff.c: diff.renamelimit => diff.renameLimit in message","fromName":"Max Nanasy","fromEmail":"max.nanasy@gmail.com","sentAt":"2013-03-21T19:53:38Z","receivedAt":"2013-03-21T19:53:38Z","isPatch":true,"sender":{"key":"max.nanasy@gmail.com","avatar":"https://avatars.githubusercontent.com/u/628032?v=4"},"body":"In the warning message printed when rename or unmodified copy\ndetection was skipped due to too many files, change \"diff.renamelimit\"\nto \"diff.renameLimit\", in order to make it consistent with git\ndocumentation, which consistently uses \"diff.renameLimit\".\n\nSigned-off-by: Max Nanasy <max.nanasy@gmail.com>\n---\n diff.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/diff.c b/diff.c\nindex 156fec4..052974e 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status)\n {\n  int result = 0;\n\n- diff_warn_rename_limit(\"diff.renamelimit\",\n+ diff_warn_rename_limit(\"diff.renameLimit\",\n        opt->needed_rename_limit,\n        opt->degraded_cc_to_c);\n  if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) &&\n--\n1.8.1.3\n"},{"id":"211896","messageId":"7va9pwa3h9.fsf@alter.siamese.dyndns.org","threadId":"33250","inReplyTo":"CAM998vHDay2o55Q3v4tfh=tvcmpOHHCPX-Ya5KxVxsn3=jzs3A@mail.gmail.com","subject":"Re: [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-21T20:43:14Z","receivedAt":"2013-03-21T20:43:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Max Nanasy <max.nanasy@gmail.com> writes:\n\n> In the warning message printed when rename or unmodified copy\n> detection was skipped due to too many files, change \"diff.renamelimit\"\n> to \"diff.renameLimit\", in order to make it consistent with git\n> documentation, which consistently uses \"diff.renameLimit\".\n>\n> Signed-off-by: Max Nanasy <max.nanasy@gmail.com>\n> ---\n\nI \"git grep\"ed around and it tells me that this is the only such\nplace.  Thanks.\n\nThe patch is severely whitespace damaged.  If you plan to keep\ncontributing to Git, I'd like to make sure that your mail toolchain\nis sane, so that we do not have to keep hand-adjusting patches\nsubmitted by you before applying.\n\n>  diff.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/diff.c b/diff.c\n> index 156fec4..052974e 100644\n> --- a/diff.c\n> +++ b/diff.c\n> @@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status)\n>  {\n>   int result = 0;\n>\n> - diff_warn_rename_limit(\"diff.renamelimit\",\n> + diff_warn_rename_limit(\"diff.renameLimit\",\n>         opt->needed_rename_limit,\n>         opt->degraded_cc_to_c);\n>   if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) &&\n> --\n> 1.8.1.3\n"},{"id":"211908","messageId":"1363904078-98433-1-git-send-email-max.nanasy@gmail.com","threadId":"33250","inReplyTo":"7va9pwa3h9.fsf@alter.siamese.dyndns.org","subject":"[PATCH v2] diff.c: diff.renamelimit => diff.renameLimit in message","fromName":"Max Nanasy","fromEmail":"max.nanasy@gmail.com","sentAt":"2013-03-21T22:14:38Z","receivedAt":"2013-03-21T22:14:38Z","isPatch":true,"sender":{"key":"max.nanasy@gmail.com","avatar":"https://avatars.githubusercontent.com/u/628032?v=4"},"body":"In the warning message printed when rename or unmodified copy\ndetection was skipped due to too many files, change \"diff.renamelimit\"\nto \"diff.renameLimit\", in order to make it consistent with git\ndocumentation, which consistently uses \"diff.renameLimit\".\n\nSigned-off-by: Max Nanasy <max.nanasy@gmail.com>\n---\n\nJunio C Hamano <gitster <at> pobox.com> writes:\n\n> \n> The patch is severely whitespace damaged.  If you plan to keep\n> contributing to Git, I'd like to make sure that your mail toolchain\n> is sane, so that we do not have to keep hand-adjusting patches\n> submitted by you before applying.\n> \n\nI composed the first patch through the GMail web interface, which converted\ntabs to spaces.  I'm retrying this one through git send-email.\n\n diff.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/diff.c b/diff.c\nindex 156fec4..052974e 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status)\n {\n \tint result = 0;\n \n-\tdiff_warn_rename_limit(\"diff.renamelimit\",\n+\tdiff_warn_rename_limit(\"diff.renameLimit\",\n \t\t\t       opt->needed_rename_limit,\n \t\t\t       opt->degraded_cc_to_c);\n \tif (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) &&\n-- \n1.8.1.3\n"}]}