{"thread":{"id":"33141","subject":"[PATCH v2] git.c: Remove unnecessary new line","startedAt":"2013-03-09T22:16:02Z","lastAt":"2013-03-10T00:10:45Z","messageCount":3,"participants":["Michael Fallows","Jonathan Nieder"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"210940","messageId":"513BB4A2.8000407@fallo.ws","threadId":"33141","inReplyTo":null,"subject":"[PATCH v2] git.c: Remove unnecessary new line","fromName":"Michael Fallows","fromEmail":"michael@fallo.ws","sentAt":"2013-03-09T22:16:02Z","receivedAt":"2013-03-09T22:16:02Z","isPatch":true,"sender":{"key":"michael@fallo.ws","avatar":"https://gravatar.com/avatar/c32d72c02a93ffb91e5714193239d3438f9d8ad8b4f9e0756173f569f5025550?d=mp&s=160"},"body":"New line on checkout-index is inconsistent with the rest of the commands\n\nSigned-off-by: Michael Fallows <michael@fallo.ws>\n---\n git.c |    3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/git.c b/git.c\nindex b10c18b..b4d7bbb 100644\n--- a/git.c\n+++ b/git.c\n@@ -316,8 +316,7 @@ static void handle_internal_command(int argc, const char **argv)\n \t\t{ \"check-ignore\", cmd_check_ignore, RUN_SETUP | NEED_WORK_TREE },\n \t\t{ \"check-ref-format\", cmd_check_ref_format },\n \t\t{ \"checkout\", cmd_checkout, RUN_SETUP | NEED_WORK_TREE },\n-\t\t{ \"checkout-index\", cmd_checkout_index,\n-\t\t\tRUN_SETUP | NEED_WORK_TREE},\n+\t\t{ \"checkout-index\", cmd_checkout_index, RUN_SETUP | NEED_WORK_TREE },\n \t\t{ \"cherry\", cmd_cherry, RUN_SETUP },\n \t\t{ \"cherry-pick\", cmd_cherry_pick, RUN_SETUP | NEED_WORK_TREE },\n \t\t{ \"clean\", cmd_clean, RUN_SETUP | NEED_WORK_TREE },\n-- \n1.7.9.5\n"},{"id":"210944","messageId":"20130310000023.GI3908@elie.Belkin","threadId":"33141","inReplyTo":"513BB4A2.8000407@fallo.ws","subject":"Re: [PATCH v2] git.c: Remove unnecessary new line","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-03-10T00:00:23Z","receivedAt":"2013-03-10T00:00:23Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nMichael Fallows wrote:\n\n> --- a/git.c\n> +++ b/git.c\n> @@ -316,8 +316,7 @@ static void handle_internal_command(int argc, const char **argv)\n>  \t\t{ \"check-ignore\", cmd_check_ignore, RUN_SETUP | NEED_WORK_TREE },\n>  \t\t{ \"check-ref-format\", cmd_check_ref_format },\n>  \t\t{ \"checkout\", cmd_checkout, RUN_SETUP | NEED_WORK_TREE },\n> -\t\t{ \"checkout-index\", cmd_checkout_index,\n> -\t\t\tRUN_SETUP | NEED_WORK_TREE},\n> +\t\t{ \"checkout-index\", cmd_checkout_index, RUN_SETUP | NEED_WORK_TREE },\n\nThis wrapped line was introduced a while ago (4465f410, checkout-index\nneeds a working tree, 2007-08-04).  It was the first line to wrap, but\nit was also the longest line at the time.\n\nNow the longest line is\n\n\t\t{ \"merge-recursive-theirs\", cmd_merge_recursive, RUN_SETUP | NEED_WORK_TREE },\n\n(94 columns), so you are right that consistency would suggest dropping\nthe line wrapping for checkout-index.\n\nBut I find it hard to convince myself that alone is worth the churn.\nIn what context did you notice this?  Is the intent to help scripts to\nparse the commands[] list, or to manipulate it while preserving\nformatting to avoid distractions?  Did you notice the broken line\nwhile reading through and get distracted, or did some syntax\nhighlighting tool notice the oddity, or something else?\n\nHope that helps,\nJonathan\n"},{"id":"210946","messageId":"513BCF85.7050605@fallo.ws","threadId":"33141","inReplyTo":"20130310000023.GI3908@elie.Belkin","subject":"Re: [PATCH v2] git.c: Remove unnecessary new line","fromName":"Michael Fallows","fromEmail":"michael@fallo.ws","sentAt":"2013-03-10T00:10:45Z","receivedAt":"2013-03-10T00:10:45Z","isPatch":true,"sender":{"key":"michael@fallo.ws","avatar":"https://gravatar.com/avatar/c32d72c02a93ffb91e5714193239d3438f9d8ad8b4f9e0756173f569f5025550?d=mp&s=160"},"body":"On 10/03/13 00:00, Jonathan Nieder wrote:\n> Hi,\n>\n> Michael Fallows wrote:\n>\n>> --- a/git.c\n>> +++ b/git.c\n>> @@ -316,8 +316,7 @@ static void handle_internal_command(int argc, const char **argv)\n>>   \t\t{ \"check-ignore\", cmd_check_ignore, RUN_SETUP | NEED_WORK_TREE },\n>>   \t\t{ \"check-ref-format\", cmd_check_ref_format },\n>>   \t\t{ \"checkout\", cmd_checkout, RUN_SETUP | NEED_WORK_TREE },\n>> -\t\t{ \"checkout-index\", cmd_checkout_index,\n>> -\t\t\tRUN_SETUP | NEED_WORK_TREE},\n>> +\t\t{ \"checkout-index\", cmd_checkout_index, RUN_SETUP | NEED_WORK_TREE },\n>\n> This wrapped line was introduced a while ago (4465f410, checkout-index\n> needs a working tree, 2007-08-04).  It was the first line to wrap, but\n> it was also the longest line at the time.\n>\n> Now the longest line is\n>\n> \t\t{ \"merge-recursive-theirs\", cmd_merge_recursive, RUN_SETUP | NEED_WORK_TREE },\n>\n> (94 columns), so you are right that consistency would suggest dropping\n> the line wrapping for checkout-index.\n>\n> But I find it hard to convince myself that alone is worth the churn.\n> In what context did you notice this?  Is the intent to help scripts to\n> parse the commands[] list, or to manipulate it while preserving\n> formatting to avoid distractions?  Did you notice the broken line\n> while reading through and get distracted, or did some syntax\n> highlighting tool notice the oddity, or something else?\n>\n> Hope that helps,\n> Jonathan\n>\n\nI do agree with you it does seem like a silly small change in the \ncontext of the project! I noticed it when reading through the source \ncode (I felt working with git is nice but why not see what makes it \ntick). I will admit also, have never contributed to git and my C is \nnowhere near the standard worthy of any real contribution so this was \nalso a step for me to see exactly how the world of patch contribution \nworks too :D.\n\nThanks,\nMichael\n"}]}