{"thread":{"id":"33120","subject":"[PATCH 01/19] spell checking","startedAt":"2013-03-09T19:19:44Z","lastAt":"2013-03-09T20:25:19Z","messageCount":4,"participants":["Paul Campbell","Junio C Hamano","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":19},"messages":[{"id":"210907","messageId":"CALeLG_=R4o1y-kA+n883nnAu+jrjgaA2ys2d+Vo9KasmVKeduQ@mail.gmail.com","threadId":"33120","inReplyTo":null,"subject":"[PATCH 01/19] spell checking","fromName":"Paul Campbell","fromEmail":"pcampbell@kemitix.net","sentAt":"2013-03-09T19:19:44Z","receivedAt":"2013-03-09T19:19:44Z","isPatch":true,"sender":{"key":"pcampbell@kemitix.net","avatar":"https://gravatar.com/avatar/57584e05501b694929004e43fcd7308f4ad64df2eb0474cd8c7e5f93662bb0f1?d=mp&s=160"},"body":">From 72fc84b6e5085b328cc90e664c9f85a1f5cde36c Mon Sep 17 00:00:00 2001\nFrom: Paul Cartwright \nDate: Thu, 27 Jan 2011 22:33:06 +0800\nSubject: [PATCH 01/19] spell checking\n\n---\n contrib/subtree/git-subtree.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\nindex 7ba853e..e0957ee 100644\n--- a/contrib/subtree/git-subtree.txt\n+++ b/contrib/subtree/git-subtree.txt\n@@ -270,7 +270,7 @@ git-extensions repository in ~/git-extensions/:\n name\n\n You can omit the --squash flag, but doing so will increase the number\n-of commits that are incldued in your local repository.\n+of commits that are included in your local repository.\n\n We now have a ~/git-extensions/git-subtree directory containing code\n from the master branch of git://github.com/apenwarr/git-subtree.git\n-- \n1.8.2.rc1\n\n\n-- \nPaul [W] Campbell\n"},{"id":"210928","messageId":"7vobese4rp.fsf@alter.siamese.dyndns.org","threadId":"33120","inReplyTo":"CALeLG_=R4o1y-kA+n883nnAu+jrjgaA2ys2d+Vo9KasmVKeduQ@mail.gmail.com","subject":"Re: [PATCH 01/19] spell checking","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-09T19:45:30Z","receivedAt":"2013-03-09T19:45:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Paul Campbell writes:\n\n> From 72fc84b6e5085b328cc90e664c9f85a1f5cde36c Mon Sep 17 00:00:00 2001\n> From: Paul Cartwright \n> Date: Thu, 27 Jan 2011 22:33:06 +0800\n> Subject: [PATCH 01/19] spell checking\n>\n> ---\n> contrib/subtree/git-subtree.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nI won't repeat these for other 18 patches, but please:\n\n - drop the first \"From \" line which\n is not part of the patch (it is only meant to help people who\n maintain the \"file(1)\" and \"magic(5)\");\n\n - keep \"From: ...\" and \"Date: \" lines for other\n peoples' patches you are forwarding (they can be dropped for your\n own patches); and\n\n - drop \"Subject: \" as that is the same as the subject of the e-mail\n message.\n\n - fix the subject to make it clear that the change is for\n contrib/subtree.\n\n \"spell checking\" [*1*] in the output of \"git shortlog v1.8.1..\",\n together with other 600+ patches' titles, will not help the\n reader to see how much activity each area had and who worked in\n what area.\n\n - have the authors sign-off their patches, and then add yours as\n the person who is forwarding other peoples' patches (see\n Documentation/SubmittingPatches).\n\n - Cc the area maintainer (I thought it was David Greene?)\n\nif these patches are meant to become part of git.git eventually.\n\nThanks.\n\n\n[Footnote]\n\n*1* Besides, a patch can never be \"spell *checking*\". It would be\n \"typofix\" after the author did a 'spell checking' ;-)\n"},{"id":"210929","messageId":"CALeLG_kdYjFhZXWedTgr2zdzJfrGV6XmqT1qkMX9XpJgztnPcg@mail.gmail.com","threadId":"33120","inReplyTo":"7vobese4rp.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 01/19] spell checking","fromName":"Paul Campbell","fromEmail":"pcampbell@kemitix.net","sentAt":"2013-03-09T20:07:20Z","receivedAt":"2013-03-09T20:07:20Z","isPatch":true,"sender":{"key":"pcampbell@kemitix.net","avatar":"https://gravatar.com/avatar/57584e05501b694929004e43fcd7308f4ad64df2eb0474cd8c7e5f93662bb0f1?d=mp&s=160"},"body":"On Sat, Mar 9, 2013 at 7:45 PM, Junio C Hamano wrote:\n> Paul Campbell writes:\n>\n>> From 72fc84b6e5085b328cc90e664c9f85a1f5cde36c Mon Sep 17 00:00:00 2001\n>> From: Paul Cartwright \n>> Date: Thu, 27 Jan 2011 22:33:06 +0800\n>> Subject: [PATCH 01/19] spell checking\n>>\n>> ---\n>> contrib/subtree/git-subtree.txt | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> I won't repeat these for other 18 patches, but please:\n\nThanks and apologies. All noted, although I have a question below.\n\n> - drop the first \"From \" line which\n> is not part of the patch (it is only meant to help people who\n> maintain the \"file(1)\" and \"magic(5)\");\n>\n> - keep \"From: ...\" and \"Date: \" lines for other\n> peoples' patches you are forwarding (they can be dropped for your\n> own patches); and\n>\n> - drop \"Subject: \" as that is the same as the subject of the e-mail\n> message.\n>\n> - fix the subject to make it clear that the change is for\n> contrib/subtree.\n>\n> \"spell checking\" [*1*] in the output of \"git shortlog v1.8.1..\",\n> together with other 600+ patches' titles, will not help the\n> reader to see how much activity each area had and who worked in\n> what area.\n\nI'd wanted to avoid changing the original author's work as much as\npossible. Wrong choice on my part.\n\n> - have the authors sign-off their patches, and then add yours as\n> the person who is forwarding other peoples' patches (see\n> Documentation/SubmittingPatches).\n\nFour of the eight original authors now have dead email addresses. As I\nfound out when I started getting the mail bounces when I started\nsending these patches out. Would it be acceptable for those patches to\nleave the From line, add a Based-on-patch-by and then sign of myself?\nI've really only done enough on top of the cherry-picking to get round\nany conflicts.\n\n> - Cc the area maintainer (I thought it was David Greene?)\n>\n> if these patches are meant to become part of git.git eventually.\n\nI knew that and forgot. Can I blame this on my head-cold? No?\n\n> Thanks.\n>\n>\n> [Footnote]\n>\n> *1* Besides, a patch can never be \"spell *checking*\". It would be\n> \"typofix\" after the author did a 'spell checking' ;-)\n\n-- \nPaul [W] Campbell\n"},{"id":"210931","messageId":"20130309202518.GD3908@elie.Belkin","threadId":"33120","inReplyTo":"CALeLG_kdYjFhZXWedTgr2zdzJfrGV6XmqT1qkMX9XpJgztnPcg@mail.gmail.com","subject":"Re: [PATCH 01/19] spell checking","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-03-09T20:25:19Z","receivedAt":"2013-03-09T20:25:19Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Paul Campbell wrote:\n\n> Four of the eight original authors now have dead email addresses. As I\n> found out when I started getting the mail bounces when I started\n> sending these patches out. Would it be acceptable for those patches to\n> leave the From line, add a Based-on-patch-by and then sign of myself?\n\nIt's always nice to get the original author's sign-off, but if you can\ncertify what's stated in the DCO1.1 (from\nDocumentation/SubmittingPatches) then just adding your sign-off is\nfine. Please still keep the original authorship in that case, and no\nneed to add a Based-on-patch-by line.\n\nThanks,\nJonathan\n"}]}