{"thread":{"id":"33091","subject":"fetch --no-tags with and w/o --all","startedAt":"2013-03-06T21:33:02Z","lastAt":"2013-03-07T01:08:29Z","messageCount":5,"participants":["Cristian Tibirna","Junio C Hamano","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"210724","messageId":"1879950.i2j8pjGADy@gandalf","threadId":"33091","inReplyTo":null,"subject":"fetch --no-tags with and w/o --all","fromName":"Cristian Tibirna","fromEmail":"ctibirna@giref.ulaval.ca","sentAt":"2013-03-06T21:33:02Z","receivedAt":"2013-03-06T21:33:02Z","isPatch":false,"sender":{"key":"ctibirna@giref.ulaval.ca","avatar":null},"body":"Hello\n\n$ git --version\ngit version 1.7.10.4\n\n$ git fetch origin --no-tags\ndoes what it says\n\n$ git fetch --all --no-tags\nstill gets all the tags from the remote.\n\nIs this known?\n\nThanks.\n\n-- \nCristian Tibirna\t\t\t\t(1-418-) 656-2131 / 4340\n Laval University - Quebec, CAN ... http://www.giref.ulaval.ca/~ctibirna\n Research professional at GIREF ... ctibirna@giref.ulaval.ca\n"},{"id":"210726","messageId":"7vboawp4zy.fsf@alter.siamese.dyndns.org","threadId":"33091","inReplyTo":"1879950.i2j8pjGADy@gandalf","subject":"Re: fetch --no-tags with and w/o --all","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-06T21:56:01Z","receivedAt":"2013-03-06T21:56:01Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Cristian Tibirna writes:\n\n> Hello\n>\n> $ git --version\n> git version 1.7.10.4\n>\n> $ git fetch origin --no-tags\n> does what it says\n>\n> $ git fetch --all --no-tags\n> still gets all the tags from the remote.\n>\n> Is this known?\n\nBecause --all (or --multiple) to iterate through all remotes\ndoes not pass accept any command line refspecs, using these options\nwith --no-tags and/or --tags should be diagnosed as an error, but it\nappears that the error checking is not done.\n"},{"id":"210734","messageId":"20130307002038.GA31571@sigill.intra.peff.net","threadId":"33091","inReplyTo":"7vboawp4zy.fsf@alter.siamese.dyndns.org","subject":"Re: fetch --no-tags with and w/o --all","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-03-07T00:20:38Z","receivedAt":"2013-03-07T00:20:38Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Mar 06, 2013 at 01:56:01PM -0800, Junio C Hamano wrote:\n\n> Cristian Tibirna writes:\n> \n> > Hello\n> >\n> > $ git --version\n> > git version 1.7.10.4\n> >\n> > $ git fetch origin --no-tags\n> > does what it says\n> >\n> > $ git fetch --all --no-tags\n> > still gets all the tags from the remote.\n> >\n> > Is this known?\n> \n> Because --all (or --multiple) to iterate through all remotes\n> does not pass accept any command line refspecs, using these options\n> with --no-tags and/or --tags should be diagnosed as an error, but it\n> appears that the error checking is not done.\n\nOr we could just pass them through. Looks like this was already fixed by\n8556646 (fetch --all: pass --tags/--no-tags through to each remote,\n2012-09-05), which is in v1.7.12.2 and higher.\n\n-Peff\n"},{"id":"210736","messageId":"7vhakonirb.fsf@alter.siamese.dyndns.org","threadId":"33091","inReplyTo":"20130307002038.GA31571@sigill.intra.peff.net","subject":"Re: fetch --no-tags with and w/o --all","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-07T00:41:44Z","receivedAt":"2013-03-07T00:41:44Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Wed, Mar 06, 2013 at 01:56:01PM -0800, Junio C Hamano wrote:\n>\n>> Cristian Tibirna writes:\n>> \n>> > Hello\n>> >\n>> > $ git --version\n>> > git version 1.7.10.4\n>> >\n>> > $ git fetch origin --no-tags\n>> > does what it says\n>> >\n>> > $ git fetch --all --no-tags\n>> > still gets all the tags from the remote.\n>> >\n>> > Is this known?\n>> \n>> Because --all (or --multiple) to iterate through all remotes\n>> does not pass accept any command line refspecs, using these options\n>> with --no-tags and/or --tags should be diagnosed as an error, but it\n>> appears that the error checking is not done.\n>\n> Or we could just pass them through. Looks like this was already fixed by\n> 8556646 (fetch --all: pass --tags/--no-tags through to each remote,\n> 2012-09-05), which is in v1.7.12.2 and higher.\n\n;-) No wonder this looked somewhat familiar.\n"},{"id":"210739","messageId":"20130307010829.GB850@sigill.intra.peff.net","threadId":"33091","inReplyTo":"7vhakonirb.fsf@alter.siamese.dyndns.org","subject":"Re: fetch --no-tags with and w/o --all","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-03-07T01:08:29Z","receivedAt":"2013-03-07T01:08:29Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Mar 06, 2013 at 04:41:44PM -0800, Junio C Hamano wrote:\n\n> > Or we could just pass them through. Looks like this was already fixed by\n> > 8556646 (fetch --all: pass --tags/--no-tags through to each remote,\n> > 2012-09-05), which is in v1.7.12.2 and higher.\n> \n> ;-) No wonder this looked somewhat familiar.\n\nI still find it somewhat gross that we actually re-construct the\ncommand-line from the parsed flag variables. It seems like it would be\neasier to simply propagate the argv we got in the first place, and then\nwe would not have any chance of omitting a new option that is added\nlater.\n\nProbably not worth worrying about now, though, as the fix is long since\nshipped. The next person who is adding an option can look at doing that\nrefactoring. And it may be that there are some options we don't\npropagate intentionally (I didn't look closely).\n\n-Peff\n"}]}