{"thread":{"id":"33076","subject":"[PATCH] Fix `make install` when configured with autoconf","startedAt":"2013-03-05T12:43:25Z","lastAt":"2013-03-05T16:56:29Z","messageCount":2,"participants":["Kirill Smelkov","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"210625","messageId":"1362487405-32044-1-git-send-email-kirr@mns.spb.ru","threadId":"33076","inReplyTo":null,"subject":"[PATCH] Fix `make install` when configured with autoconf","fromName":"Kirill Smelkov","fromEmail":"kirr@mns.spb.ru","sentAt":"2013-03-05T12:43:25Z","receivedAt":"2013-03-05T12:43:25Z","isPatch":true,"sender":{"key":"kirr@navytux.spb.ru","avatar":"https://gravatar.com/avatar/cf3445fdad1849941e17ab25bf1ee7c5ea1be2deb444be25ff5f36b0e50a985f?d=mp&s=160"},"body":"Commit d8cf908c (config.mak.in: remove unused definitions) removed\n\n    exec_prefix = @exec_prefix@\n\nfrom config.mak.in, because nobody directly used ${exec_prefix}, but\noverlooked that other autoconf definitions could indirectly expand that\nvariable.\n\nFor example the following snippet from config.mak.in\n\n    prefix = @prefix@\n    bindir = @bindir@\n    gitexecdir = @libexecdir@/git-core\n    datarootdir = @datarootdir@\n    template_dir = @datadir@/git-core/templates\n    sysconfdir = @sysconfdir@\n\nis expanded to\n\n    prefix = /home/kirr/local/git\n    bindir = ${exec_prefix}/bin                             <-- HERE\n    gitexecdir = ${exec_prefix}/libexec/git-core            <--\n    datarootdir = ${prefix}/share\n    template_dir = ${datarootdir}/git-core/templates\n    sysconfdir = ${prefix}/etc\n\non my system, after `configure --prefix=$HOME/local/git`\n\nand withot exec_prefix being defined there I get an error on\ninstall:\n\n    install -d -m 755 '/bin'\n    install -d -m 755 '/libexec/git-core'\n    install: cannot create directory `/libexec': Permission denied\n    Makefile:2292: recipe for target `install' failed\n\nFix it.\n\nSigned-off-by: Kirill Smelkov <kirr@mns.spb.ru>\n---\n config.mak.in | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.in b/config.mak.in\nindex 7440687..e6a6d0f 100644\n--- a/config.mak.in\n+++ b/config.mak.in\n@@ -12,6 +12,7 @@ PACKAGE_TARNAME = @PACKAGE_TARNAME@\n #INSTALL = @INSTALL@\t\t# needs install-sh or install.sh in sources\n \n prefix = @prefix@\n+exec_prefix = @exec_prefix@\n bindir = @bindir@\n gitexecdir = @libexecdir@/git-core\n datarootdir = @datarootdir@\n-- \n1.8.2.rc2.353.gd2380b4\n"},{"id":"210643","messageId":"7vvc95u6o2.fsf@alter.siamese.dyndns.org","threadId":"33076","inReplyTo":"1362487405-32044-1-git-send-email-kirr@mns.spb.ru","subject":"Re: [PATCH] Fix `make install` when configured with autoconf","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-05T16:56:29Z","receivedAt":"2013-03-05T16:56:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}