{"thread":{"id":"3303","subject":"[PATCH] Use a relative path for SVN importing","startedAt":"2006-02-11T15:44:11Z","lastAt":"2006-02-13T20:52:43Z","messageCount":3,"participants":["Christian Biesinger","Eduardo Pereira Habkost"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"15926","messageId":"1139672651713-git-send-email-cbiesinger@web.de","threadId":"3303","inReplyTo":null,"subject":"[PATCH] Use a relative path for SVN importing","fromName":"Christian Biesinger","fromEmail":"cbiesinger@web.de","sentAt":"2006-02-11T15:44:11Z","receivedAt":"2006-02-11T15:44:11Z","isPatch":true,"sender":{"key":"cbiesinger@web.de","avatar":null},"body":"The absolute path (with the leading slash) breaks SVN importing, because it then\nlooks for /trunk/... instead of /svn/trunk/... (in my case, the repository URL\nwas https://servername/svn/)\n\nSigned-off-by: Christian Biesinger <cbiesinger@web.de>\n\n---\n\n git-svnimport.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n7718b5a5fec01c0774f6b9cdc84f908e68b403ac\ndiff --git a/git-svnimport.perl b/git-svnimport.perl\nindex b6799d8..f17d5a2 100755\n--- a/git-svnimport.perl\n+++ b/git-svnimport.perl\n@@ -318,7 +318,7 @@ sub get_file($$$) {\n \t\t\tdie $res->status_line.\" at $url\\n\";\n \t\t}\n \t} else {\n-\t\t$name = $svn->file(\"/$svnpath\",$rev);\n+\t\t$name = $svn->file(\"$svnpath\",$rev);\n \t\treturn undef unless defined $name;\n \t}\n \n-- \n1.1.6.g486a-dirty\n"},{"id":"15927","messageId":"43EE1908.1000300@web.de","threadId":"3303","inReplyTo":"1139672651713-git-send-email-cbiesinger@web.de","subject":"Re: [PATCH] Use a relative path for SVN importing","fromName":"Christian Biesinger","fromEmail":"cbiesinger@web.de","sentAt":"2006-02-11T17:04:08Z","receivedAt":"2006-02-11T17:04:08Z","isPatch":true,"sender":{"key":"cbiesinger@web.de","avatar":null},"body":"Christian Biesinger wrote:\n> The absolute path (with the leading slash) breaks SVN importing, because it then\n> looks for /trunk/... instead of /svn/trunk/... (in my case, the repository URL\n> was https://servername/svn/)\n\nI also tested a svn+ssh case and that works too (it also worked before, \noddly enough).\n"},{"id":"16055","messageId":"20060213205243.GF4323@duckman.conectiva","threadId":"3303","inReplyTo":"1139672651713-git-send-email-cbiesinger@web.de","subject":"git-svnimport -d and -D options (was Re: [PATCH] Use a relative path for SVN importing)","fromName":"Eduardo Pereira Habkost","fromEmail":"ehabkost@mandriva.com","sentAt":"2006-02-13T20:52:43Z","receivedAt":"2006-02-13T20:52:43Z","isPatch":true,"sender":{"key":"ehabkost@mandriva.com","avatar":null},"body":"Hi,\n\nOn Sat, Feb 11, 2006 at 04:44:11PM +0100, Christian Biesinger wrote:\n> The absolute path (with the leading slash) breaks SVN importing, because it then\n> looks for /trunk/... instead of /svn/trunk/... (in my case, the repository URL\n> was https://servername/svn/)\n\nI've hit this bug today, and fortunately I've found the fix from\nChristian. Thanks! :)\n\nI am wondering if this bug was the initial reason why the -d and -D\noptions where added to git-svnimport.\n\nIs there another real reason why the -d and -D options exist in\ngit-svnimport?\n\nThe documentation for the options say that the \"wrong\" option will die\nwith 40x, but the commit message[1] says something about \"internal server\nerror\". I don't know which one is right.\n\nMathias, couldn't be the errors you described in the commit message\nrelated to this bug?\n\n[1] http://www.kernel.org/git/?p=git/git.git;a=commit;h=25f6f325d7a8f7cb686a9ffd9fa2c00b3aa85a60\n\n-- \nEduardo\n"}]}