{"thread":{"id":"32814","subject":"[RFC/PATCH] config.mak.in: remove unused definitions","startedAt":"2013-02-03T01:58:49Z","lastAt":"2013-02-03T01:58:49Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"208529","messageId":"7v1ucyb1k6.fsf@alter.siamese.dyndns.org","threadId":"32814","inReplyTo":null,"subject":"[RFC/PATCH] config.mak.in: remove unused definitions","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-02-03T01:58:49Z","receivedAt":"2013-02-03T01:58:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"When 5566771 (autoconf: Use autoconf to write installation\ndirectories to config.mak.autogen, 2006-07-03) introduced support\nfor autoconf generated config.mak file, it added a few \"export\",\nin addition to definitions of srcdir and VPATH.\n\nThese \"export\" logically does not belong there.  The common make\nvariables like mandir, prefix, etc, should be exported to submakes\nfor people who use config.mak and people who use config.mak.autogen\nthe same way, so if we want to get these exported, that should be in\nthe main Makefile, no?\n\nWe do use mandir and htmldir in Documentation/Makefile, so let's\nadd export for them in the main Makefile instead.\n\nWe may eventually want to support VPATH, and srcdir may turn out to\nbe useful for that purpose, but right now nobody uses it, so it is\nuseless to define them in this file.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n\n * As everybody knows, I do not use autoconf/configure, so this may\n   be breaking things for those who do.  Comments, objectsions, and\n   general education etc. are very much appreciated.\n\n Makefile      | 2 +-\n config.mak.in | 7 -------\n 2 files changed, 1 insertion(+), 8 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 731b6a8..e946402 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -384,7 +384,7 @@ lib = lib\n # DESTDIR =\n pathsep = :\n \n-export prefix bindir sharedir sysconfdir gitwebdir localedir\n+export prefix bindir sharedir mandir htmldir sysconfdir gitwebdir localedir\n \n CC = cc\n AR = ar\ndiff --git a/config.mak.in b/config.mak.in\nindex e8a9bb4..f87c18c 100644\n--- a/config.mak.in\n+++ b/config.mak.in\n@@ -11,7 +11,6 @@ DIFF = @DIFF@\n #INSTALL = @INSTALL@\t\t# needs install-sh or install.sh in sources\n \n prefix = @prefix@\n-exec_prefix = @exec_prefix@\n bindir = @bindir@\n gitexecdir = @libexecdir@/git-core\n datarootdir = @datarootdir@\n@@ -19,9 +18,3 @@ template_dir = @datadir@/git-core/templates\n sysconfdir = @sysconfdir@\n \n mandir = @mandir@\n-\n-srcdir = @srcdir@\n-VPATH = @srcdir@\n-\n-export exec_prefix mandir\n-export srcdir VPATH\n"}]}