{"thread":{"id":"32813","subject":"[PATCH] Honor configure's htmldir switch","startedAt":"2013-02-02T21:25:11Z","lastAt":"2013-02-03T04:50:32Z","messageCount":4,"participants":["Christoph J. Thompson","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"208527","messageId":"20130202212504.GA16412@gmail.com","threadId":"32813","inReplyTo":null,"subject":"[PATCH] Honor configure's htmldir switch","fromName":"Christoph J. Thompson","fromEmail":"cjsthompson@gmail.com","sentAt":"2013-02-02T21:25:11Z","receivedAt":"2013-02-02T21:25:11Z","isPatch":true,"sender":{"key":"cjsthompson@gmail.com","avatar":null},"body":"Honor autoconf's --htmldir switch. This allows relocating HTML docs \nstraight from the configure script.\n\n\nSigned-off-by: Christoph J. Thompson \n---\n config.mak.in | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.in b/config.mak.in\nindex e8a9bb4..d7c49cd 100644\n--- a/config.mak.in\n+++ b/config.mak.in\n@@ -19,6 +19,7 @@ template_dir = @datadir@/git-core/templates\n sysconfdir = @sysconfdir@\n \n mandir = @mandir@\n+htmldir = @htmldir@\n \n srcdir = @srcdir@\n VPATH = @srcdir@\n-- \n1.8.1.2\n"},{"id":"208528","messageId":"7v7gmqb30p.fsf@alter.siamese.dyndns.org","threadId":"32813","inReplyTo":"20130202212504.GA16412@gmail.com","subject":"Re: [PATCH] Honor configure's htmldir switch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-02-03T01:27:18Z","receivedAt":"2013-02-03T01:27:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Christoph J. Thompson\" writes:\n\n> Honor autoconf's --htmldir switch. This allows relocating HTML docs \n> straight from the configure script.\n>\n>\n> Signed-off-by: Christoph J. Thompson \n> ---\n> config.mak.in | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/config.mak.in b/config.mak.in\n> index e8a9bb4..d7c49cd 100644\n> --- a/config.mak.in\n> +++ b/config.mak.in\n> @@ -19,6 +19,7 @@ template_dir = @datadir@/git-core/templates\n> sysconfdir = @sysconfdir@\n> \n> mandir = @mandir@\n> +htmldir = @htmldir@\n> \n> srcdir = @srcdir@\n> VPATH = @srcdir@\n\nHmph, in the output of \"git grep -e mandir config.mak.in\", I see\n\n export exec_prefix mandir\n\nwhich makes me wonder if we should either export htmldir as well, or\ndrop mandir from the \"export\". Off-hand, I am not sure which is the\nright way, but in either case the inconsistency disturbs me.\n\nThanks.\n"},{"id":"208530","messageId":"7vtxpu9ipo.fsf@alter.siamese.dyndns.org","threadId":"32813","inReplyTo":"CA+7ShCrB_1Q=aKw5sP5hLkM1o0v-P1WR5+1iL983X7WQCHP=oQ@mail.gmail.com","subject":"Re: [PATCH] Honor configure's htmldir switch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-02-03T03:31:15Z","receivedAt":"2013-02-03T03:31:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christoph Thompson writes:\n\n> Will the --htmldir switch still work by exporting mandir and htmldir from\n> the Makefile instead of\n> config.mak.in ?\n\nIt should not make a difference where you export them from. Lets\nsee...\n\n-- cut here -- >8 -- cut here --\n\n$ cat >Makefile <<\\EOF\n# The default target of this Makefile is ...\nall:\n\nvar1 = one\nvar2 = two\nvar5 = five\nvar7 = seven\nvar8 = eight\ninclude config.mak\n\nexport var2 var4 var8\n\nall:\n\tenv | grep '^var'\n\nEOF\n$ cat >config.mak <<\\EOF\nvar3 = three\nvar4 = four\nvar6 = six\nvar7 = siete\nvar8 = ocho\n\nexport var1 var3 var7\nEOF\n$ make\nenv | grep '^var'\nvar1=one\nvar3=three\nvar2=two\nvar4=four\nvar7=siete\nvar8=ocho\n\n-- cut here -- 8< -- cut here --\n\nEverything behaves as I expect, I think.\n"},{"id":"208531","messageId":"7vpq0i9f1j.fsf@alter.siamese.dyndns.org","threadId":"32813","inReplyTo":"CA+7ShCqxDKHw0dzC6ASH=qpjG_MP-QZxOyMxQmoTKhXc7ZYHuA@mail.gmail.com","subject":"Re: [PATCH] Honor configure's htmldir switch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-02-03T04:50:32Z","receivedAt":"2013-02-03T04:50:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christoph Thompson writes:\n\n[administrivia: why do you keep dropping git@vger from Cc???]\n\n> I was under the impression that configure passed on the value of it's\n> --htmldir switch by doing\n> some substitution work like the following :\n>\n> sed 's|@htmldir@|$(htmldir)|g' config.mak.in > config.mak\n\nThe information flow goes more like this:\n\n * configure.ac is used to generate the configure script with\n autoconf;\n\n * configure script is driven by the user and finds the system\n characteristics and user's wish;\n\n * what configure found out is used to generate config.mak.autogen,\n using config.mak.in as a template; and then\n\n * the primary Makefile reads config.mak.autogen if exists and then\n config.mak if exists.\n\nNote that use of ./configure is entirely optional for the build\nsystem of Git. You can give parameters to make on its command line\n(without having config.mak or config.mak.autogen), or you can give\nthese parameters in handwritten config.mak and just say \"make\".\n\nYou can also use ./configure to write some reasonable values in\nconfig.mak.autogen, but if ./configure guesses things incorrrectly,\nyou can still override them in your handwritten config.mak exactly\nbecause it is read after config.mak.autogen is read by Makefile.\n"}]}