{"thread":{"id":"32674","subject":"[PATCH v2] INSTALL: git-p4 doesn't support Python 3","startedAt":"2013-01-20T11:06:20Z","lastAt":"2013-01-20T21:03:10Z","messageCount":5,"participants":["John Keeping","Junio C Hamano","Brandon Casey"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"207288","messageId":"20130120110620.GJ31172@serenity.lan","threadId":"32674","inReplyTo":null,"subject":"[PATCH v2] INSTALL: git-p4 doesn't support Python 3","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-01-20T11:06:20Z","receivedAt":"2013-01-20T11:06:20Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"git-p4 supports Python 2.6 and later versions of Python 2. Since Python\n2.8 will never exist [1], it is most concise to just list the supported\nversions.\n\n[1] http://www.python.org/dev/peps/pep-0404/\n\nSigned-off-by: John Keeping \nAcked-by: Pete Wyckoff \n---\nSince v1:\n - Fixed a typo in the commit message.\n\n INSTALL | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/INSTALL b/INSTALL\nindex 28f34bd..c456d1c 100644\n--- a/INSTALL\n+++ b/INSTALL\n@@ -131,7 +131,7 @@ Issues of note:\n \t use English. Under autoconf the configure script will do this\n \t automatically if it can't find libintl on the system.\n \n-\t- Python version 2.6 or later is needed to use the git-p4\n+\t- Python version 2.6 or 2.7 is needed to use the git-p4\n \t interface to Perforce.\n \n - Some platform specific issues are dealt with Makefile rules,\n-- \n1.8.1.353.gc992d5a.dirty\n"},{"id":"207317","messageId":"7vwqv7lm6b.fsf@alter.siamese.dyndns.org","threadId":"32674","inReplyTo":"20130120110620.GJ31172@serenity.lan","subject":"Re: [PATCH v2] INSTALL: git-p4 doesn't support Python 3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-20T18:54:52Z","receivedAt":"2013-01-20T18:54:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"John Keeping writes:\n\n> git-p4 supports Python 2.6 and later versions of Python 2. Since Python\n> 2.8 will never exist [1], it is most concise to just list the supported\n> versions.\n\nThanks; Eric's patch recently updated git-p4.py to require 2.4 I\nthink. Shouldn't it also be updated?\n\n>\n> [1] http://www.python.org/dev/peps/pep-0404/\n>\n> Signed-off-by: John Keeping \n> Acked-by: Pete Wyckoff \n> ---\n> Since v1:\n> - Fixed a typo in the commit message.\n>\n> INSTALL | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/INSTALL b/INSTALL\n> index 28f34bd..c456d1c 100644\n> --- a/INSTALL\n> +++ b/INSTALL\n> @@ -131,7 +131,7 @@ Issues of note:\n> \t use English. Under autoconf the configure script will do this\n> \t automatically if it can't find libintl on the system.\n> \n> -\t- Python version 2.6 or later is needed to use the git-p4\n> +\t- Python version 2.6 or 2.7 is needed to use the git-p4\n> \t interface to Perforce.\n> \n> - Some platform specific issues are dealt with Makefile rules,\n"},{"id":"207324","messageId":"20130120192831.GB7498@serenity.lan","threadId":"32674","inReplyTo":"7vwqv7lm6b.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH v2] INSTALL: git-p4 doesn't support Python 3","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-01-20T19:28:31Z","receivedAt":"2013-01-20T19:28:31Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"On Sun, Jan 20, 2013 at 10:54:52AM -0800, Junio C Hamano wrote:\n> John Keeping writes:\n> \n>> git-p4 supports Python 2.6 and later versions of Python 2. Since Python\n>> 2.8 will never exist [1], it is most concise to just list the supported\n>> versions.\n> \n> Thanks; Eric's patch recently updated git-p4.py to require 2.4 I\n> think. Shouldn't it also be updated?\n\nI haven't done a thorough audit to check what the actual minimum\nsupported version is, this is just the minimal change to say \"not\nPython 3\".\n\nPersonally, I'm not sure of the value of having version checks at the\ntop of the Python scripts, I would rather set a project-wide minimum\nsupported version (as in my recent CodingGuidelines patch) and check it\nonce in the Makefile.\n\n\nJohn\n"},{"id":"207326","messageId":"7vd2wzljep.fsf@alter.siamese.dyndns.org","threadId":"32674","inReplyTo":"20130120192831.GB7498@serenity.lan","subject":"Re: [PATCH v2] INSTALL: git-p4 doesn't support Python 3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-20T19:54:38Z","receivedAt":"2013-01-20T19:54:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"John Keeping writes:\n\n> On Sun, Jan 20, 2013 at 10:54:52AM -0800, Junio C Hamano wrote:\n>> John Keeping writes:\n>> \n>>> git-p4 supports Python 2.6 and later versions of Python 2. Since Python\n>>> 2.8 will never exist [1], it is most concise to just list the supported\n>>> versions.\n>> \n>> Thanks; Eric's patch recently updated git-p4.py to require 2.4 I\n>> think. Shouldn't it also be updated?\n>\n> I haven't done a thorough audit to check what the actual minimum\n> supported version is, this is just the minimal change to say \"not\n> Python 3\".\n>\n> Personally, I'm not sure of the value of having version checks at the\n> top of the Python scripts, I would rather set a project-wide minimum\n> supported version (as in my recent CodingGuidelines patch) and check it\n> once in the Makefile.\n\nOK; I'll leave that for later a day (Cc'ed Eric but stakeholders of\nother Python scripts may want to express their opinions), and will\napply this patch as is.\n\nIf we end up deciding to rip out the \"prerequisite per file\", that\nwill be a tree-wide change that is independent from your patch we\nare discussing in this thread. If we end up not doing that, then we\nwould instead be updating git-p4.py to set a higher floor to the\nprerequiste but that can come as a separate patch.\n\nThanks.\n"},{"id":"207333","messageId":"CA+sFfMfCi-cvgRXE7KnPAsQpMWFR8eMiG0wQ0vL+p+U=R2R2qw@mail.gmail.com","threadId":"32674","inReplyTo":"20130120192831.GB7498@serenity.lan","subject":"Re: [PATCH v2] INSTALL: git-p4 doesn't support Python 3","fromName":"Brandon Casey","fromEmail":"drafnel@gmail.com","sentAt":"2013-01-20T21:03:10Z","receivedAt":"2013-01-20T21:03:10Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"On Sun, Jan 20, 2013 at 11:28 AM, John Keeping wrote:\n> On Sun, Jan 20, 2013 at 10:54:52AM -0800, Junio C Hamano wrote:\n>> John Keeping writes:\n>>\n>>> git-p4 supports Python 2.6 and later versions of Python 2. Since Python\n>>> 2.8 will never exist [1], it is most concise to just list the supported\n>>> versions.\n>>\n>> Thanks; Eric's patch recently updated git-p4.py to require 2.4 I\n>> think. Shouldn't it also be updated?\n\nActually, the script does not support python 2.4 in its current state\nsince it uses subprocess.check_call which was introduced in python\n2.5.\n\nBut, this can be trivially worked around. I made the changes in my\nown tree on Friday and planned to submit them after using it myself\nfor a few days.\n\nPersonally, I prefer to continue to provide the ability to compile and\ninstall a fully working git on platforms in common use without pulling\nin additional dependencies. At least while it's fairly easy to do so.\n So, in my opinion, git-p4 should be patched to support python 2.4 and\nthe comment in INSTALL should be updated. But, this opinion should be\ntaken with the appropriate grain of salt since I'm not really a\ncontributor to any of the python infrastructure.\n\n-Brandon\n"}]}