{"thread":{"id":"32637","subject":"[PATCH] test-lib.sh: unfilter GIT_PERF_*","startedAt":"2013-01-15T12:53:29Z","lastAt":"2013-01-16T18:54:16Z","messageCount":7,"participants":["Nguyễn Thái Ngọc Duy","Thomas Rast","Duy Nguyen","Junio C Hamano","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"206931","messageId":"1358254409-15187-1-git-send-email-pclouds@gmail.com","threadId":"32637","inReplyTo":null,"subject":"[PATCH] test-lib.sh: unfilter GIT_PERF_*","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2013-01-15T12:53:29Z","receivedAt":"2013-01-15T12:53:29Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"These variables are user parameters to control how to run the perf\ntests. Allow users to do so.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n t/test-lib.sh | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex f50f834..b8d35d1 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $(\"$PERL_PATH\" -e '\n \t\tPROVE\n \t\tVALGRIND\n \t\tPERF_AGGREGATING_LATER\n+\t\tPERF_LARGE_REPO\n+\t\tPERF_REPEAT_COUNT\n+\t\tPERF_REPO\n \t));\n \tmy @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n \tprint join(\"\\n\", @vars);\n-- \n1.8.0.rc2.23.g1fb49df\n"},{"id":"206935","messageId":"87ehhmr28g.fsf@pctrast.inf.ethz.ch","threadId":"32637","inReplyTo":"1358254409-15187-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] test-lib.sh: unfilter GIT_PERF_*","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2013-01-15T13:43:11Z","receivedAt":"2013-01-15T13:43:11Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:\n\n> These variables are user parameters to control how to run the perf\n> tests. Allow users to do so.\n[...]\n> @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $(\"$PERL_PATH\" -e '\n>  \t\tPROVE\n>  \t\tVALGRIND\n>  \t\tPERF_AGGREGATING_LATER\n> +\t\tPERF_LARGE_REPO\n> +\t\tPERF_REPEAT_COUNT\n> +\t\tPERF_REPO\n>  \t));\n\nWouldn't it be more futureproof to put simply PERF as an entry, and rely\non the leading-match logic\n\n> \tmy @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n\nto allow all GIT_PERF variables?\n\nOther than that, Ack.  I never noticed because I set mine through\nconfig.mak, which goes to GIT-BUILD-OPTIONS.  Those options are not\nexported, which means perl does not pick them up.  (That just took me\nfar too long to realize.)\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"206936","messageId":"CACsJy8BaPfiHL86uh8QOKXzBXb3eKiRnN1MV0e8WegsFzodWHQ@mail.gmail.com","threadId":"32637","inReplyTo":"87ehhmr28g.fsf@pctrast.inf.ethz.ch","subject":"Re: [PATCH] test-lib.sh: unfilter GIT_PERF_*","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2013-01-15T13:47:52Z","receivedAt":"2013-01-15T13:47:52Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Tue, Jan 15, 2013 at 8:43 PM, Thomas Rast <trast@student.ethz.ch> wrote:\n> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:\n>\n>> These variables are user parameters to control how to run the perf\n>> tests. Allow users to do so.\n> [...]\n>> @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $(\"$PERL_PATH\" -e '\n>>               PROVE\n>>               VALGRIND\n>>               PERF_AGGREGATING_LATER\n>> +             PERF_LARGE_REPO\n>> +             PERF_REPEAT_COUNT\n>> +             PERF_REPO\n>>       ));\n>\n> Wouldn't it be more futureproof to put simply PERF as an entry, and rely\n> on the leading-match logic\n>\n>>       my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n>\n> to allow all GIT_PERF variables?\n\nYeah.\n\n> Other than that, Ack.  I never noticed because I set mine through\n> config.mak, which goes to GIT-BUILD-OPTIONS.  Those options are not\n> exported, which means perl does not pick them up.  (That just took me\n> far too long to realize.)\n\nBy the way is there an option to skip the first few runs (too lazy to\ncheck out the source code, apparently)? I tried linux-2.6 as the large\nrepo and I think the first (cold cache) run ruins the numbers.\n-- \nDuy\n"},{"id":"206937","messageId":"1358257856-3274-1-git-send-email-pclouds@gmail.com","threadId":"32637","inReplyTo":"1358254409-15187-1-git-send-email-pclouds@gmail.com","subject":"[PATCH v2] test-lib.sh: unfilter GIT_PERF_*","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2013-01-15T13:50:56Z","receivedAt":"2013-01-15T13:50:56Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"These variables are user parameters to control how to run the perf\ntests. Allow users to do so.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n t/test-lib.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex f50f834..e1c8c85 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $(\"$PERL_PATH\" -e '\n \t\t.*_TEST\n \t\tPROVE\n \t\tVALGRIND\n-\t\tPERF_AGGREGATING_LATER\n+\t\tPERF\n \t));\n \tmy @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n \tprint join(\"\\n\", @vars);\n-- \n1.8.0.rc2.23.g1fb49df\n"},{"id":"206966","messageId":"7vsj622qft.fsf@alter.siamese.dyndns.org","threadId":"32637","inReplyTo":"1358257856-3274-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH v2] test-lib.sh: unfilter GIT_PERF_*","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-15T19:31:50Z","receivedAt":"2013-01-15T19:31:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:\n\n> These variables are user parameters to control how to run the perf\n> tests. Allow users to do so.\n>\n> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n> ---\n\nI think the Subject makes more sense, so I'd suggest replacing the\ncurrent one with \"PERF_\", not with \"PERF\".\n\n>  t/test-lib.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/test-lib.sh b/t/test-lib.sh\n> index f50f834..e1c8c85 100644\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $(\"$PERL_PATH\" -e '\n>  \t\t.*_TEST\n>  \t\tPROVE\n>  \t\tVALGRIND\n> -\t\tPERF_AGGREGATING_LATER\n> +\t\tPERF\n>  \t));\n>  \tmy @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n>  \tprint join(\"\\n\", @vars);\n"},{"id":"207042","messageId":"1358331833-8289-1-git-send-email-pclouds@gmail.com","threadId":"32637","inReplyTo":"1358257856-3274-1-git-send-email-pclouds@gmail.com","subject":"[PATCH v3] test-lib.sh: unfilter GIT_PERF_*","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2013-01-16T10:23:53Z","receivedAt":"2013-01-16T10:23:53Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"These variables are user parameters to control how to run the perf\ntests. Allow users to do so.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n PERF -> PERF_\n\n t/test-lib.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex f50f834..bf4cf71 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $(\"$PERL_PATH\" -e '\n \t\t.*_TEST\n \t\tPROVE\n \t\tVALGRIND\n-\t\tPERF_AGGREGATING_LATER\n+\t\tPERF_\n \t));\n \tmy @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n \tprint join(\"\\n\", @vars);\n-- \n1.8.0.rc2.23.g1fb49df\n"},{"id":"207093","messageId":"20130116185416.GA28866@google.com","threadId":"32637","inReplyTo":"1358331833-8289-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH v3] test-lib.sh: unfilter GIT_PERF_*","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-01-16T18:54:16Z","receivedAt":"2013-01-16T18:54:16Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Nguyễn Thái Ngọc Duy wrote:\n\n> These variables are user parameters to control how to run the perf\n> tests. Allow users to do so.\n>\n> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n\nFWIW, of the three versions proposed, this one makes the most sense to\nme.  Looks good.\n"}]}