{"thread":{"id":"32630","subject":"[PATCH] am: invoke perl's strftime in C locale","startedAt":"2013-01-14T20:59:33Z","lastAt":"2013-01-20T17:47:22Z","messageCount":13,"participants":["Dmitry V. Levin","Junio C Hamano","Jeff King","Antoine Pelisse"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"206841","messageId":"20130114205933.GA25947@altlinux.org","threadId":"32630","inReplyTo":null,"subject":"[PATCH] am: invoke perl's strftime in C locale","fromName":"Dmitry V. Levin","fromEmail":"ldv@altlinux.org","sentAt":"2013-01-14T20:59:33Z","receivedAt":"2013-01-14T20:59:33Z","isPatch":true,"sender":{"key":"ldv@altlinux.org","avatar":"https://avatars.githubusercontent.com/u/5281408?v=4"},"body":"This fixes \"hg\" patch format support for locales other than C and en_*,\nsee https://bugzilla.altlinux.org/show_bug.cgi?id=28248\n\nSigned-off-by: Dmitry V. Levin <ldv@altlinux.org>\n---\n git-am.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-am.sh b/git-am.sh\nindex c682d34..64b88e4 100755\n--- a/git-am.sh\n+++ b/git-am.sh\n@@ -334,7 +334,7 @@ split_patches () {\n \t\t\t# Since we cannot guarantee that the commit message is in\n \t\t\t# git-friendly format, we put no Subject: line and just consume\n \t\t\t# all of the message as the body\n-\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n+\t\t\tLC_ALL=C perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n \t\t\t\tif ($subject) { print ; }\n \t\t\t\telsif (/^\\# User /) { s/\\# User/From:/ ; print ; }\n \t\t\t\telsif (/^\\# Date /) {\n\n-- \nldv\n"},{"id":"206843","messageId":"7vr4ln8mgd.fsf@alter.siamese.dyndns.org","threadId":"32630","inReplyTo":"20130114205933.GA25947@altlinux.org","subject":"Re: [PATCH] am: invoke perl's strftime in C locale","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-14T21:49:06Z","receivedAt":"2013-01-14T21:49:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Dmitry V. Levin\" <ldv@altlinux.org> writes:\n\n> This fixes \"hg\" patch format support for locales other than C and en_*,\n> see https://bugzilla.altlinux.org/show_bug.cgi?id=28248\n>\n> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>\n> ---\n\nThanks.\n\nThe reference URL is not very friendly, and you should be able to\nstate it here on a single line in English instead, I think.\n\nThe patch looks correct, though.\n\n>  git-am.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/git-am.sh b/git-am.sh\n> index c682d34..64b88e4 100755\n> --- a/git-am.sh\n> +++ b/git-am.sh\n> @@ -334,7 +334,7 @@ split_patches () {\n>  \t\t\t# Since we cannot guarantee that the commit message is in\n>  \t\t\t# git-friendly format, we put no Subject: line and just consume\n>  \t\t\t# all of the message as the body\n> -\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n> +\t\t\tLC_ALL=C perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n>  \t\t\t\tif ($subject) { print ; }\n>  \t\t\t\telsif (/^\\# User /) { s/\\# User/From:/ ; print ; }\n>  \t\t\t\telsif (/^\\# Date /) {\n"},{"id":"206847","messageId":"20130114223651.GA26443@altlinux.org","threadId":"32630","inReplyTo":"7vr4ln8mgd.fsf@alter.siamese.dyndns.org","subject":"[PATCH v2] am: invoke perl's strftime in C locale","fromName":"Dmitry V. Levin","fromEmail":"ldv@altlinux.org","sentAt":"2013-01-14T22:36:52Z","receivedAt":"2013-01-14T22:36:52Z","isPatch":true,"sender":{"key":"ldv@altlinux.org","avatar":"https://avatars.githubusercontent.com/u/5281408?v=4"},"body":"This fixes \"hg\" patch format support for locales other than C and en_*.\nBefore the change, git-am was making \"Date:\" line from hg changeset\nmetadata according to the current locale, and this line was rejected\nlater with \"invalid date format\" diagnostics because localized date\nstrings are not supported.\n\nReported-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>\nSigned-off-by: Dmitry V. Levin <ldv@altlinux.org>\n---\n\n v2: replaced \"unfriendly\" URL with a short description\n\n git-am.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-am.sh b/git-am.sh\nindex c682d34..64b88e4 100755\n--- a/git-am.sh\n+++ b/git-am.sh\n@@ -334,7 +334,7 @@ split_patches () {\n \t\t\t# Since we cannot guarantee that the commit message is in\n \t\t\t# git-friendly format, we put no Subject: line and just consume\n \t\t\t# all of the message as the body\n-\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n+\t\t\tLC_ALL=C perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n \t\t\t\tif ($subject) { print ; }\n \t\t\t\telsif (/^\\# User /) { s/\\# User/From:/ ; print ; }\n \t\t\t\telsif (/^\\# Date /) {\n\n-- \nldv\n"},{"id":"206942","messageId":"20130115155953.GB21815@sigill.intra.peff.net","threadId":"32630","inReplyTo":"20130114205933.GA25947@altlinux.org","subject":"Re: [PATCH] am: invoke perl's strftime in C locale","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-01-15T15:59:53Z","receivedAt":"2013-01-15T15:59:53Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Jan 15, 2013 at 12:59:33AM +0400, Dmitry V. Levin wrote:\n\n> diff --git a/git-am.sh b/git-am.sh\n> index c682d34..64b88e4 100755\n> --- a/git-am.sh\n> +++ b/git-am.sh\n> @@ -334,7 +334,7 @@ split_patches () {\n>  \t\t\t# Since we cannot guarantee that the commit message is in\n>  \t\t\t# git-friendly format, we put no Subject: line and just consume\n>  \t\t\t# all of the message as the body\n> -\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n> +\t\t\tLC_ALL=C perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n>  \t\t\t\tif ($subject) { print ; }\n>  \t\t\t\telsif (/^\\# User /) { s/\\# User/From:/ ; print ; }\n>  \t\t\t\telsif (/^\\# Date /) {\n\nThis puts all of perl into the C locale, which would mean error messages\nfrom perl would be in English rather than the user's language. It\nprobably isn't a big deal, because that snippet of perl is short and not\nlikely to produce problems, but I wonder how hard it would be to set the\nlocale just for the strftime call.\n\n-Peff\n"},{"id":"206946","messageId":"CALWbr2w+q5=Z8__g+J_s2NtTMgziHrntFqsi8vCJyvfO2qi81A@mail.gmail.com","threadId":"32630","inReplyTo":"20130115155953.GB21815@sigill.intra.peff.net","subject":"Re: [PATCH] am: invoke perl's strftime in C locale","fromName":"Antoine Pelisse","fromEmail":"apelisse@gmail.com","sentAt":"2013-01-15T16:42:12Z","receivedAt":"2013-01-15T16:42:12Z","isPatch":true,"sender":{"key":"apelisse@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1929644?v=4"},"body":"> This puts all of perl into the C locale, which would mean error messages\n> from perl would be in English rather than the user's language. It\n> probably isn't a big deal, because that snippet of perl is short and not\n> likely to produce problems, but I wonder how hard it would be to set the\n> locale just for the strftime call.\n\nMaybe just setting LC_TIME to C would do ...\n\n>From locale(7) man page:\n\n       LC_TIME\n              changes  the behavior of the strftime(3) function to\ndisplay the current time in a locally acceptable form; for\n              example, most of Europe uses a 24-hour clock versus the\n12-hour clock used in the United States.\n"},{"id":"206947","messageId":"20130115165058.GA29301@sigill.intra.peff.net","threadId":"32630","inReplyTo":"CALWbr2w+q5=Z8__g+J_s2NtTMgziHrntFqsi8vCJyvfO2qi81A@mail.gmail.com","subject":"Re: [PATCH] am: invoke perl's strftime in C locale","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-01-15T16:50:59Z","receivedAt":"2013-01-15T16:50:59Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Jan 15, 2013 at 05:42:12PM +0100, Antoine Pelisse wrote:\n\n> > This puts all of perl into the C locale, which would mean error messages\n> > from perl would be in English rather than the user's language. It\n> > probably isn't a big deal, because that snippet of perl is short and not\n> > likely to produce problems, but I wonder how hard it would be to set the\n> > locale just for the strftime call.\n> \n> Maybe just setting LC_TIME to C would do ...\n\nYeah, that is a nice simple solution. Dmitry, does just setting LC_TIME\nfix the problem for you?\n\n-Peff\n"},{"id":"206954","messageId":"20130115174015.GA7471@altlinux.org","threadId":"32630","inReplyTo":"20130115165058.GA29301@sigill.intra.peff.net","subject":"Re: [PATCH] am: invoke perl's strftime in C locale","fromName":"Dmitry V. Levin","fromEmail":"ldv@altlinux.org","sentAt":"2013-01-15T17:40:16Z","receivedAt":"2013-01-15T17:40:16Z","isPatch":true,"sender":{"key":"ldv@altlinux.org","avatar":"https://avatars.githubusercontent.com/u/5281408?v=4"},"body":"On Tue, Jan 15, 2013 at 08:50:59AM -0800, Jeff King wrote:\n> On Tue, Jan 15, 2013 at 05:42:12PM +0100, Antoine Pelisse wrote:\n> \n> > > This puts all of perl into the C locale, which would mean error messages\n> > > from perl would be in English rather than the user's language. It\n> > > probably isn't a big deal, because that snippet of perl is short and not\n> > > likely to produce problems, but I wonder how hard it would be to set the\n> > > locale just for the strftime call.\n> > \n> > Maybe just setting LC_TIME to C would do ...\n> \n> Yeah, that is a nice simple solution. Dmitry, does just setting LC_TIME\n> fix the problem for you?\n\nJust setting LC_TIME environment variable instead of LC_ALL would end up\nwith unreliable solution because LC_ALL has the highest priority.\n\nIf keeping error messages from perl has the utmost importance, it could be\nachieved by\n-\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n+\t\t\tperl -M'POSIX qw(strftime :locale_h)' -ne '\n+\t\t\t\tBEGIN { setlocale(LC_TIME, \"C\"); $subject = 0 }\nbut the little perl helper script we are talking about hardly worths so\nmuch efforts.\n\n\n-- \nldv\n"},{"id":"206960","messageId":"20130115190517.GB7963@altlinux.org","threadId":"32630","inReplyTo":"20130115174015.GA7471@altlinux.org","subject":"[PATCH v3] am: invoke perl's strftime in C locale","fromName":"Dmitry V. Levin","fromEmail":"ldv@altlinux.org","sentAt":"2013-01-15T19:05:17Z","receivedAt":"2013-01-15T19:05:17Z","isPatch":true,"sender":{"key":"ldv@altlinux.org","avatar":"https://avatars.githubusercontent.com/u/5281408?v=4"},"body":"This fixes \"hg\" patch format support for locales other than C and en_*.\nBefore the change, git-am was making \"Date:\" line from hg changeset\nmetadata according to the current locale, and this line was rejected\nlater with \"invalid date format\" diagnostics because localized date\nstrings are not supported.\n\nReported-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>\nSigned-off-by: Dmitry V. Levin <ldv@altlinux.org>\n---\n\n v3: alternative implementation using setlocale(LC_TIME, \"C\")\n\n git-am.sh | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/git-am.sh b/git-am.sh\nindex c682d34..8677d8c 100755\n--- a/git-am.sh\n+++ b/git-am.sh\n@@ -334,7 +334,8 @@ split_patches () {\n \t\t\t# Since we cannot guarantee that the commit message is in\n \t\t\t# git-friendly format, we put no Subject: line and just consume\n \t\t\t# all of the message as the body\n-\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n+\t\t\tperl -M'POSIX qw(strftime :locale_h)' -ne '\n+\t\t\t\tBEGIN { setlocale(LC_TIME, \"C\"); $subject = 0 }\n \t\t\t\tif ($subject) { print ; }\n \t\t\t\telsif (/^\\# User /) { s/\\# User/From:/ ; print ; }\n \t\t\t\telsif (/^\\# Date /) {\n\n-- \nldv\n"},{"id":"206963","messageId":"7v1udm45st.fsf@alter.siamese.dyndns.org","threadId":"32630","inReplyTo":"20130115174015.GA7471@altlinux.org","subject":"Re: [PATCH] am: invoke perl's strftime in C locale","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-15T19:14:42Z","receivedAt":"2013-01-15T19:14:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Dmitry V. Levin\" <ldv@altlinux.org> writes:\n\n> On Tue, Jan 15, 2013 at 08:50:59AM -0800, Jeff King wrote:\n>> On Tue, Jan 15, 2013 at 05:42:12PM +0100, Antoine Pelisse wrote:\n>> \n>> > > This puts all of perl into the C locale, which would mean error messages\n>> > > from perl would be in English rather than the user's language. It\n>> > > probably isn't a big deal, because that snippet of perl is short and not\n>> > > likely to produce problems, but I wonder how hard it would be to set the\n>> > > locale just for the strftime call.\n>> > \n>> > Maybe just setting LC_TIME to C would do ...\n>> \n>> Yeah, that is a nice simple solution. Dmitry, does just setting LC_TIME\n>> fix the problem for you?\n>\n> Just setting LC_TIME environment variable instead of LC_ALL would end up\n> with unreliable solution because LC_ALL has the highest priority.\n>\n> If keeping error messages from perl has the utmost importance, it could be\n> achieved by\n> -\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n> +\t\t\tperl -M'POSIX qw(strftime :locale_h)' -ne '\n> +\t\t\t\tBEGIN { setlocale(LC_TIME, \"C\"); $subject = 0 }\n> but the little perl helper script we are talking about hardly worths so\n> much efforts.\n\nYeah I agree that this is not worth it, I would think.\n"},{"id":"207223","messageId":"7vehhiqlcx.fsf@alter.siamese.dyndns.org","threadId":"32630","inReplyTo":"20130115190517.GB7963@altlinux.org","subject":"Re: [PATCH v3] am: invoke perl's strftime in C locale","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-18T20:36:46Z","receivedAt":"2013-01-18T20:36:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Dmitry V. Levin\" <ldv@altlinux.org> writes:\n\n> This fixes \"hg\" patch format support for locales other than C and en_*.\n> Before the change, git-am was making \"Date:\" line from hg changeset\n> metadata according to the current locale, and this line was rejected\n> later with \"invalid date format\" diagnostics because localized date\n> strings are not supported.\n>\n> Reported-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>\n> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>\n> ---\n>\n>  v3: alternative implementation using setlocale(LC_TIME, \"C\")\n>\n>  git-am.sh | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/git-am.sh b/git-am.sh\n> index c682d34..8677d8c 100755\n> --- a/git-am.sh\n> +++ b/git-am.sh\n> @@ -334,7 +334,8 @@ split_patches () {\n>  \t\t\t# Since we cannot guarantee that the commit message is in\n>  \t\t\t# git-friendly format, we put no Subject: line and just consume\n>  \t\t\t# all of the message as the body\n> -\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n> +\t\t\tperl -M'POSIX qw(strftime :locale_h)' -ne '\n> +\t\t\t\tBEGIN { setlocale(LC_TIME, \"C\"); $subject = 0 }\n\nI still haven't convinced myself that this is an improvement over\nthe simple \"LC_ALL=C LANG=C perl ...\" approach.\n\nThis alternative might be theoretically more correct if we cared\nabout the error and other messages from this Perl invocation, but it\nrequires that everybody's Perl implementation correctly supports the\nadditional -M'POSIX \":locale_h\"' and \"setlocale(LC_TIME, ...)\".\n\nI am tempted to use the previous one that puts the whole process\nunder LC_ALL=C instead, unless I hear a \"we already depend on that\nelsewhere, look at $that_code\".\n\nThanks.\n\n>  \t\t\t\tif ($subject) { print ; }\n>  \t\t\t\telsif (/^\\# User /) { s/\\# User/From:/ ; print ; }\n>  \t\t\t\telsif (/^\\# Date /) {\n"},{"id":"207268","messageId":"20130119163940.GA12307@sigill.intra.peff.net","threadId":"32630","inReplyTo":"7vehhiqlcx.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH v3] am: invoke perl's strftime in C locale","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-01-19T16:39:41Z","receivedAt":"2013-01-19T16:39:41Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jan 18, 2013 at 12:36:46PM -0800, Junio C Hamano wrote:\n\n> > diff --git a/git-am.sh b/git-am.sh\n> > index c682d34..8677d8c 100755\n> > --- a/git-am.sh\n> > +++ b/git-am.sh\n> > @@ -334,7 +334,8 @@ split_patches () {\n> >  \t\t\t# Since we cannot guarantee that the commit message is in\n> >  \t\t\t# git-friendly format, we put no Subject: line and just consume\n> >  \t\t\t# all of the message as the body\n> > -\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n> > +\t\t\tperl -M'POSIX qw(strftime :locale_h)' -ne '\n> > +\t\t\t\tBEGIN { setlocale(LC_TIME, \"C\"); $subject = 0 }\n> \n> I still haven't convinced myself that this is an improvement over\n> the simple \"LC_ALL=C LANG=C perl ...\" approach.\n\nYeah, I was the one who brought it up, but I think I was probably being\ntoo nit-picky. It almost certainly doesn't matter, and the alternatives\nare just as likely to cause problems.\n\n> I am tempted to use the previous one that puts the whole process\n> under LC_ALL=C instead, unless I hear a \"we already depend on that\n> elsewhere, look at $that_code\".\n\nI'm fine with that.\n\n-Peff\n"},{"id":"207272","messageId":"20130119202853.GD1652@altlinux.org","threadId":"32630","inReplyTo":"7vehhiqlcx.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH v3] am: invoke perl's strftime in C locale","fromName":"Dmitry V. Levin","fromEmail":"ldv@altlinux.org","sentAt":"2013-01-19T20:28:53Z","receivedAt":"2013-01-19T20:28:53Z","isPatch":true,"sender":{"key":"ldv@altlinux.org","avatar":"https://avatars.githubusercontent.com/u/5281408?v=4"},"body":"On Fri, Jan 18, 2013 at 12:36:46PM -0800, Junio C Hamano wrote:\n> \"Dmitry V. Levin\" <ldv@altlinux.org> writes:\n> \n> > This fixes \"hg\" patch format support for locales other than C and en_*.\n> > Before the change, git-am was making \"Date:\" line from hg changeset\n> > metadata according to the current locale, and this line was rejected\n> > later with \"invalid date format\" diagnostics because localized date\n> > strings are not supported.\n> >\n> > Reported-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>\n> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>\n> > ---\n> >\n> >  v3: alternative implementation using setlocale(LC_TIME, \"C\")\n> >\n> >  git-am.sh | 3 ++-\n> >  1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/git-am.sh b/git-am.sh\n> > index c682d34..8677d8c 100755\n> > --- a/git-am.sh\n> > +++ b/git-am.sh\n> > @@ -334,7 +334,8 @@ split_patches () {\n> >  \t\t\t# Since we cannot guarantee that the commit message is in\n> >  \t\t\t# git-friendly format, we put no Subject: line and just consume\n> >  \t\t\t# all of the message as the body\n> > -\t\t\tperl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }\n> > +\t\t\tperl -M'POSIX qw(strftime :locale_h)' -ne '\n> > +\t\t\t\tBEGIN { setlocale(LC_TIME, \"C\"); $subject = 0 }\n> \n> I still haven't convinced myself that this is an improvement over\n> the simple \"LC_ALL=C LANG=C perl ...\" approach.\n\nPersonally I prefer 2nd edition that is simpler and does the right thing\n(not that LC_ALL=C is necessary and sufficient, you neither need to add\nthings like LANG=C nor can relax it to LC_TIME=C).\n\n\n-- \nldv\n"},{"id":"207309","messageId":"7vvcarn3v9.fsf@alter.siamese.dyndns.org","threadId":"32630","inReplyTo":"20130119202853.GD1652@altlinux.org","subject":"Re: [PATCH v3] am: invoke perl's strftime in C locale","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-20T17:47:22Z","receivedAt":"2013-01-20T17:47:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Dmitry V. Levin\" <ldv@altlinux.org> writes:\n\n> Personally I prefer 2nd edition that is simpler and does the right thing\n> (not that LC_ALL=C is necessary and sufficient, you neither need to add\n> things like LANG=C nor can relax it to LC_TIME=C).\n\nI guess everybody involved is in agreement, then.\n\nJust FYI, \"LC_ALL=C LANG=C\" comes from the inertia dating back when\nnot everybody understood LC_*; I do not personally know of a system\nthat will be helped by the extra LANG=C these days, but I know it\nwill not hurt anybody, so...\n"}]}