{"thread":{"id":"32608","subject":"git-completion.bash should not add a space after a ref","startedAt":"2013-01-12T18:35:59Z","lastAt":"2013-01-13T23:16:32Z","messageCount":2,"participants":["Manlio Perillo","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"206614","messageId":"50F1AD0F.7080503@gmail.com","threadId":"32608","inReplyTo":null,"subject":"git-completion.bash should not add a space after a ref","fromName":"Manlio Perillo","fromEmail":"manlio.perillo@gmail.com","sentAt":"2013-01-12T18:35:59Z","receivedAt":"2013-01-12T18:35:59Z","isPatch":false,"sender":{"key":"manlio.perillo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/6217088?v=4"},"body":"-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n\nHi.\n\nThis is not really a bug, but a small usability problem.\n\nWhen completing a reference, Bash will add a space after the reference name.\n\nAs an example in:\n\n    $git show master<TAB>\n\nThe problem is that an user may want to show a tree or blog object from\nmaster:\n\n    $git show master:git.c\n\n\nA possible solution is to define a new __gitcomp_nospace function and\nuse it where appropriate.\n\nProbably the __gitcomp_nospace should be used when git_complete_file is\ncalled, and __gitcomp_nl should be used when __git_complete_revlist  is\ncalled, but I'm not sure.\n\nP.S.:\nit seems that __gitcomp_nl is **never** called with 4 arguments.\n\n\n\nRegards  Manlio\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG v1.4.10 (GNU/Linux)\nComment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/\n\niEYEARECAAYFAlDxrQ8ACgkQscQJ24LbaURHmACfRXoM+uEVDgFUtZFzUcPC5oSZ\nFGsAnAxQf+SN7GrNljxU1io4IuayHmed\n=JRVU\n-----END PGP SIGNATURE-----\n"},{"id":"206719","messageId":"7vk3rghdwv.fsf@alter.siamese.dyndns.org","threadId":"32608","inReplyTo":"50F1AD0F.7080503@gmail.com","subject":"Re: git-completion.bash should not add a space after a ref","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-13T23:16:32Z","receivedAt":"2013-01-13T23:16:32Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Manlio Perillo <manlio.perillo@gmail.com> writes:\n\n> This is not really a bug, but a small usability problem.\n>\n> When completing a reference, Bash will add a space after the reference name.\n>\n> As an example in:\n>\n>     $git show master<TAB>\n>\n> The problem is that an user may want to show a tree or blog object from\n> master:\n>\n>     $git show master:git.c\n\nOr the user may want to see only changes to the documentation, e.g.\n\n\t$ git show master Documentation/\n\nso removing a SP is a regression in the other way around.\n\nGiven that \"refer to an object in a tree\" is a much less often used\noperation, I have a feeling that the current behaviour happens to\nmake a good trade-off between these two conflicting purposes that\ncannot be satisfied both at the same time.\n"}]}