{"thread":{"id":"32591","subject":"[PATCH] git-completion.bash: Silence not a valid object errors","startedAt":"2013-01-11T08:06:22Z","lastAt":"2013-01-11T21:12:00Z","messageCount":4,"participants":["Dylan Smith","Jeff King","Junio C Hamano","Manlio Perillo"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"206500","messageId":"alpine.DEB.2.02.1301110304220.26739@antec","threadId":"32591","inReplyTo":null,"subject":"[PATCH] git-completion.bash: Silence not a valid object errors","fromName":"Dylan Smith","fromEmail":"dylan.ah.smith@gmail.com","sentAt":"2013-01-11T08:06:22Z","receivedAt":"2013-01-11T08:06:22Z","isPatch":true,"sender":{"key":"dylan.ah.smith@gmail.com","avatar":null},"body":"Trying to complete the command\n\n  git show master:./file\n\nwould cause a \"Not a valid object name\" error to be output on standard\nerror. Silence the error so it won't appear on the command line.\n\nSigned-off-by: Dylan Smith <dylan.ah.smith@gmail.com>\n---\n contrib/completion/git-completion.bash |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 0b77eb1..d4c7bfe 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -397,7 +397,7 @@ __git_complete_revlist_file ()\n \t\t*)   pfx=\"$ref:$pfx\" ;;\n \t\tesac\n \n-\t\t__gitcomp_nl \"$(git --git-dir=\"$(__gitdir)\" ls-tree \"$ls\" \\\n+\t\t__gitcomp_nl \"$(git --git-dir=\"$(__gitdir)\" ls-tree \"$ls\" 2>/dev/null \\\n \t\t\t\t| sed '/^100... blob /{\n \t\t\t\t           s,^.*\t,,\n \t\t\t\t           s,$, ,\n-- \n1.7.9.5\n"},{"id":"206535","messageId":"20130111152702.GA5219@sigill.intra.peff.net","threadId":"32591","inReplyTo":"alpine.DEB.2.02.1301110304220.26739@antec","subject":"Re: [PATCH] git-completion.bash: Silence not a valid object errors","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-01-11T15:27:02Z","receivedAt":"2013-01-11T15:27:02Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jan 11, 2013 at 03:06:22AM -0500, Dylan Smith wrote:\n\n> Trying to complete the command\n> \n>   git show master:./file\n> \n> would cause a \"Not a valid object name\" error to be output on standard\n> error. Silence the error so it won't appear on the command line.\n> \n> Signed-off-by: Dylan Smith <dylan.ah.smith@gmail.com>\n> ---\n\nThanks, I've been annoyed by this, too. The fix looks obviously correct.\n\n-Peff\n"},{"id":"206541","messageId":"7v6233d5ya.fsf@alter.siamese.dyndns.org","threadId":"32591","inReplyTo":"alpine.DEB.2.02.1301110304220.26739@antec","subject":"Re: [PATCH] git-completion.bash: Silence not a valid object errors","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-11T16:45:17Z","receivedAt":"2013-01-11T16:45:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dylan Smith <dylan.ah.smith@gmail.com> writes:\n\n> Trying to complete the command\n>\n>   git show master:./file\n>\n> would cause a \"Not a valid object name\" error to be output on standard\n> error. Silence the error so it won't appear on the command line.\n>\n> Signed-off-by: Dylan Smith <dylan.ah.smith@gmail.com>\n> ---\n\nLooks obviously correct.  Thanks.\n\n>  contrib/completion/git-completion.bash |    2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 0b77eb1..d4c7bfe 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -397,7 +397,7 @@ __git_complete_revlist_file ()\n>  \t\t*)   pfx=\"$ref:$pfx\" ;;\n>  \t\tesac\n>  \n> -\t\t__gitcomp_nl \"$(git --git-dir=\"$(__gitdir)\" ls-tree \"$ls\" \\\n> +\t\t__gitcomp_nl \"$(git --git-dir=\"$(__gitdir)\" ls-tree \"$ls\" 2>/dev/null \\\n>  \t\t\t\t| sed '/^100... blob /{\n>  \t\t\t\t           s,^.*\t,,\n>  \t\t\t\t           s,$, ,\n"},{"id":"206559","messageId":"50F08020.2010701@gmail.com","threadId":"32591","inReplyTo":"alpine.DEB.2.02.1301110304220.26739@antec","subject":"Re: [PATCH] git-completion.bash: Silence not a valid object errors","fromName":"Manlio Perillo","fromEmail":"manlio.perillo@gmail.com","sentAt":"2013-01-11T21:12:00Z","receivedAt":"2013-01-11T21:12:00Z","isPatch":true,"sender":{"key":"manlio.perillo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/6217088?v=4"},"body":"-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n\nIl 11/01/2013 09:06, Dylan Smith ha scritto:\n> Trying to complete the command\n> \n>   git show master:./file\n> \n> would cause a \"Not a valid object name\" error to be output on standard\n> error. Silence the error so it won't appear on the command line.\n> \n\nI reported the problem a few weeks ago; thanks.\n\n> [...]\n\n\nRegards  Manlio\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG v1.4.10 (GNU/Linux)\nComment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/\n\niEYEARECAAYFAlDwgCAACgkQscQJ24LbaUTAxgCfZbB8X8IaTZAcT8iTs1XIILBJ\n72MAn2zlh3xbRa/wjq1WyA2yOiAlaCr7\n=dMN7\n-----END PGP SIGNATURE-----\n"}]}