{"thread":{"id":"32582","subject":"[PATCH] git-commit-tree(1): correct description of defaults","startedAt":"2013-01-10T12:29:58Z","lastAt":"2013-01-10T18:33:59Z","messageCount":2,"participants":["Peter Eisentraut","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"206457","messageId":"1357820998.10754.6.camel@vanquo.pezone.net","threadId":"32582","inReplyTo":null,"subject":"[PATCH] git-commit-tree(1): correct description of defaults","fromName":"Peter Eisentraut","fromEmail":"peter@eisentraut.org","sentAt":"2013-01-10T12:29:58Z","receivedAt":"2013-01-10T12:29:58Z","isPatch":true,"sender":{"key":"peter@eisentraut.org","avatar":"https://avatars.githubusercontent.com/u/105543?v=4"},"body":"The old phrasing indicated that the EMAIL environment variable takes\nprecedence over the user.email configuration setting, but it is the\nother way around.\n\nSigned-off-by: Peter Eisentraut <peter@eisentraut.org>\n---\n Documentation/git-commit-tree.txt |    4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-commit-tree.txt b/Documentation/git-commit-tree.txt\nindex 6d5a04c..a221169 100644\n--- a/Documentation/git-commit-tree.txt\n+++ b/Documentation/git-commit-tree.txt\n@@ -72,13 +72,13 @@ if set:\n \tGIT_COMMITTER_NAME\n \tGIT_COMMITTER_EMAIL\n \tGIT_COMMITTER_DATE\n-\tEMAIL\n \n (nb \"<\", \">\" and \"\\n\"s are stripped)\n \n In case (some of) these environment variables are not set, the information\n is taken from the configuration items user.name and user.email, or, if not\n-present, system user name and the hostname used for outgoing mail (taken\n+present, the environment variable EMAIL, or, if that is not set,\n+system user name and the hostname used for outgoing mail (taken\n from `/etc/mailname` and falling back to the fully qualified hostname when\n that file does not exist).\n \n-- \n1.7.10.4\n"},{"id":"206463","messageId":"7vr4ls28h4.fsf@alter.siamese.dyndns.org","threadId":"32582","inReplyTo":"1357820998.10754.6.camel@vanquo.pezone.net","subject":"Re: [PATCH] git-commit-tree(1): correct description of defaults","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-10T18:33:59Z","receivedAt":"2013-01-10T18:33:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Peter Eisentraut <peter@eisentraut.org> writes:\n\n> The old phrasing indicated that the EMAIL environment variable takes\n> precedence over the user.email configuration setting, but it is the\n> other way around.\n>\n> Signed-off-by: Peter Eisentraut <peter@eisentraut.org>\n> ---\n\nIt could be argued that the observed behaviour is a bug, by the way.\n\nIf we followed the normal \"command line options trump environment\nvariables that in turn trump config variables that in turn trump\nwhatever the default values we compute using cues from the system\"\nprecedence order, EMAIL ought to come between the more specific\nGIT_{AUTHOR,COMMITTER}_EMAIL environment variables and the\nuser.email configuration variable.\n\nBut reading the value of EMAIL can also be seen as part of the\n\"using cues from the system\" (it often is set in equivalents of\n\"$HOME/.profile\" by equivalents of \"adduser\") step, and the original\nmotivation to add user.email indeed was to allow users to override\nEMAIL (or the name we grab from the system) without having to set\nthe GIT_COMMITTER_EMAIL environment variable.\n\nSo the current behaviour is correct, and the patch is a good\n(belated ;-) update to the documentation.\n\nWill apply.  Thanks.\n\n>  Documentation/git-commit-tree.txt |    4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-commit-tree.txt b/Documentation/git-commit-tree.txt\n> index 6d5a04c..a221169 100644\n> --- a/Documentation/git-commit-tree.txt\n> +++ b/Documentation/git-commit-tree.txt\n> @@ -72,13 +72,13 @@ if set:\n>  \tGIT_COMMITTER_NAME\n>  \tGIT_COMMITTER_EMAIL\n>  \tGIT_COMMITTER_DATE\n> -\tEMAIL\n>  \n>  (nb \"<\", \">\" and \"\\n\"s are stripped)\n>  \n>  In case (some of) these environment variables are not set, the information\n>  is taken from the configuration items user.name and user.email, or, if not\n> -present, system user name and the hostname used for outgoing mail (taken\n> +present, the environment variable EMAIL, or, if that is not set,\n> +system user name and the hostname used for outgoing mail (taken\n>  from `/etc/mailname` and falling back to the fully qualified hostname when\n>  that file does not exist).\n"}]}