{"thread":{"id":"32541","subject":"[PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named \"f*\"","startedAt":"2013-01-06T14:07:43Z","lastAt":"2013-01-06T20:00:51Z","messageCount":3,"participants":["Johannes Sixt","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"206135","messageId":"50E9852F.2060005@kdbg.org","threadId":"32541","inReplyTo":null,"subject":"[PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named \"f*\"","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2013-01-06T14:07:43Z","receivedAt":"2013-01-06T14:07:43Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Windows disallows file names that contain a star. Arrange the test setup\nto insert the file name \"f*\" in the repository without the corresponding\nfile in the worktree.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n t/t6130-pathspec-noglob.sh | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)\n\ndiff --git a/t/t6130-pathspec-noglob.sh b/t/t6130-pathspec-noglob.sh\nindex bb5e710..39ef619 100755\n--- a/t/t6130-pathspec-noglob.sh\n+++ b/t/t6130-pathspec-noglob.sh\n@@ -6,7 +6,13 @@ test_description='test globbing (and noglob) of pathspec limiting'\n test_expect_success 'create commits with glob characters' '\n \ttest_commit unrelated bar &&\n \ttest_commit vanilla foo &&\n-\ttest_commit star \"f*\" &&\n+\t# insert file \"f*\" in the commit, but in a way that avoids\n+\t# the name \"f*\" in the worktree, because it is not allowed\n+\t# on Windows (the tests below do not depend on the presence\n+\t# of the file in the worktree)\n+\tgit update-index --add --cacheinfo 100644 \"$(git rev-parse HEAD:foo)\" \"f*\" &&\n+\ttest_tick &&\n+\tgit commit -m star &&\n \ttest_commit bracket \"f[o][o]\"\n '\n \n-- \n1.8.1.1672.g5e2a3d4.dirty\n\n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n"},{"id":"206138","messageId":"20130106143319.GA10690@sigill.intra.peff.net","threadId":"32541","inReplyTo":"50E9852F.2060005@kdbg.org","subject":"Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named \"f*\"","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-01-06T14:33:20Z","receivedAt":"2013-01-06T14:33:20Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote:\n\n> Windows disallows file names that contain a star. Arrange the test setup\n> to insert the file name \"f*\" in the repository without the corresponding\n> file in the worktree.\n> [...]\n> -\ttest_commit star \"f*\" &&\n> +\t# insert file \"f*\" in the commit, but in a way that avoids\n> +\t# the name \"f*\" in the worktree, because it is not allowed\n> +\t# on Windows (the tests below do not depend on the presence\n> +\t# of the file in the worktree)\n> +\tgit update-index --add --cacheinfo 100644 \"$(git rev-parse HEAD:foo)\" \"f*\" &&\n> +\ttest_tick &&\n> +\tgit commit -m star &&\n\nThanks, looks obviously correct to me.\n\nSorry to break Windows again. It seems I learn about a new gotcha with\nevery patch series. :)\n\n-Peff\n"},{"id":"206167","messageId":"7vbod2nkss.fsf@alter.siamese.dyndns.org","threadId":"32541","inReplyTo":"20130106143319.GA10690@sigill.intra.peff.net","subject":"Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named \"f*\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-06T20:00:51Z","receivedAt":"2013-01-06T20:00:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote:\n>\n>> Windows disallows file names that contain a star. Arrange the test setup\n>> to insert the file name \"f*\" in the repository without the corresponding\n>> file in the worktree.\n>> [...]\n>> -\ttest_commit star \"f*\" &&\n>> +\t# insert file \"f*\" in the commit, but in a way that avoids\n>> +\t# the name \"f*\" in the worktree, because it is not allowed\n>> +\t# on Windows (the tests below do not depend on the presence\n>> +\t# of the file in the worktree)\n>> +\tgit update-index --add --cacheinfo 100644 \"$(git rev-parse HEAD:foo)\" \"f*\" &&\n>> +\ttest_tick &&\n>> +\tgit commit -m star &&\n>\n> Thanks, looks obviously correct to me.\n>\n> Sorry to break Windows again. It seems I learn about a new gotcha with\n> every patch series. :)\n\nThanks, both.\n\nIt appears that pushing things earlier to 'next' (and unfortunately\neven to 'master') rather than later seems to be the only way to help\ncatching little gotchas like this ;-).\n\n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n"}]}