{"thread":{"id":"32534","subject":"[PATCH] git-fast-import(1): remove duplicate \"--done\" option","startedAt":"2013-01-05T16:06:52Z","lastAt":"2013-01-08T19:39:34Z","messageCount":5,"participants":["John Keeping","Eric S. Raymond","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"206034","messageId":"20130105160652.GE6440@serenity.lan","threadId":"32534","inReplyTo":null,"subject":"[PATCH] git-fast-import(1): remove duplicate \"--done\" option","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-01-05T16:06:52Z","receivedAt":"2013-01-05T16:06:52Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"The \"--done\" option to git-fast-import is documented twice in its manual\npage. Combine the best bits of each description, keeping the location\nof the instance that was added first.\n\nSigned-off-by: John Keeping \n---\nI'm guessing that the reason the option was documented again (in commit\n3266de10) is because the options are not in an obvious order. There\ndoes seem to be some grouping of the options by type, but without\nsubheadings I wonder if it would make more sense to just put them all in\nalphabetical order?\n\n Documentation/git-fast-import.txt | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt\nindex 68bca1a..4ef5721 100644\n--- a/Documentation/git-fast-import.txt\n+++ b/Documentation/git-fast-import.txt\n@@ -39,10 +39,6 @@ OPTIONS\n \tSee ``Date Formats'' below for details about which formats\n \tare supported, and their syntax.\n \n--- done::\n-\tTerminate with error if there is no 'done' command at the\n-\tend of the stream.\n-\n --force::\n \tForce updating modified existing branches, even if doing\n \tso would cause commits to be lost (as the new commit does\n@@ -108,7 +104,8 @@ OPTIONS\n \toutput.\n \n --done::\n-\tRequire a `done` command at the end of the stream.\n+\tTerminate with error if there is no 'done' command at the\n+\tend of the stream.\n \tThis option might be useful for detecting errors that\n \tcause the frontend to terminate before it has started to\n \twrite a stream.\n-- \n1.8.0.2\n"},{"id":"206036","messageId":"20130105162619.GA15757@thyrsus.com","threadId":"32534","inReplyTo":"20130105160652.GE6440@serenity.lan","subject":"Re: [PATCH] git-fast-import(1): remove duplicate \"--done\" option","fromName":"Eric S. Raymond","fromEmail":"esr@thyrsus.com","sentAt":"2013-01-05T16:26:20Z","receivedAt":"2013-01-05T16:26:20Z","isPatch":true,"sender":{"key":"esr@thyrsus.com","avatar":"https://avatars.githubusercontent.com/u/727961?v=4"},"body":"John Keeping :\n> I'm guessing that the reason the option was documented again (in commit\n> 3266de10) is because the options are not in an obvious order. There\n> does seem to be some grouping of the options by type, but without\n> subheadings I wonder if it would make more sense to just put them all in\n> alphabetical order?\n\n+1\n\nThis duplication originated with me. I'll apologize with a \nreordering patch.\n-- \n\t\tEric S. Raymond\n"},{"id":"206072","messageId":"20130105231250.GE3247@elie.Belkin","threadId":"32534","inReplyTo":"20130105160652.GE6440@serenity.lan","subject":"Re: [PATCH] git-fast-import(1): remove duplicate \"--done\" option","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-01-05T23:12:50Z","receivedAt":"2013-01-05T23:12:50Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"John Keeping wrote:\n\n> The \"--done\" option to git-fast-import is documented twice in its manual\n> page. Combine the best bits of each description, keeping the location\n> of the instance that was added first.\n>\n> Signed-off-by: John Keeping \n\nGood catch, thanks.\n\nReviewed-by: Jonathan Nieder \n"},{"id":"206222","messageId":"20130107115709.GJ6440@serenity.lan","threadId":"32534","inReplyTo":"20130105160652.GE6440@serenity.lan","subject":"[PATCH v2] git-fast-import(1): remove duplicate '--done' option","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-01-07T11:57:09Z","receivedAt":"2013-01-07T11:57:09Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"On Sat, Jan 05, 2013 at 04:06:52PM +0000, John Keeping wrote:\nThe '--done' option to git-fast-import is documented twice in its manual\npage. Combine the best bits of each description, keeping the location\nof the instance that was added first.\n\nSigned-off-by: John Keeping \n---\nChanged since v1:\n 'done' => `done`\n\nI'll wait a bit longer for comments on [1] before I have another go at\nthe full re-organisation of this page.\n\n[1] http://article.gmane.org/gmane.comp.version-control.git/212805\n\n Documentation/git-fast-import.txt | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt\nindex 68bca1a..4ef5721 100644\n--- a/Documentation/git-fast-import.txt\n+++ b/Documentation/git-fast-import.txt\n@@ -39,10 +39,6 @@ OPTIONS\n \tSee ``Date Formats'' below for details about which formats\n \tare supported, and their syntax.\n \n--- done::\n-\tTerminate with error if there is no 'done' command at the\n-\tend of the stream.\n-\n --force::\n \tForce updating modified existing branches, even if doing\n \tso would cause commits to be lost (as the new commit does\n@@ -108,7 +104,8 @@ OPTIONS\n \toutput.\n \n --done::\n-\tRequire a `done` command at the end of the stream.\n+\tTerminate with error if there is no `done` command at the\n+\tend of the stream.\n \tThis option might be useful for detecting errors that\n \tcause the frontend to terminate before it has started to\n \twrite a stream.\n-- \n1.8.0.2\n"},{"id":"206327","messageId":"20130108193934.GP6440@serenity.lan","threadId":"32534","inReplyTo":"20130105160652.GE6440@serenity.lan","subject":"[PATCH v3] git-fast-import(1): remove duplicate '--done' option","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-01-08T19:39:34Z","receivedAt":"2013-01-08T19:39:34Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"The '--done' option to git-fast-import is documented twice in its manual\npage. Combine the best bits of each description, keeping the location\nof the instance that was added first.\n\nSigned-off-by: John Keeping \n---\nThe commit description gained some noise in v2; this version should be\nthe really correct, final version.\n\nSorry for the noise.\n\n Documentation/git-fast-import.txt | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt\nindex 68bca1a..4ef5721 100644\n--- a/Documentation/git-fast-import.txt\n+++ b/Documentation/git-fast-import.txt\n@@ -39,10 +39,6 @@ OPTIONS\n \tSee ``Date Formats'' below for details about which formats\n \tare supported, and their syntax.\n \n--- done::\n-\tTerminate with error if there is no 'done' command at the\n-\tend of the stream.\n-\n --force::\n \tForce updating modified existing branches, even if doing\n \tso would cause commits to be lost (as the new commit does\n@@ -108,7 +104,8 @@ OPTIONS\n \toutput.\n \n --done::\n-\tRequire a `done` command at the end of the stream.\n+\tTerminate with error if there is no `done` command at the\n+\tend of the stream.\n \tThis option might be useful for detecting errors that\n \tcause the frontend to terminate before it has started to\n \twrite a stream.\n-- \n1.8.0.2\n"}]}