{"thread":{"id":"32528","subject":"[PATCH] gitk: Display the date of a tag in a human friendly way.","startedAt":"2013-01-04T15:47:11Z","lastAt":"2013-04-01T07:25:43Z","messageCount":8,"participants":["Anand Kumria","Junio C Hamano","Jonathan Nieder","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"205991","messageId":"1357314431-32710-1-git-send-email-wildfire@progsoc.org","threadId":"32528","inReplyTo":null,"subject":"[PATCH] gitk: Display the date of a tag in a human friendly way.","fromName":"Anand Kumria","fromEmail":"wildfire@progsoc.org","sentAt":"2013-01-04T15:47:11Z","receivedAt":"2013-01-04T15:47:11Z","isPatch":true,"sender":{"key":"wildfire@progsoc.org","avatar":null},"body":"By selecting a tag within gitk you can display information about it.\nThis information is output by using the command\n\n 'git cat-file tag '\n\nThis outputs the *raw* information from the tag, amongst which is the\ntime - in seconds since the epoch. As useful as that value is, I find it\na lot easier to read and process time which it is something like:\n\n \"Mon Dec 31 14:26:11 2012 -0800\"\n\nThis change will modify the display of tags in gitk like so:\n\n @@ -1,7 +1,7 @@\n object 5d417842efeafb6e109db7574196901c4e95d273\n type commit\n tag v1.8.1\n -tagger Junio C Hamano 1356992771 -0800\n +tagger Junio C Hamano Mon Dec 31 14:26:11 2012 -0800\n\n Git 1.8.1\n -----BEGIN PGP SIGNATURE-----\n\nSigned-off-by: Anand Kumria \n---\n gitk-git/gitk | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex d93bd99..aae1c58 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -10675,7 +10675,7 @@ proc showtag {tag isnew} {\n set linknum 0\n if {![info exists cached_tagcontent($tag)]} {\n \tcatch {\n- set cached_tagcontent($tag) [exec git cat-file tag $tag]\n+ set cached_tagcontent($tag) [exec git cat-file -p $tag]\n \t}\n }\n if {[info exists cached_tagcontent($tag)]} {\n-- \n1.7.9.5\n"},{"id":"205993","messageId":"7vhamwse2c.fsf@alter.siamese.dyndns.org","threadId":"32528","inReplyTo":"1357314431-32710-1-git-send-email-wildfire@progsoc.org","subject":"Re: [PATCH] gitk: Display the date of a tag in a human friendly way.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-04T23:50:35Z","receivedAt":"2013-01-04T23:50:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Anand Kumria writes:\n\n> By selecting a tag within gitk you can display information about it.\n> This information is output by using the command\n>\n> 'git cat-file tag '\n>\n> This outputs the *raw* information from the tag, amongst which is the\n> time - in seconds since the epoch. As useful as that value is, I find it\n> a lot easier to read and process time which it is something like:\n>\n> \"Mon Dec 31 14:26:11 2012 -0800\"\n>\n> This change will modify the display of tags in gitk like so:\n>\n> @@ -1,7 +1,7 @@\n> object 5d417842efeafb6e109db7574196901c4e95d273\n> type commit\n> tag v1.8.1\n> -tagger Junio C Hamano 1356992771 -0800\n> +tagger Junio C Hamano Mon Dec 31 14:26:11 2012 -0800\n>\n> Git 1.8.1\n> -----BEGIN PGP SIGNATURE-----\n>\n> Signed-off-by: Anand Kumria \n> ---\n\nSounds like a sensible thing to do but I didn't check how else\n(other than purely for displaying) this string is used.\n\nPaul, the patch is not made against your tree, so if you choose to\ntake it you would need to strip the leading directory at the top.\n\nThanks.\n\nPS. I haven't received a pull request from you for a while; are\nthere accumulated changes I should be pulling in before -rc0 of the\nnext release we are working on?\n\n> gitk-git/gitk | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> index d93bd99..aae1c58 100755\n> --- a/gitk-git/gitk\n> +++ b/gitk-git/gitk\n> @@ -10675,7 +10675,7 @@ proc showtag {tag isnew} {\n> set linknum 0\n> if {![info exists cached_tagcontent($tag)]} {\n> \tcatch {\n> - set cached_tagcontent($tag) [exec git cat-file tag $tag]\n> + set cached_tagcontent($tag) [exec git cat-file -p $tag]\n> \t}\n> }\n> if {[info exists cached_tagcontent($tag)]} {\n"},{"id":"206025","messageId":"CAM1C4Gm_ea8DgrVhnp_MHmqaF6pyDe98EDA_BPkjvc8M5AO6FQ@mail.gmail.com","threadId":"32528","inReplyTo":"7vhamwse2c.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] gitk: Display the date of a tag in a human friendly way.","fromName":"Anand Kumria","fromEmail":"wildfire@progsoc.org","sentAt":"2013-01-05T14:05:00Z","receivedAt":"2013-01-05T14:05:00Z","isPatch":true,"sender":{"key":"wildfire@progsoc.org","avatar":null},"body":"Hi Junio,\n\nOn 4 January 2013 23:50, Junio C Hamano wrote:\n> Anand Kumria writes:\n>\n>> By selecting a tag within gitk you can display information about it.\n>> This information is output by using the command\n>>\n>> 'git cat-file tag '\n>>\n>> This outputs the *raw* information from the tag, amongst which is the\n>> time - in seconds since the epoch. As useful as that value is, I find it\n>> a lot easier to read and process time which it is something like:\n>>\n>> \"Mon Dec 31 14:26:11 2012 -0800\"\n>>\n>> This change will modify the display of tags in gitk like so:\n>>\n>> @@ -1,7 +1,7 @@\n>> object 5d417842efeafb6e109db7574196901c4e95d273\n>> type commit\n>> tag v1.8.1\n>> -tagger Junio C Hamano 1356992771 -0800\n>> +tagger Junio C Hamano Mon Dec 31 14:26:11 2012 -0800\n>>\n>> Git 1.8.1\n>> -----BEGIN PGP SIGNATURE-----\n>>\n>> Signed-off-by: Anand Kumria \n>> ---\n>\n> Sounds like a sensible thing to do but I didn't check how else\n> (other than purely for displaying) this string is used.\n\nAs far as I can tell it is only used for display (cached_tagcontent in\ngitk) purposes.\n\n> Paul, the patch is not made against your tree, so if you choose to\n> take it you would need to strip the leading directory at the top.\n\nSorry, I didn't know that gitk had been split back out (and\nDocumentation/gitk.txt still mentions it is part of the git suite).\n\nRegards,\nAnand\n"},{"id":"206039","messageId":"7v1udzqv1v.fsf@alter.siamese.dyndns.org","threadId":"32528","inReplyTo":"CAM1C4Gm_ea8DgrVhnp_MHmqaF6pyDe98EDA_BPkjvc8M5AO6FQ@mail.gmail.com","subject":"Re: [PATCH] gitk: Display the date of a tag in a human friendly way.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-05T19:38:52Z","receivedAt":"2013-01-05T19:38:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Anand Kumria writes:\n\n> Sorry, I didn't know that gitk had been split back out (and\n> Documentation/gitk.txt still mentions it is part of the git suite).\n\nIt is not \"split back\" at all, and it won't be. From \"git\" user's\npoint of view it is part of the suite.\n\nGitk however is still a viable freestanding project, so it would be\nselfish for me to take a patch to gitk-git/gitk directly to my tree,\nas the patch will not be able to flow back to the standalone gitk\nproject. Hence we always let patches go through Paul's tree and then\nI pull from him.\n"},{"id":"208554","messageId":"CAM1C4G=mKzfgrfO-n_yXjyDkZ9vA7H6kQEY5Yja-5C-YRRLmyw@mail.gmail.com","threadId":"32528","inReplyTo":"7v1udzqv1v.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] gitk: Display the date of a tag in a human friendly way.","fromName":"Anand Kumria","fromEmail":"wildfire@progsoc.org","sentAt":"2013-02-03T18:37:42Z","receivedAt":"2013-02-03T18:37:42Z","isPatch":true,"sender":{"key":"wildfire@progsoc.org","avatar":null},"body":"Hi Pau,\n\nI've not been able to find the canonical location of your gitk repository.\n\nI've tried kernel.org, samba.org and ozlabs.org; none of them to have\nit - nor does any amount of google searching I do reveal the location.\n\nI realise you've probably had a busy month with linux.conf.au but it\nwould be nice to have some feedback.\n\nCould you let me know where gitk is hosted and I'll re-roll this patch\nagainst that (and update the docs so others don't need to go hunting).\n\nThanks,\nAnand\n\nOn 5 January 2013 19:38, Junio C Hamano wrote:\n> Anand Kumria writes:\n>\n>> Sorry, I didn't know that gitk had been split back out (and\n>> Documentation/gitk.txt still mentions it is part of the git suite).\n>\n> It is not \"split back\" at all, and it won't be. From \"git\" user's\n> point of view it is part of the suite.\n>\n> Gitk however is still a viable freestanding project, so it would be\n> selfish for me to take a patch to gitk-git/gitk directly to my tree,\n> as the patch will not be able to flow back to the standalone gitk\n> project. Hence we always let patches go through Paul's tree and then\n> I pull from him.\n>\n>\n"},{"id":"208562","messageId":"20130203201217.GB3221@elie.Belkin","threadId":"32528","inReplyTo":"CAM1C4G=mKzfgrfO-n_yXjyDkZ9vA7H6kQEY5Yja-5C-YRRLmyw@mail.gmail.com","subject":"Re: [PATCH] gitk: Display the date of a tag in a human friendly way.","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-02-03T20:12:17Z","receivedAt":"2013-02-03T20:12:17Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi Anand,\n\nAnand Kumria wrote:\n\n> I've not been able to find the canonical location of your gitk repository.\n\nHere's how I find it:\n\n\t$ git clone git://repo.or.cz/git.git\n[...]\n\t$ cd git\n\t$ git log -1 --oneline -- gitk-git\n\tec3ae6ec Merge git://ozlabs.org/~paulus/gitk\n\t$ cd ..\n\t$ git clone git://ozlabs.org/~paulus/gitk.git\n\nPatches, including documentation patches, go to git@vger.kernel.org,\ncc-ing Paul Mackerras.\n\nHope that helps,\nJonathan\n"},{"id":"208563","messageId":"7vlib587u9.fsf@alter.siamese.dyndns.org","threadId":"32528","inReplyTo":"20130203201217.GB3221@elie.Belkin","subject":"Re: [PATCH] gitk: Display the date of a tag in a human friendly way.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-02-03T20:23:42Z","receivedAt":"2013-02-03T20:23:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder writes:\n\n> Anand Kumria wrote:\n>\n>> I've not been able to find the canonical location of your gitk repository.\n>\n> Here's how I find it:\n>\n> \t$ git clone git://repo.or.cz/git.git\n> [...]\n> \t$ cd git\n> \t$ git log -1 --oneline -- gitk-git\n> \tec3ae6ec Merge git://ozlabs.org/~paulus/gitk\n> \t$ cd ..\n> \t$ git clone git://ozlabs.org/~paulus/gitk.git\n>\n> Patches, including documentation patches, go to git@vger.kernel.org,\n> cc-ing Paul Mackerras.\n\nOr look at \"A note from the maintainer\" posted here every few\nmonths.\n\n\t\n"},{"id":"212787","messageId":"20130401072542.GC4427@iris.ozlabs.ibm.com","threadId":"32528","inReplyTo":"CAM1C4G=mKzfgrfO-n_yXjyDkZ9vA7H6kQEY5Yja-5C-YRRLmyw@mail.gmail.com","subject":"Re: [PATCH] gitk: Display the date of a tag in a human friendly way.","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2013-04-01T07:25:43Z","receivedAt":"2013-04-01T07:25:43Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Sun, Feb 03, 2013 at 06:37:42PM +0000, Anand Kumria wrote:\n> Hi Pau,\n> \n> I've not been able to find the canonical location of your gitk repository.\n> \n> I've tried kernel.org, samba.org and ozlabs.org; none of them to have\n> it - nor does any amount of google searching I do reveal the location.\n> \n> I realise you've probably had a busy month with linux.conf.au but it\n> would be nice to have some feedback.\n> \n> Could you let me know where gitk is hosted and I'll re-roll this patch\n> against that (and update the docs so others don't need to go hunting).\n\nIt's at git://ozlabs.org/~paulus/gitk.git\n\nPaul.\n"}]}