{"thread":{"id":"32499","subject":"[PATCH] Avoid using non-POSIX cp options","startedAt":"2013-01-01T20:13:17Z","lastAt":"2013-01-01T21:57:38Z","messageCount":2,"participants":["Ben Walton","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"205783","messageId":"1357071197-7927-1-git-send-email-bdwalton@gmail.com","threadId":"32499","inReplyTo":null,"subject":"[PATCH] Avoid using non-POSIX cp options","fromName":"Ben Walton","fromEmail":"bdwalton@gmail.com","sentAt":"2013-01-01T20:13:17Z","receivedAt":"2013-01-01T20:13:17Z","isPatch":true,"sender":{"key":"bdwalton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/396061?v=4"},"body":"t/3600-rm was using the -a option to cp.  This option is a GNU extention\nand is not portable.  Instead, use just -R (no -p necessary).\n\nSigned-off-by: Ben Walton <bdwalton@gmail.com>\n---\n t/t3600-rm.sh |    6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t3600-rm.sh b/t/t3600-rm.sh\nindex 06f6384..37bf5f1 100755\n--- a/t/t3600-rm.sh\n+++ b/t/t3600-rm.sh\n@@ -474,7 +474,7 @@ test_expect_success 'rm of a conflicted populated submodule with a .git director\n \tgit submodule update &&\n \t(cd submod &&\n \t\trm .git &&\n-\t\tcp -a ../.git/modules/sub .git &&\n+\t\tcp -R ../.git/modules/sub .git &&\n \t\tGIT_WORK_TREE=. git config --unset core.worktree\n \t) &&\n \ttest_must_fail git merge conflict2 &&\n@@ -508,7 +508,7 @@ test_expect_success 'rm of a populated submodule with a .git directory fails eve\n \tgit submodule update &&\n \t(cd submod &&\n \t\trm .git &&\n-\t\tcp -a ../.git/modules/sub .git &&\n+\t\tcp -R ../.git/modules/sub .git &&\n \t\tGIT_WORK_TREE=. git config --unset core.worktree\n \t) &&\n \ttest_must_fail git rm submod &&\n@@ -606,7 +606,7 @@ test_expect_success 'rm of a populated nested submodule with a nested .git direc\n \tgit submodule update --recursive &&\n \t(cd submod/subsubmod &&\n \t\trm .git &&\n-\t\tcp -a ../../.git/modules/sub/modules/sub .git &&\n+\t\tcp -R ../../.git/modules/sub/modules/sub .git &&\n \t\tGIT_WORK_TREE=. git config --unset core.worktree\n \t) &&\n \ttest_must_fail git rm submod &&\n-- \n1.7.10.4\n"},{"id":"205797","messageId":"7vbod88t2l.fsf@alter.siamese.dyndns.org","threadId":"32499","inReplyTo":"1357071197-7927-1-git-send-email-bdwalton@gmail.com","subject":"Re: [PATCH] Avoid using non-POSIX cp options","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-01T21:57:38Z","receivedAt":"2013-01-01T21:57:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; I think I already have 2d3ac9a (t3600: Avoid \"cp -a\", which\nis a GNUism, 2012-12-18)\n"}]}