{"thread":{"id":"32487","subject":"[PATCH v2 0/2] Add MAINTAINERS file and clarify gui workflows","startedAt":"2012-12-31T22:19:33Z","lastAt":"2012-12-31T23:39:16Z","messageCount":5,"participants":["Jason Holden","Jacob Helwig","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":2},"messages":[{"id":"205704","messageId":"1356992375-11116-1-git-send-email-jason.k.holden.swdev@gmail.com","threadId":"32487","inReplyTo":null,"subject":"[PATCH v2 0/2] Add MAINTAINERS file and clarify gui workflows","fromName":"Jason Holden","fromEmail":"jason.k.holden.swdev@gmail.com","sentAt":"2012-12-31T22:19:33Z","receivedAt":"2012-12-31T22:19:33Z","isPatch":true,"sender":{"key":"jason.k.holden.swdev@gmail.com","avatar":null},"body":"Changes since the initial version:\n-Added git-po to the MAINTAINERS file and generalized wording that had been\n gui-specific\n-Fixup some trailing whitespace warnings\n\nJason Holden (2):\n Add top-level maintainers file with email/canonical repository\n information\n Provide better guidance for submitting patches against upstream\n utilities\n\n Documentation/SubmittingPatches | 11 +++++++++++\n MAINTAINERS | 21 +++++++++++++++++++++\n 2 files changed, 32 insertions(+)\n create mode 100644 MAINTAINERS\n\n-- \n1.8.1.rc3.28.g0ab5d1f\n"},{"id":"205705","messageId":"1356992375-11116-2-git-send-email-jason.k.holden.swdev@gmail.com","threadId":"32487","inReplyTo":"1356992375-11116-1-git-send-email-jason.k.holden.swdev@gmail.com","subject":"[PATCH v2 1/2] Add top-level maintainers file with email/canonical repository information","fromName":"Jason Holden","fromEmail":"jason.k.holden.swdev@gmail.com","sentAt":"2012-12-31T22:19:34Z","receivedAt":"2012-12-31T22:19:34Z","isPatch":true,"sender":{"key":"jason.k.holden.swdev@gmail.com","avatar":null},"body":"Certain parts of git have a semi-formalized workflow for\nincoming patches. This file documents the maintainers, their area of\nspecialization, their email address, and their canonical repository against\nwhich patches should be submitted.\n\nSigned-off-by: Jason Holden \n---\n MAINTAINERS | 21 +++++++++++++++++++++\n 1 file changed, 21 insertions(+)\n create mode 100644 MAINTAINERS\n\ndiff --git a/MAINTAINERS b/MAINTAINERS\nnew file mode 100644\nindex 0000000..c3a96b4\n--- /dev/null\n+++ b/MAINTAINERS\n@@ -0,0 +1,21 @@\n+Core Git/Overall Maintainer:\n+ Junio C Hamano \n+ git://git.kernel.org/pub/scm/git/git.git\n+\n+\n+Certain utilities packaged with git (git-gui, gitk, and git-po) are maintained\n+upstream of the core git repository. Their contact information\n+and canonical repositories are below. Patches to improve these utilities\n+should be made against the tree's referenced below\n+\n+gitk:\n+ Paul Mackerras \n+ git://ozlabs.org/~paulus/gitk\n+\n+git-gui:\n+ Pat Thoyts \n+ git://repo.or.cz/git-gui\n+\n+git-po:\n+ Jiang Xin \n+ https://github.com/git-l10n/git-po/\n-- \n1.8.1.rc3.28.g0ab5d1f\n"},{"id":"205706","messageId":"1356992375-11116-3-git-send-email-jason.k.holden.swdev@gmail.com","threadId":"32487","inReplyTo":"1356992375-11116-1-git-send-email-jason.k.holden.swdev@gmail.com","subject":"[PATCH v2 2/2] Provide better guidance for submitting patches against upstream utilities","fromName":"Jason Holden","fromEmail":"jason.k.holden.swdev@gmail.com","sentAt":"2012-12-31T22:19:35Z","receivedAt":"2012-12-31T22:19:35Z","isPatch":true,"sender":{"key":"jason.k.holden.swdev@gmail.com","avatar":null},"body":"git-gui, gitk, and git-po are maintained upstream of git.\nDocument this, and the procedure for submitting patches to these tools\n\nSigned-off-by: Jason Holden \n---\n Documentation/SubmittingPatches | 11 +++++++++++\n 1 file changed, 11 insertions(+)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex 75935d5..30b95a8 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -58,6 +58,17 @@ Checklist (and a short version for the impatient):\n \t please test it first by sending email to yourself.\n \t- see below for instructions specific to your mailer\n \n+\tImproving upstream utilities (gitk, git-gui, git-po)\n+\t- gitk, git-gui, and git-po are maintained upstream of Git\n+\t despite being included in Git's git repository\n+\t- Patches should be made against the upstream gui repository,\n+\t and not against the version in Git's git repository\n+\t- The resulting patch should still be emailed for review\n+\t to the git mailing list (git@vger.kernel.org), cc'ing the\n+\t applicable gui maintainer\n+\t- Please see the MAINTAINER's file for the gui maintainer's contact\n+\t information and canonical repository location\n+\n Long version:\n \n I started reading over the SubmittingPatches document for Linux\n-- \n1.8.1.rc3.28.g0ab5d1f\n"},{"id":"205707","messageId":"CAJ8aY1ETvqgBOwM+r=5nh4RyRjmPp7ur_TRVg-hqaL9DVmWR4A@mail.gmail.com","threadId":"32487","inReplyTo":"1356992375-11116-2-git-send-email-jason.k.holden.swdev@gmail.com","subject":"Re: [PATCH v2 1/2] Add top-level maintainers file with email/canonical repository information","fromName":"Jacob Helwig","fromEmail":"jacob@technosorcery.net","sentAt":"2012-12-31T22:25:47Z","receivedAt":"2012-12-31T22:25:47Z","isPatch":true,"sender":{"key":"jacob@technosorcery.net","avatar":"https://gravatar.com/avatar/6116efbbb00b1c0268cd76ce802f2caefdd52245a729e5ad3cf09fd3cf778002?d=mp&s=160"},"body":"One minor grammar nit below.\n\nOn Mon, Dec 31, 2012 at 2:19 PM, Jason Holden\n wrote:\n> Certain parts of git have a semi-formalized workflow for\n> incoming patches. This file documents the maintainers, their area of\n> specialization, their email address, and their canonical repository against\n> which patches should be submitted.\n>\n> Signed-off-by: Jason Holden \n> ---\n> MAINTAINERS | 21 +++++++++++++++++++++\n> 1 file changed, 21 insertions(+)\n> create mode 100644 MAINTAINERS\n>\n> diff --git a/MAINTAINERS b/MAINTAINERS\n> new file mode 100644\n> index 0000000..c3a96b4\n> --- /dev/null\n> +++ b/MAINTAINERS\n> @@ -0,0 +1,21 @@\n> +Core Git/Overall Maintainer:\n> + Junio C Hamano \n> + git://git.kernel.org/pub/scm/git/git.git\n> +\n> +\n> +Certain utilities packaged with git (git-gui, gitk, and git-po) are maintained\n> +upstream of the core git repository. Their contact information\n> +and canonical repositories are below. Patches to improve these utilities\n> +should be made against the tree's referenced below\n\nShould be \"trees\", not \"tree's\" (plural vs. possessive/contraction).\n\n> +\n> +gitk:\n> + Paul Mackerras \n> + git://ozlabs.org/~paulus/gitk\n> +\n> +git-gui:\n> + Pat Thoyts \n> + git://repo.or.cz/git-gui\n> +\n> +git-po:\n> + Jiang Xin \n> + https://github.com/git-l10n/git-po/\n> --\n> 1.8.1.rc3.28.g0ab5d1f\n>\n\n-- \nJacob Helwig\nhttp://technosorcery.net/about/me\n"},{"id":"205712","messageId":"7vzk0tdc63.fsf@alter.siamese.dyndns.org","threadId":"32487","inReplyTo":"1356992375-11116-3-git-send-email-jason.k.holden.swdev@gmail.com","subject":"Re: [PATCH v2 2/2] Provide better guidance for submitting patches against upstream utilities","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-12-31T23:39:16Z","receivedAt":"2012-12-31T23:39:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jason Holden writes:\n\n> git-gui, gitk, and git-po are maintained upstream of git.\n> Document this, and the procedure for submitting patches to these tools\n>\n> Signed-off-by: Jason Holden \n> ---\n> Documentation/SubmittingPatches | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\n> index 75935d5..30b95a8 100644\n> --- a/Documentation/SubmittingPatches\n> +++ b/Documentation/SubmittingPatches\n> @@ -58,6 +58,17 @@ Checklist (and a short version for the impatient):\n> \t please test it first by sending email to yourself.\n> \t- see below for instructions specific to your mailer\n> \n> +\tImproving upstream utilities (gitk, git-gui, git-po)\n> +\t- gitk, git-gui, and git-po are maintained upstream of Git\n> +\t despite being included in Git's git repository\n> +\t- Patches should be made against the upstream gui repository,\n\nGUI?\n\n> +\t and not against the version in Git's git repository\n> +\t- The resulting patch should still be emailed for review\n> +\t to the git mailing list (git@vger.kernel.org), cc'ing the\n> +\t applicable gui maintainer\n> +\t- Please see the MAINTAINER's file for the gui maintainer's contact\n\nGUI?\n\nPerhaps \"parts with sub-maintainers' with their own repositories\".\n\nIn any case, I think it is probably much better not to add a new\nfile at the top of the tree only to hold twenty-or-so\nlines. Instead, add the contents as a footnote to this file and\nrefer to it from here.\n"}]}