{"thread":{"id":"32465","subject":"[PATCH] gitk: Replaced \"green\" with \"#00FF00\".","startedAt":"2012-12-27T12:59:16Z","lastAt":"2012-12-31T23:21:59Z","messageCount":3,"participants":["Peter Hofmann","Junio C Hamano","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"205551","messageId":"20121227125916.GC7039@mobiltux","threadId":"32465","inReplyTo":null,"subject":"[PATCH] gitk: Replaced \"green\" with \"#00FF00\".","fromName":"Peter Hofmann","fromEmail":"git-dev@uninformativ.de","sentAt":"2012-12-27T12:59:16Z","receivedAt":"2012-12-27T12:59:16Z","isPatch":true,"sender":{"key":"git-dev@uninformativ.de","avatar":null},"body":"The definition of \"green\" has changed in Tk 8.6:\n\n- http://wiki.tcl.tk/21276\n- http://www.tcl.tk/cgi-bin/tct/tip/403\n\ngitk looks pretty awkward with Tk 8.6. \"green\" is simply too dark now\nbecause it has changed from \"#00FF00\" to \"#008000\".\n\nOne could also use \"lime\" instead of \"#00FF00\" but that would break\ncompatibility with older versions of Tk.\n\nSigned-off-by: Peter Hofmann \n---\n gitk-git/gitk | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex d93bd99..d7e922b 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -2209,7 +2209,7 @@ proc makewindow {} {\n \tset h [expr {[font metrics uifont -linespace] + 2}]\n \tset progresscanv .tf.bar.progress\n \tcanvas $progresscanv -relief sunken -height $h -borderwidth 2\n-\tset progressitem [$progresscanv create rect -1 0 0 $h -fill green]\n+\tset progressitem [$progresscanv create rect -1 0 0 $h -fill \"#00FF00\"]\n \tset fprogitem [$progresscanv create rect -1 0 0 $h -fill yellow]\n \tset rprogitem [$progresscanv create rect -1 0 0 $h -fill red]\n }\n@@ -2342,7 +2342,7 @@ proc makewindow {} {\n $ctext tag conf dresult -fore [lindex $diffcolors 1]\n $ctext tag conf m0 -fore red\n $ctext tag conf m1 -fore blue\n- $ctext tag conf m2 -fore green\n+ $ctext tag conf m2 -fore \"#00FF00\"\n $ctext tag conf m3 -fore purple\n $ctext tag conf m4 -fore brown\n $ctext tag conf m5 -fore \"#009090\"\n@@ -3226,7 +3226,7 @@ set rectmask {\n 0x00, 0x00, 0xfc, 0x0f, 0xfc, 0x0f, 0xfc, 0x0f,\n 0xfc, 0x0f, 0xfc, 0x0f, 0xfc, 0x0f, 0xfc, 0x0f, 0x00, 0x00};\n }\n-image create bitmap reficon-H -background black -foreground green \\\n+image create bitmap reficon-H -background black -foreground \"#00FF00\" \\\n -data $rectdata -maskdata $rectmask\n image create bitmap reficon-o -background black -foreground \"#ddddff\" \\\n -data $rectdata -maskdata $rectmask\n@@ -5909,7 +5909,7 @@ proc drawcmittext {id row col} {\n if {$id eq $nullid} {\n \tset ofill red\n } elseif {$id eq $nullid2} {\n-\tset ofill green\n+\tset ofill \"#00FF00\"\n } elseif {$id eq $mainheadid} {\n \tset ofill yellow\n } else {\n@@ -6377,7 +6377,7 @@ proc drawtags {id x xt y1} {\n \t} else {\n \t # draw a head or other ref\n \t if {[incr nheads -1] >= 0} {\n-\t\tset col green\n+\t\tset col \"#00FF00\"\n \t\tif {$tag eq $mainhead} {\n \t\t set font mainfontbold\n \t\t}\n@@ -11617,7 +11617,7 @@ if {[tk windowingsystem] eq \"aqua\"} {\n set extdifftool \"meld\"\n }\n \n-set colors {green red blue magenta darkgrey brown orange}\n+set colors {\"#00FF00\" red blue magenta darkgrey brown orange}\n if {[tk windowingsystem] eq \"win32\"} {\n set uicolor SystemButtonFace\n set bgcolor SystemWindow\n-- \n1.8.0.2\n"},{"id":"205556","messageId":"7v623nmmly.fsf@alter.siamese.dyndns.org","threadId":"32465","inReplyTo":"20121227125916.GC7039@mobiltux","subject":"Re: [PATCH] gitk: Replaced \"green\" with \"#00FF00\".","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-12-27T17:27:37Z","receivedAt":"2012-12-27T17:27:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Peter Hofmann writes:\n\n> Subject: Re: [PATCH] gitk: Replaced \"green\" with \"#00FF00\".\n\nThat should be\n\n\tSubject: [PATCH] gitk: replace \"green\" with \"#00FF00\"\n\naround here. Instead of reporting what you did in the past tense,\nyou give an order to somebody to do something to make the codebase\ninto more desirable shape, without the final full-stop.\n\n> The definition of \"green\" has changed in Tk 8.6:\n>\n> - http://wiki.tcl.tk/21276\n> - http://www.tcl.tk/cgi-bin/tct/tip/403\n\nConcise reference to the background information is very much\nappreciated. It would have been even nicer if you wrote one line\nsummary of it, e.g. \"This change was to make Tk applications more in\nline with Web standard colors.\"\n\n> gitk looks pretty awkward with Tk 8.6. \"green\" is simply too dark now\n> because it has changed from \"#00FF00\" to \"#008000\".\n\nYour observation \"awkward\" is somewhat subjective and I am hesitant\nto recommend this change without a better justification. Given the\nreasoning behind the change Tcl/Tk people made, I wouldn't be\nsurprised if people coming from webapp world view the \"green\" color\nrendered by updated Tcl/Tk more natural.\n\nBesides, if we are declaring with this patch that we will stick to\nX11 colors and will not adopt W3C colors, the patch shouldn't update\nonly \"green\", but set all the other colors in stone, no? \"purple\",\nfor example, is also different between X11 and W3C.\n\n> One could also use \"lime\" instead of \"#00FF00\" but that would break\n> compatibility with older versions of Tk.\n\nA better solution might be to make these colors customizable.\n\n> Signed-off-by: Peter Hofmann \n> ---\n> gitk-git/gitk | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n\nPlease make gitk patches against \n\n\turl = git://ozlabs.org/~paulus/gitk.git\n\nwhich is my upstream maintained by Paul Mackerras \n(cc'ed) and keep him in the loop.\n\nA patch against Paul's tree would have these lines\n\n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> index d93bd99..d7e922b 100755\n> --- a/gitk-git/gitk\n> +++ b/gitk-git/gitk\n\nwithout \"/gitk-git\".\n\nThanks.\n"},{"id":"205711","messageId":"20121231232159.GA20724@iris.ozlabs.ibm.com","threadId":"32465","inReplyTo":"7v623nmmly.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] gitk: Replaced \"green\" with \"#00FF00\".","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2012-12-31T23:21:59Z","receivedAt":"2012-12-31T23:21:59Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Thu, Dec 27, 2012 at 09:27:37AM -0800, Junio C Hamano wrote:\n> Peter Hofmann writes:\n> \n> > Subject: Re: [PATCH] gitk: Replaced \"green\" with \"#00FF00\".\n> \n> > gitk looks pretty awkward with Tk 8.6. \"green\" is simply too dark now\n> > because it has changed from \"#00FF00\" to \"#008000\".\n> \n> Your observation \"awkward\" is somewhat subjective and I am hesitant\n> to recommend this change without a better justification. Given the\n> reasoning behind the change Tcl/Tk people made, I wouldn't be\n> surprised if people coming from webapp world view the \"green\" color\n> rendered by updated Tcl/Tk more natural.\n\nGiven that \"green\" is used as the background color in some places,\ne.g. for the boxes containing the names of heads, and that the general\nscheme is dark foreground on light background, I agree that #008000 is\ntoo dark in those places.\n\n> Besides, if we are declaring with this patch that we will stick to\n> X11 colors and will not adopt W3C colors, the patch shouldn't update\n> only \"green\", but set all the other colors in stone, no? \"purple\",\n> for example, is also different between X11 and W3C.\n\nPurple is only used for octopus merges. I'd like to think of a better\nway to use color in representing octopus merges if possible.\n\n> > One could also use \"lime\" instead of \"#00FF00\" but that would break\n> > compatibility with older versions of Tk.\n> \n> A better solution might be to make these colors customizable.\n\nIndeed. Some people prefer to have all their windows to have light\nforegrounds on dark backgrounds, so they would also benefit from\nhaving more of the colors customizable.\n\nPaul.\n"}]}