{"thread":{"id":"32446","subject":"[PATCH] Sort howto documents in howto-index.txt","startedAt":"2012-12-22T18:34:27Z","lastAt":"2012-12-22T19:54:17Z","messageCount":3,"participants":["Thomas Ackermann","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"205426","messageId":"1870890640.302608.1356201267202.JavaMail.ngmail@webmail13.arcor-online.net","threadId":"32446","inReplyTo":null,"subject":"[PATCH] Sort howto documents in howto-index.txt","fromName":"Thomas Ackermann","fromEmail":"th.acker@arcor.de","sentAt":"2012-12-22T18:34:27Z","receivedAt":"2012-12-22T18:34:27Z","isPatch":true,"sender":{"key":"th.acker@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1358536?v=4"},"body":"\nHowto documents in howto-index.txt were listed in a rather\nrandom order. So better sort them.\n\nSigned-off-by: Thomas Ackermann <th.acker@arcor.de>\n---\n Documentation/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex d7417b8..ff8ad9a 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -348,7 +348,7 @@ $(patsubst %.txt,%.texi,$(MAN_TXT)): %.texi : %.xml\n \n howto-index.txt: howto-index.sh $(wildcard howto/*.txt)\n \t$(QUIET_GEN)$(RM) $@+ $@ && \\\n-\t'$(SHELL_PATH_SQ)' ./howto-index.sh $(wildcard howto/*.txt) >$@+ && \\\n+\t'$(SHELL_PATH_SQ)' ./howto-index.sh $(sort $(wildcard howto/*.txt)) >$@+ && \\\n \tmv $@+ $@\n \n $(patsubst %,%.html,$(ARTICLES)) : %.html : %.txt\n-- \n1.8.0.msysgit.0\n\n\n\n---\nThomas\n"},{"id":"205431","messageId":"7v8v8pri3w.fsf@alter.siamese.dyndns.org","threadId":"32446","inReplyTo":"1870890640.302608.1356201267202.JavaMail.ngmail@webmail13.arcor-online.net","subject":"Re: [PATCH] Sort howto documents in howto-index.txt","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-12-22T19:40:03Z","receivedAt":"2012-12-22T19:40:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Ackermann <th.acker@arcor.de> writes:\n\n> Howto documents in howto-index.txt were listed in a rather\n> random order. So better sort them.\n>\n> Signed-off-by: Thomas Ackermann <th.acker@arcor.de>\n> ---\n\nI think $(wildcard) used to sort but in recent GNU make it no longer\ndoes, so this is probably a good change.\n\nDo we need to explicitly sort the api-index as well?  $(API_DOCS) is\nfed to the script that reads filenames one at a time in the given\norder, but I do not see anybody asking for a sorted list while\nproducing that list.  The result looks to be sorted in my build\nfarm with GNU make 3.82, but that could be by accident.\n\n>  Documentation/Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index d7417b8..ff8ad9a 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> @@ -348,7 +348,7 @@ $(patsubst %.txt,%.texi,$(MAN_TXT)): %.texi : %.xml\n>  \n>  howto-index.txt: howto-index.sh $(wildcard howto/*.txt)\n>  \t$(QUIET_GEN)$(RM) $@+ $@ && \\\n> -\t'$(SHELL_PATH_SQ)' ./howto-index.sh $(wildcard howto/*.txt) >$@+ && \\\n> +\t'$(SHELL_PATH_SQ)' ./howto-index.sh $(sort $(wildcard howto/*.txt)) >$@+ && \\\n>  \tmv $@+ $@\n>  \n>  $(patsubst %,%.html,$(ARTICLES)) : %.html : %.txt\n"},{"id":"205432","messageId":"1937031575.96914.1356206057592.JavaMail.ngmail@webmail06.arcor-online.net","threadId":"32446","inReplyTo":"7v8v8pri3w.fsf@alter.siamese.dyndns.org","subject":"Aw: Re: [PATCH] Sort howto documents in howto-index.txt","fromName":"Thomas Ackermann","fromEmail":"th.acker@arcor.de","sentAt":"2012-12-22T19:54:17Z","receivedAt":"2012-12-22T19:54:17Z","isPatch":true,"sender":{"key":"th.acker@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1358536?v=4"},"body":"\n> \n> I think $(wildcard) used to sort but in recent GNU make it no longer\n> does, so this is probably a good change.\n> \n> Do we need to explicitly sort the api-index as well?  $(API_DOCS) is\n> fed to the script that reads filenames one at a time in the given\n> order, but I do not see anybody asking for a sorted list while\n> producing that list.  The result looks to be sorted in my build\n> farm with GNU make 3.82, but that could be by accident.\n> \n\n$(API_DOCS) is not fed to api-index.sh; it's only in the dependencies.\napi-index.sh uses \"ls api-*.txt\" internally which produces a correct sorting.\n\nUnifying api-index.sh and howto-index.sh is on my todo list ...\n\n\n---\nThomas\n"}]}