{"thread":{"id":"32433","subject":"Re: [PATCH] http.c: Avoid username prompt for certifcate credentials","startedAt":"2012-12-21T16:31:19Z","lastAt":"2012-12-21T18:19:55Z","messageCount":3,"participants":["Jeff King","Rene Bredlau","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"205353","messageId":"1356107479-6668-1-git-send-email-git@unrelated.de","threadId":"32433","inReplyTo":null,"subject":"[PATCH] http.c: Avoid username prompt for certifcate credentials","fromName":"Rene Bredlau","fromEmail":"git@unrelated.de","sentAt":"2012-12-21T16:31:19Z","receivedAt":"2012-12-21T16:31:19Z","isPatch":true,"sender":{"key":"git@unrelated.de","avatar":null},"body":"If sslCertPasswordProtected is set to true do not ask for username to decrypt rsa key. This question is pointless, the key is only protected by a password. Internaly the username is simply set to \"\".\n\nSigned-off-by: Rene Bredlau <git@unrelated.de>\n---\n http.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/http.c b/http.c\nindex 0a8abf3..44f3525 100644\n--- a/http.c\n+++ b/http.c\n@@ -236,6 +236,7 @@ static int has_cert_password(void)\n \t\treturn 0;\n \tif (!cert_auth.password) {\n \t\tcert_auth.protocol = xstrdup(\"cert\");\n+\t\tcert_auth.username = xstrdup(\"\");\n \t\tcert_auth.path = xstrdup(ssl_cert);\n \t\tcredential_fill(&cert_auth);\n \t}\n-- \n1.7.9\n"},{"id":"205349","messageId":"20121221170927.GA23574@sigill.intra.peff.net","threadId":"32433","inReplyTo":"1356107479-6668-1-git-send-email-git@unrelated.de","subject":"Re: [PATCH] http.c: Avoid username prompt for certifcate credentials","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-12-21T17:09:27Z","receivedAt":"2012-12-21T17:09:27Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Dec 21, 2012 at 05:31:19PM +0100, Rene Bredlau wrote:\n\n> If sslCertPasswordProtected is set to true do not ask for username to\n> decrypt rsa key. This question is pointless, the key is only protected\n> by a password. Internaly the username is simply set to \"\".\n\nYeah, that makes sense. I suspect the cert-unlocking code paths for\ncredential helpers are not that well used (and I do not think we have\nany test coverage for them at all), so I am not too surprised that this\nwent unreported for a long time.\n\nThanks.\n\n> Signed-off-by: Rene Bredlau <git@unrelated.de>\n\nAcked-by: Jeff King <peff@peff.net>\n\n-Peff\n"},{"id":"205360","messageId":"7vehij1d4k.fsf@alter.siamese.dyndns.org","threadId":"32433","inReplyTo":"20121221170927.GA23574@sigill.intra.peff.net","subject":"Re: [PATCH] http.c: Avoid username prompt for certifcate credentials","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-12-21T18:19:55Z","receivedAt":"2012-12-21T18:19:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, both.\n"}]}