{"thread":{"id":"32394","subject":"t7004: do not create unneeded gpghome/gpg.conf when GPG is not used","startedAt":"2012-12-18T19:25:54Z","lastAt":"2012-12-18T19:25:54Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"205149","messageId":"7vk3sff9h9.fsf@alter.siamese.dyndns.org","threadId":"32394","inReplyTo":null,"subject":"t7004: do not create unneeded gpghome/gpg.conf when GPG is not used","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-12-18T19:25:54Z","receivedAt":"2012-12-18T19:25:54Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"These tests themselves are properly protected by the GPG\nprerequisite, but one of the set-up steps outside the\ntest_expect_success block unconditionally assumed that there is a\ngpghome/ directory, which is not true if GPG is not being used.\n\nIt may be a good idea to move the whole set-up steps in the test but\nthat is a follow-up topic.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n t/t7004-tag.sh | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git i/t/t7004-tag.sh w/t/t7004-tag.sh\nindex 5189446..f5a79b1 100755\n--- i/t/t7004-tag.sh\n+++ w/t/t7004-tag.sh\n@@ -1066,12 +1066,12 @@ test_expect_success GPG \\\n '\n \n # usage with rfc1991 signatures\n-echo \"rfc1991\" > gpghome/gpg.conf\n get_tag_header rfc1991-signed-tag $commit commit $time >expect\n echo \"RFC1991 signed tag\" >>expect\n echo '-----BEGIN PGP MESSAGE-----' >>expect\n test_expect_success GPG \\\n \t'creating a signed tag with rfc1991' '\n+\techo \"rfc1991\" >gpghome/gpg.conf &&\n \tgit tag -s -m \"RFC1991 signed tag\" rfc1991-signed-tag $commit &&\n \tget_tag_msg rfc1991-signed-tag >actual &&\n \ttest_cmp expect actual\n@@ -1085,6 +1085,7 @@ chmod +x fakeeditor\n \n test_expect_success GPG \\\n \t'reediting a signed tag body omits signature' '\n+\techo \"rfc1991\" >gpghome/gpg.conf &&\n \techo \"RFC1991 signed tag\" >expect &&\n \tGIT_EDITOR=./fakeeditor git tag -f -s rfc1991-signed-tag $commit &&\n \ttest_cmp expect actual\n@@ -1092,11 +1093,13 @@ test_expect_success GPG \\\n \n test_expect_success GPG \\\n \t'verifying rfc1991 signature' '\n+\techo \"rfc1991\" >gpghome/gpg.conf &&\n \tgit tag -v rfc1991-signed-tag\n '\n \n test_expect_success GPG \\\n \t'list tag with rfc1991 signature' '\n+\techo \"rfc1991\" >gpghome/gpg.conf &&\n \techo \"rfc1991-signed-tag RFC1991 signed tag\" >expect &&\n \tgit tag -l -n1 rfc1991-signed-tag >actual &&\n \ttest_cmp expect actual &&\n"}]}