{"thread":{"id":"32386","subject":"[PATCH v4 1/3] Makefile: remove tracking of TCLTK_PATH","startedAt":"2012-12-18T15:26:37Z","lastAt":"2012-12-18T15:26:37Z","messageCount":1,"participants":["Christian Couder"],"isPatch":true,"patchVersion":4,"patchTotal":3},"messages":[{"id":"205125","messageId":"20121218152640.29297.55215.chriscool@tuxfamily.org","threadId":"32386","inReplyTo":null,"subject":"[PATCH v4 1/3] Makefile: remove tracking of TCLTK_PATH","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2012-12-18T15:26:37Z","receivedAt":"2012-12-18T15:26:37Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"It looks like we are tracking the value of TCLTK_PATH in the main\nMakefile for no good reason.\n\nThis patch removes the useless code used to do this tracking.\n\nMaybe this code should have been moved to gitk-git/Makefile by\n62ba514 (Move gitk to its own subdirectory, 2007-11-17).\nA patch to do that has just been sent to Paul Mackerras, the gitk\nmaintainer.\n\nWhile at it, this patch removes /gitk-git/gitk-wish from\n.gitignore as it should be in /gitk-git/.gitignore and the patch\nsent to Paul put it there.\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\nHi Junio,\n\nI removed from the commit message everything that talked about\ngit-gui. And this patch removes /gitk-git/gitk-wish from\n.gitignore.\n\nRegards,\nChristian.\n\n .gitignore |  2 --\n Makefile   | 14 +-------------\n 2 files changed, 1 insertion(+), 15 deletions(-)\n\ndiff --git a/.gitignore b/.gitignore\nindex f702415..64a454b 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -1,7 +1,6 @@\n /GIT-BUILD-OPTIONS\n /GIT-CFLAGS\n /GIT-LDFLAGS\n-/GIT-GUI-VARS\n /GIT-PREFIX\n /GIT-SCRIPT-DEFINES\n /GIT-USER-AGENT\n@@ -171,7 +170,6 @@\n /git-whatchanged\n /git-write-tree\n /git-core-*/?*\n-/gitk-git/gitk-wish\n /gitweb/GITWEB-BUILD-OPTIONS\n /gitweb/gitweb.cgi\n /gitweb/static/gitweb.js\ndiff --git a/Makefile b/Makefile\nindex 4ad6fbd..585b2eb 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2624,18 +2624,6 @@ ifdef GIT_PERF_MAKE_OPTS\n \t@echo GIT_PERF_MAKE_OPTS=\\''$(subst ','\\'',$(subst ','\\'',$(GIT_PERF_MAKE_OPTS)))'\\' >>$@\n endif\n \n-### Detect Tck/Tk interpreter path changes\n-ifndef NO_TCLTK\n-TRACK_VARS = $(subst ','\\'',-DTCLTK_PATH='$(TCLTK_PATH_SQ)')\n-\n-GIT-GUI-VARS: FORCE\n-\t@VARS='$(TRACK_VARS)'; \\\n-\t    if test x\"$$VARS\" != x\"`cat $@ 2>/dev/null`\" ; then \\\n-\t\techo 1>&2 \"    * new Tcl/Tk interpreter location\"; \\\n-\t\techo \"$$VARS\" >$@; \\\n-            fi\n-endif\n-\n test_bindir_programs := $(patsubst %,bin-wrappers/%,$(BINDIR_PROGRAMS_NEED_X) $(BINDIR_PROGRAMS_NO_X) $(TEST_PROGRAMS_NEED_X))\n \n all:: $(TEST_PROGRAMS) $(test_bindir_programs)\n@@ -2910,7 +2898,7 @@ ifndef NO_TCLTK\n \t$(MAKE) -C gitk-git clean\n \t$(MAKE) -C git-gui clean\n endif\n-\t$(RM) GIT-VERSION-FILE GIT-CFLAGS GIT-LDFLAGS GIT-GUI-VARS GIT-BUILD-OPTIONS\n+\t$(RM) GIT-VERSION-FILE GIT-CFLAGS GIT-LDFLAGS GIT-BUILD-OPTIONS\n \t$(RM) GIT-USER-AGENT GIT-PREFIX GIT-SCRIPT-DEFINES\n \n .PHONY: all install profile-clean clean strip\n-- \n1.8.1.rc1.2.g8740035\n"}]}