{"thread":{"id":"32344","subject":"Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h","startedAt":"2012-12-14T23:16:30Z","lastAt":"2012-12-15T08:25:15Z","messageCount":2,"participants":["Johannes Sixt","Joachim Schmitz"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"204887","messageId":"50CBB34E.8090609@kdbg.org","threadId":"32344","inReplyTo":"00c601cdda4c$eb6be9a0$c243bce0$@schmitz-digital.de","subject":"Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2012-12-14T23:16:30Z","receivedAt":"2012-12-14T23:16:30Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 14.12.2012 23:46, schrieb Joachim Schmitz:\n> Johannes Sixt wrote:\n>> Am 14.12.2012 20:57, schrieb David Michael:\n>>> This platform previously included strings.h automatically.  However,\n>>> the build system now requires an explicit option to do so.\n>>>\n>>> Signed-off-by: David Michael <fedora.dm0@gmail.com>\n>>> ---\n>>>  Makefile | 1 +\n>>>  1 file changed, 1 insertion(+)\n>>>\n>>> diff --git a/Makefile b/Makefile\n>>> index fb78f7f..e84b0cb 100644\n>>> --- a/Makefile\n>>> +++ b/Makefile\n>>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n>>>      # Added manually, see above.\n>>>      NEEDS_SSL_WITH_CURL = YesPlease\n>>>      HAVE_LIBCHARSET_H = YesPlease\n>>> +    HAVE_STRINGS_H = YesPlease\n>>>      NEEDS_LIBICONV = YesPlease\n>>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease\n>>>      NO_SYS_SELECT_H = UnfortunatelyYes\n>>\n>> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this\n>> should be squashed into the previous patch, shouldn't it?\n> \n> Patch 4/4 does not work without 3/4, Not for HP-NonStop.\n\nThat is clear from the order of the patches in the series.\n\nTo put it in a different way: Do all supported platforms still work\nafter 3/4, but without 4/4?\n\n-- Hannes\n"},{"id":"204898","messageId":"00c701cdda9d$b5ee33e0$21ca9ba0$@schmitz-digital.de","threadId":"32344","inReplyTo":"50CBB34E.8090609@kdbg.org","subject":"RE: [PATCH 4/4] Declare that HP NonStop systems require strings.h","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-12-15T08:25:15Z","receivedAt":"2012-12-15T08:25:15Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Johannes Sixt [mailto:j6t@kdbg.org]\n> Sent: Saturday, December 15, 2012 12:17 AM\n> To: Joachim Schmitz\n> Cc: gitster@pobox.com; fedora.dm0@gmail.com; Git Mailing List\n> Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h\n> \n> Am 14.12.2012 23:46, schrieb Joachim Schmitz:\n> > Johannes Sixt wrote:\n> >> Am 14.12.2012 20:57, schrieb David Michael:\n> >>> This platform previously included strings.h automatically.  However,\n> >>> the build system now requires an explicit option to do so.\n> >>>\n> >>> Signed-off-by: David Michael <fedora.dm0@gmail.com>\n> >>> ---\n> >>>  Makefile | 1 +\n> >>>  1 file changed, 1 insertion(+)\n> >>>\n> >>> diff --git a/Makefile b/Makefile\n> >>> index fb78f7f..e84b0cb 100644\n> >>> --- a/Makefile\n> >>> +++ b/Makefile\n> >>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n> >>>      # Added manually, see above.\n> >>>      NEEDS_SSL_WITH_CURL = YesPlease\n> >>>      HAVE_LIBCHARSET_H = YesPlease\n> >>> +    HAVE_STRINGS_H = YesPlease\n> >>>      NEEDS_LIBICONV = YesPlease\n> >>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease\n> >>>      NO_SYS_SELECT_H = UnfortunatelyYes\n> >>\n> >> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this\n> >> should be squashed into the previous patch, shouldn't it?\n> >\n> > Patch 4/4 does not work without 3/4, Not for HP-NonStop.\n> \n> That is clear from the order of the patches in the series.\n> \n> To put it in a different way: Do all supported platforms still work\n> after 3/4, but without 4/4?\n\nSorry I didn't make myself clear, I left out a \"and vice versa\"\n\nBye, Jojo\n"}]}