{"thread":{"id":"32331","subject":"Build fixes for another obscure Unix","startedAt":"2012-12-13T15:22:44Z","lastAt":"2012-12-14T19:48:52Z","messageCount":6,"participants":["David Michael","Pyeron, Jason J CTR (US)","Junio C Hamano","Joachim Schmitz"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"204834","messageId":"CAEvUa7nn9M5np3wD=Z1152K4pwNGhSKkC=rS9U=yc=UcaOxMCw@mail.gmail.com","threadId":"32331","inReplyTo":null,"subject":"Build fixes for another obscure Unix","fromName":"David Michael","fromEmail":"fedora.dm0@gmail.com","sentAt":"2012-12-13T15:22:44Z","receivedAt":"2012-12-13T15:22:44Z","isPatch":false,"sender":{"key":"fedora.dm0@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1379865?v=4"},"body":"Hi,\n\nI've been experimenting with git running on z/OS USS. It is not yet\nstable, but I have had to make a few fixes and generalizations in the\nbuild system to get it to compile.\n\nWould there be any interest in applying such individual compatibility\nfixes for this system, even if a full port doesn't reach completion?\n\nThanks.\n\nDavid\n"},{"id":"204838","messageId":"871B6C10EBEFE342A772D1159D13208539FF9088@umechphg.easf.csd.disa.mil","threadId":"32331","inReplyTo":"CAEvUa7nn9M5np3wD=Z1152K4pwNGhSKkC=rS9U=yc=UcaOxMCw@mail.gmail.com","subject":"RE: Build fixes for another obscure Unix","fromName":"Pyeron, Jason J CTR (US)","fromEmail":"jason.j.pyeron.ctr@mail.mil","sentAt":"2012-12-13T17:18:03Z","receivedAt":"2012-12-13T17:18:03Z","isPatch":false,"sender":{"key":"jason.j.pyeron.ctr@mail.mil","avatar":null},"body":"> -----Original Message-----\n> From: David Michael\n> Sent: Thursday, December 13, 2012 10:23 AM\n> \n> Hi,\n> \n> I've been experimenting with git running on z/OS USS. It is not yet\n> stable, but I have had to make a few fixes and generalizations in the\n> build system to get it to compile.\n\nMaybe it would help address other build issues on other platforms.\n\n> \n> Would there be any interest in applying such individual compatibility\n> fixes for this system, even if a full port doesn't reach completion?\n\nWhat are the down sides? Can your changes be shown to not impact builds on other systems?\n"},{"id":"204845","messageId":"7v38z9zsv1.fsf@alter.siamese.dyndns.org","threadId":"32331","inReplyTo":"CAEvUa7nn9M5np3wD=Z1152K4pwNGhSKkC=rS9U=yc=UcaOxMCw@mail.gmail.com","subject":"Re: Build fixes for another obscure Unix","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-12-13T18:53:22Z","receivedAt":"2012-12-13T18:53:22Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"David Michael writes:\n\n> I've been experimenting with git running on z/OS USS. It is not yet\n> stable, but I have had to make a few fixes and generalizations in the\n> build system to get it to compile.\n>\n> Would there be any interest in applying such individual compatibility\n> fixes for this system, even if a full port doesn't reach completion?\n\nIf you post patches here, it may help you find like-minded people\nwho may want to join forces and help you complete the port, so by\nall means.\n\nIf I pick up a partially completed series and carry it in my tree is\na separate matter. The patch has to be cleanly done (i.e. without\ntoo many #ifdefs) for longer-term maintainability, and it has to be\nclear that the changes do not affect other platforms negatively.\n"},{"id":"204856","messageId":"CAEvUa7nNNYREAsxc==tfg+e1XNZFbDVOpGXE6z-7+SfbqNrp6Q@mail.gmail.com","threadId":"32331","inReplyTo":"871B6C10EBEFE342A772D1159D13208539FF9088@umechphg.easf.csd.disa.mil","subject":"Re: Build fixes for another obscure Unix","fromName":"David Michael","fromEmail":"fedora.dm0@gmail.com","sentAt":"2012-12-13T22:30:27Z","receivedAt":"2012-12-13T22:30:27Z","isPatch":false,"sender":{"key":"fedora.dm0@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1379865?v=4"},"body":"Hi,\n\nOn Thu, Dec 13, 2012 at 12:18 PM, Pyeron, Jason J CTR (US)\n wrote:\n>> Would there be any interest in applying such individual compatibility\n>> fixes for this system, even if a full port doesn't reach completion?\n>\n> What are the down sides? Can your changes be shown to not impact builds on other systems?\n\nI've pushed a handful of small compatibility patches to GitHub[1]\nwhich are enough to successfully compile the project. The default\nvalues of the new variables should make them unnoticeable to other\nsystems.\n\nAre there any concerns with this type of change? If they would be\nacceptable, I can try sending the first four of those patches to the\nlist properly. (I expect the last two may be tweaked as I continue\nworking with the port.)\n\nI do have a concern with strings.h, though. That file will be\nincluded for most people who run ./configure, when it wasn't before.\nDo you think it's worth making a more detailed test to see if\nstrcasecmp is still undefined after string.h is included, rather than\njust testing for the header's existence?\n\nThanks.\n\nDavid\n\n[1] https://github.com/dm0-/git/commits\n"},{"id":"204865","messageId":"kaem06$3go$1@ger.gmane.org","threadId":"32331","inReplyTo":"CAEvUa7nNNYREAsxc==tfg+e1XNZFbDVOpGXE6z-7+SfbqNrp6Q@mail.gmail.com","subject":"Re: Build fixes for another obscure Unix","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-12-14T07:54:40Z","receivedAt":"2012-12-14T07:54:40Z","isPatch":false,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"David Michael wrote:\n> Hi,\n>\n> On Thu, Dec 13, 2012 at 12:18 PM, Pyeron, Jason J CTR (US)\n> wrote:\n>>> Would there be any interest in applying such individual\n>>> compatibility fixes for this system, even if a full port doesn't\n>>> reach completion?\n>>\n>> What are the down sides? Can your changes be shown to not impact\n>> builds on other systems?\n>\n> I've pushed a handful of small compatibility patches to GitHub[1]\n> which are enough to successfully compile the project. The default\n> values of the new variables should make them unnoticeable to other\n> systems.\n>\n> Are there any concerns with this type of change? If they would be\n> acceptable, I can try sending the first four of those patches to the\n> list properly. (I expect the last two may be tweaked as I continue\n> working with the port.)\n>\n> I do have a concern with strings.h, though. That file will be\n> included for most people who run ./configure, when it wasn't before.\n> Do you think it's worth making a more detailed test to see if\n> strcasecmp is still undefined after string.h is included, rather than\n> just testing for the header's existence?\n>\n> Thanks.\n>\n> David\n>\n> [1] https://github.com/dm0-/git/commits\n\nFor what's it worth: I ACK your HP-NonStop patch (as you can see by my \ncomment in git-compat-util.h I was thinking along the same line)\nhttps://github.com/dm0-/git/commit/933d72a5cfdc63fa9c3c68afa2f4899d9c3f791e\ntogether with its prerequisit\nhttps://github.com/dm0-/git/commit/301032c6488aeabb94ccc81bfb6d65ff2c23b924\n\nACKed by: Joachim Schmitz \n"},{"id":"204875","messageId":"CAEvUa7nP=yWZTLLoSRN_gucrj_eDhCz5ki3DMsHd+_c6ci14CA@mail.gmail.com","threadId":"32331","inReplyTo":"kaem06$3go$1@ger.gmane.org","subject":"Re: Build fixes for another obscure Unix","fromName":"David Michael","fromEmail":"fedora.dm0@gmail.com","sentAt":"2012-12-14T19:48:52Z","receivedAt":"2012-12-14T19:48:52Z","isPatch":false,"sender":{"key":"fedora.dm0@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1379865?v=4"},"body":"Hi,\n\nOn Fri, Dec 14, 2012 at 2:54 AM, Joachim Schmitz\n wrote:\n> For what's it worth: I ACK your HP-NonStop patch (as you can see by my\n> comment in git-compat-util.h I was thinking along the same line)\n> https://github.com/dm0-/git/commit/933d72a5cfdc63fa9c3c68afa2f4899d9c3f791e\n> together with its prerequisit\n> https://github.com/dm0-/git/commit/301032c6488aeabb94ccc81bfb6d65ff2c23b924\n>\n> ACKed by: Joachim Schmitz \n\nOkay, thanks for verifying. Especially since another port needing\nthat header was just sent to the list, I'd prefer to see some\ngeneralized feature test rather than building and maintaining an\nexplicit OS list.\n\nNo one has suggested any adjustments, so I'll send out those patches now.\n\nThanks.\n\nDavid\n"}]}