{"thread":{"id":"32297","subject":"[PATCH 4/8] t9402: No space after IO-redirection","startedAt":"2012-12-08T21:34:38Z","lastAt":"2012-12-08T21:34:38Z","messageCount":1,"participants":["Torsten Bögershausen"],"isPatch":true,"patchVersion":1,"patchTotal":8},"messages":[{"id":"204612","messageId":"201212082234.39648.tboegi@web.de","threadId":"32297","inReplyTo":null,"subject":"[PATCH 4/8] t9402: No space after IO-redirection","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2012-12-08T21:34:38Z","receivedAt":"2012-12-08T21:34:38Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Redirection should not have SP before the filename\n(i.e. \">out\", not \"> out\").\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t9402-git-cvsserver-refs.sh | 60 +++++++++++++++++++++----------------------\n 1 file changed, 30 insertions(+), 30 deletions(-)\n\ndiff --git a/t/t9402-git-cvsserver-refs.sh b/t/t9402-git-cvsserver-refs.sh\nindex 21000ec..2f63331 100755\n--- a/t/t9402-git-cvsserver-refs.sh\n+++ b/t/t9402-git-cvsserver-refs.sh\n@@ -11,7 +11,7 @@ tags, branches and other git refspecs'\n \n check_start_tree() {\n     rm -f \"$WORKDIR/check.list\"\n-    echo \"start $1\" >> \"${WORKDIR}/check.log\"\n+    echo \"start $1\" >>\"${WORKDIR}/check.log\"\n }\n \n check_file() {\n@@ -19,11 +19,11 @@ check_file() {\n     file=\"$2\"\n     ver=\"$3\"\n     GIT_DIR=$SERVERDIR git show \"${ver}:${file}\" \\\n-\t> \"$WORKDIR/check.got\" 2> \"$WORKDIR/check.stderr\"\n+\t>\"$WORKDIR/check.got\" 2>\"$WORKDIR/check.stderr\"\n     test_cmp \"$WORKDIR/check.got\" \"$sandbox/$file\"\n     stat=$?\n-    echo \"check_file $sandbox $file $ver : $stat\" >> \"$WORKDIR/check.log\"\n-    echo \"$file\" >> \"$WORKDIR/check.list\"\n+    echo \"check_file $sandbox $file $ver : $stat\" >>\"$WORKDIR/check.log\"\n+    echo \"$file\" >>\"$WORKDIR/check.list\"\n     return $stat\n }\n \n@@ -57,7 +57,7 @@ check_diff() {\n     ( cd diffSandbox &&\n       git checkout \"$vOld\" &&\n       git apply -p0 --index <\"../$diffFile\" &&\n-      git diff --exit-code \"$vNew\" ) > check_diff_apply.out 2>&1\n+      git diff --exit-code \"$vNew\" ) >check_diff_apply.out 2>&1\n }\n \n #########\n@@ -89,18 +89,18 @@ export CVSROOT CVS_SERVER\n \n rm -rf \"$CVSWORK\" \"$SERVERDIR\"\n test_expect_success 'setup v1, b1' '\n-    echo \"Simple text file\" > textfile.c &&\n-    echo \"t2\" > t2 &&\n+    echo \"Simple text file\" >textfile.c &&\n+    echo \"t2\" >t2 &&\n     mkdir adir &&\n-    echo \"adir/afile line1\" > adir/afile &&\n-    echo \"adir/afile line2\" >> adir/afile &&\n-    echo \"adir/afile line3\" >> adir/afile &&\n-    echo \"adir/afile line4\" >> adir/afile &&\n-    echo \"adir/a2file\" >> adir/a2file &&\n+    echo \"adir/afile line1\" >adir/afile &&\n+    echo \"adir/afile line2\" >>adir/afile &&\n+    echo \"adir/afile line3\" >>adir/afile &&\n+    echo \"adir/afile line4\" >>adir/afile &&\n+    echo \"adir/a2file\" >>adir/a2file &&\n     mkdir adir/bdir &&\n-    echo \"adir/bdir/bfile line 1\" > adir/bdir/bfile &&\n-    echo \"adir/bdir/bfile line 2\" >> adir/bdir/bfile &&\n-    echo \"adir/bdir/b2file\" > adir/bdir/b2file &&\n+    echo \"adir/bdir/bfile line 1\" >adir/bdir/bfile &&\n+    echo \"adir/bdir/bfile line 2\" >>adir/bdir/bfile &&\n+    echo \"adir/bdir/b2file\" >adir/bdir/b2file &&\n     git add textfile.c t2 adir &&\n     git commit -q -m \"First Commit (v1)\" &&\n     git tag v1 &&\n@@ -152,7 +152,7 @@ test_expect_success 'edit cvswork3 and save diff' '\n     ( cd cvswork3 &&\n       sed -e \"s/line1/line1 - data/\" adir/afile >adir/afileNEW &&\n \t\t\tmv -f adir/afileNEW adir/afile &&\n-      echo \"afile5\" > adir/afile5 &&\n+      echo \"afile5\" >adir/afile5 &&\n       rm t2 &&\n       cvs -f add adir/afile5 &&\n       cvs -f rm t2 &&\n@@ -162,17 +162,17 @@ test_expect_success 'edit cvswork3 and save diff' '\n \n test_expect_success 'setup v1.2 on b1' '\n     git checkout b1 &&\n-    echo \"new v1.2\" > t3 &&\n+    echo \"new v1.2\" >t3 &&\n     rm t2 &&\n     sed -e \"s/line3/line3 - more data/\" adir/afile >adir/afileNEW &&\n \t\tmv -f adir/afileNEW adir/afile &&\n     rm adir/a2file &&\n-    echo \"a3file\" >> adir/a3file &&\n-    echo \"bfile line 3\" >> adir/bdir/bfile &&\n+    echo \"a3file\" >>adir/a3file &&\n+    echo \"bfile line 3\" >>adir/bdir/bfile &&\n     rm adir/bdir/b2file &&\n-    echo \"b3file\" > adir/bdir/b3file &&\n+    echo \"b3file\" >adir/bdir/b3file &&\n     mkdir cdir &&\n-    echo \"cdir/cfile\" > cdir/cfile &&\n+    echo \"cdir/cfile\" >cdir/cfile &&\n     git add -A cdir adir t3 t2 &&\n     git commit -q -m 'v1.2' &&\n     git tag v1.2 &&\n@@ -280,7 +280,7 @@ test_expect_success 'cvs co b2 [into cvswork2]' '\n \n test_expect_success 'root dir edit [cvswork2]' '\n     ( cd cvswork2 &&\n-      echo \"Line 2\" >> textfile.c &&\n+      echo \"Line 2\" >>textfile.c &&\n       ! cvs -f diff -u >\"$WORKDIR/cvsEdit1.diff\" &&\n       cvs -f commit -m \"edit textfile.c\" textfile.c\n     ) >cvsEdit1.log 2>&1\n@@ -289,10 +289,10 @@ test_expect_success 'root dir edit [cvswork2]' '\n test_expect_success 'root dir rm file [cvswork2]' '\n     ( cd cvswork2 &&\n       cvs -f rm -f t2 &&\n-      cvs -f diff -u > ../cvsEdit2-empty.diff &&\n+      cvs -f diff -u >../cvsEdit2-empty.diff &&\n       ! cvs -f diff -N -u >\"$WORKDIR/cvsEdit2-N.diff\" &&\n       cvs -f commit -m \"rm t2\"\n-    ) > cvsEdit2.log 2>&1\n+    ) >cvsEdit2.log 2>&1\n '\n \n test_expect_success 'subdir edit/add/rm files [cvswork2' '\n@@ -302,7 +302,7 @@ test_expect_success 'subdir edit/add/rm files [cvswork2' '\n       rm adir/bdir/b2file &&\n       cd adir &&\n       cvs -f rm bdir/b2file &&\n-      echo \"4th file\" > bdir/b4file &&\n+      echo \"4th file\" >bdir/b4file &&\n       cvs -f add bdir/b4file &&\n       ! cvs -f diff -N -u >\"$WORKDIR/cvsEdit3.diff\" &&\n       git fetch gitcvs.git b2:b2 &&\n@@ -471,7 +471,7 @@ test_expect_success 'cvs diff -N -r v2 -u' '\n       ! cvs -f diff -N -r v2 -u ) >cvsDiff.out 2>cvs.log &&\n     test ! -s cvs.log &&\n     test -s cvsDiff.out &&\n-    check_diff cvsDiff.out v2 v1 > check_diff.out 2>&1\n+    check_diff cvsDiff.out v2 v1 >check_diff.out 2>&1\n '\n \n test_expect_success 'cvs diff -N -r v2 -r v1.2' '\n@@ -479,7 +479,7 @@ test_expect_success 'cvs diff -N -r v2 -r v1.2' '\n       ! cvs -f diff -N -r v2 -r v1.2 -u ) >cvsDiff.out 2>cvs.log &&\n     test ! -s cvs.log &&\n     test -s cvsDiff.out &&\n-    check_diff cvsDiff.out v2 v1.2 > check_diff.out 2>&1\n+    check_diff cvsDiff.out v2 v1.2 >check_diff.out 2>&1\n '\n \n test_expect_success 'apply early [cvswork3] diff to b3' '\n@@ -499,7 +499,7 @@ test_expect_success 'check [cvswork3] diff' '\n     test -s cvsDiff.out &&\n     test $(grep Index: cvsDiff.out | wc -l) = 3 &&\n     test_cmp cvsDiff.out cvswork3edit.diff &&\n-    check_diff cvsDiff.out v1 v3 > check_diff.out 2>&1\n+    check_diff cvsDiff.out v1 v3 >check_diff.out 2>&1\n '\n \n test_expect_success 'merge early [cvswork3] b3 with b1' '\n@@ -537,7 +537,7 @@ test_expect_success 'cvs up dirty [cvswork3]' '\n test_expect_success 'cvs commit [cvswork3' '\n     ( cd cvswork3 &&\n       cvs -f commit -m \"dirty sandbox after auto-merge\"\n-    ) > cvs.log 2>&1 &&\n+    ) >cvs.log 2>&1 &&\n     check_start_tree cvswork3 &&\n     check_file cvswork3 textfile.c v3merged &&\n     check_file cvswork3 t3 v3merged &&\n@@ -550,7 +550,7 @@ test_expect_success 'cvs commit [cvswork3' '\n     check_end_full_tree cvswork3 v3merged &&\n     git fetch gitcvs.git b3:b4 &&\n     git tag v4.1 b4 &&\n-    git diff --exit-code v4.1 v3merged > check_diff_apply.out 2>&1\n+    git diff --exit-code v4.1 v3merged >check_diff_apply.out 2>&1\n '\n \n test_done\n-- \n1.8.0.197.g5a90748\n"}]}