{"thread":{"id":"32243","subject":"[PATCH] DESTDIR support in contrib/subtree/Makefile","startedAt":"2012-11-29T15:41:04Z","lastAt":"2013-01-01T02:58:17Z","messageCount":2,"participants":["Adam Tkac","greened@obbligato.org"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"204257","messageId":"20121129154057.GA4300@redhat.com","threadId":"32243","inReplyTo":null,"subject":"[PATCH] DESTDIR support in contrib/subtree/Makefile","fromName":"Adam Tkac","fromEmail":"atkac@redhat.com","sentAt":"2012-11-29T15:41:04Z","receivedAt":"2012-11-29T15:41:04Z","isPatch":true,"sender":{"key":"atkac@redhat.com","avatar":null},"body":"Signed-off-by: Adam Tkac <atkac@redhat.com>\n---\n\nIt is a good habit in Makefiles to honor DESTDIR variable to support\n\n`make DESTDIR=/instalroot install`\n\nsyntax.\n\nComments are welcomed.\n\nRegards, Adam\n\n contrib/subtree/Makefile | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\nindex 05cdd5c..36ae3e4 100644\n--- a/contrib/subtree/Makefile\n+++ b/contrib/subtree/Makefile\n@@ -30,12 +30,12 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)\n doc: $(GIT_SUBTREE_DOC)\n \n install: $(GIT_SUBTREE)\n-\t$(INSTALL) -m 755 $(GIT_SUBTREE) $(libexecdir)\n+\t$(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(libexecdir)\n \n install-doc: install-man\n \n install-man: $(GIT_SUBTREE_DOC)\n-\t$(INSTALL) -m 644 $^ $(man1dir)\n+\t$(INSTALL) -m 644 $^ $(DESTDIR)$(man1dir)\n \n $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)\n \txmlto -m $(MANPAGE_NORMAL_XSL)  man $^\n-- \n1.8.0\n\n\n-- \nAdam Tkac, Red Hat, Inc.\n"},{"id":"205738","messageId":"87a9sty5h2.fsf@waller.obbligato.org","threadId":"32243","inReplyTo":"20121129154057.GA4300@redhat.com","subject":"Re: [PATCH] DESTDIR support in contrib/subtree/Makefile","fromName":"","fromEmail":"greened@obbligato.org","sentAt":"2013-01-01T02:58:17Z","receivedAt":"2013-01-01T02:58:17Z","isPatch":true,"sender":{"key":"greened@obbligato.org","avatar":"https://avatars.githubusercontent.com/u/5291869?v=4"},"body":"Adam Tkac <atkac@redhat.com> writes:\n\n> Signed-off-by: Adam Tkac <atkac@redhat.com>\n> ---\n>\n> It is a good habit in Makefiles to honor DESTDIR variable to support\n>\n> `make DESTDIR=/instalroot install`\n>\n> syntax.\n>\n> Comments are welcomed.\n\nApplied.  I'll be sending this to the mailing list tonight or tomorrow.\n\n                         -David\n"}]}