{"thread":{"id":"32237","subject":"[PATCH] completion: fix warning for zsh","startedAt":"2012-11-29T08:20:57Z","lastAt":"2012-11-29T18:02:15Z","messageCount":2,"participants":["Felipe Contreras","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"204241","messageId":"1354177257-5416-1-git-send-email-felipe.contreras@gmail.com","threadId":"32237","inReplyTo":null,"subject":"[PATCH] completion: fix warning for zsh","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-29T08:20:57Z","receivedAt":"2012-11-29T08:20:57Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Otherwise the user might get something like:\n\n  git-completion.sh:2466: command not found: compdef\n\nIf this script is loaded before compinit. The script would work either\nway, but let's not be more annoying to the user.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n contrib/completion/git-completion.bash | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex af13fcc..0b77eb1 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2404,6 +2404,8 @@ __gitk_main ()\n if [[ -n ${ZSH_VERSION-} ]]; then\n \techo \"WARNING: this script is deprecated, please see git-completion.zsh\" 1>&2\n \n+\tautoload -U +X compinit && compinit\n+\n \t__gitcomp ()\n \t{\n \t\temulate -L zsh\n-- \n1.8.0.1\n"},{"id":"204271","messageId":"7vboegqod4.fsf@alter.siamese.dyndns.org","threadId":"32237","inReplyTo":"1354177257-5416-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] completion: fix warning for zsh","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-11-29T18:02:15Z","receivedAt":"2012-11-29T18:02:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Will apply directly on 'master'; thanks.\n"}]}