{"thread":{"id":"3220","subject":"[PATCH 2/2] git-send-email: Add --quiet to reduce some of the chatter when sending emails.","startedAt":"2006-02-02T16:56:06Z","lastAt":"2006-02-02T16:56:06Z","messageCount":2,"participants":["Ryan Anderson"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"15493","messageId":"11388993664094-git-send-email-ryan@michonline.com","threadId":"3220","inReplyTo":"11388993663675-git-send-email-ryan@michonline.com","subject":"[PATCH 2/2] git-send-email: Add --quiet to reduce some of the chatter when sending emails.","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2006-02-02T16:56:06Z","receivedAt":"2006-02-02T16:56:06Z","isPatch":true,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"Signed-off-by: Ryan Anderson <ryan@michonline.com>\n\n---\n\n git-send-email.perl |    9 ++++++---\n 1 files changed, 6 insertions(+), 3 deletions(-)\n\n3dcbd6298dc6fb4a903404cb9c47e3690bf2e01a\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 51b7513..ca1fa37 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -34,7 +34,7 @@ my $compose_filename = \".msg.$$\";\n my (@to,@cc,$initial_reply_to,$initial_subject,@files,$from,$compose);\n \n # Behavior modification variables\n-my ($chain_reply_to, $smtp_server) = (1, \"localhost\");\n+my ($chain_reply_to, $smtp_server, $quiet) = (1, \"localhost\", 0);\n \n # Example reply to:\n #$initial_reply_to = ''; #<20050203173208.GA23964@foobar.com>';\n@@ -51,6 +51,7 @@ my $rc = GetOptions(\"from=s\" => \\$from,\n \t\t    \"chain-reply-to!\" => \\$chain_reply_to,\n \t\t    \"smtp-server=s\" => \\$smtp_server,\n \t\t    \"compose\" => \\$compose,\n+\t\t    \"quiet\" => \\$quiet,\n \t );\n \n # Now, let's fill any that aren't set in with defaults:\n@@ -267,8 +268,10 @@ sub send_message\n \n \tsendmail(%mail) or die $Mail::Sendmail::error;\n \n-\tprint \"OK. Log says:\\n\", $Mail::Sendmail::log;\n-\tprint \"\\n\\n\"\n+\tunless ($quiet) {\n+\t\tprint \"OK. Log says:\\n\", $Mail::Sendmail::log;\n+\t\tprint \"\\n\\n\"\n+\t}\n }\n \n \n-- \n1.1.4.g3dcbd\n"},{"id":"15494","messageId":"11388993663675-git-send-email-ryan@michonline.com","threadId":"3220","inReplyTo":"11388993661745-git-send-email-ryan@michonline.com","subject":"[PATCH 1/2] Provide a more meaningful initial \"From \" line when using --compose in git-send-email.","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2006-02-02T16:56:06Z","receivedAt":"2006-02-02T16:56:06Z","isPatch":true,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"git-send-email, when used with --compose, provided the user with a mbox-format\nfile to edit.  Some users, however, were confused by the leading, blank, \"From\n\" line, so this change puts the value that will appear on the From: line of the\nactual email on this line, along with a note that the line is ignored.\n\nSigned-off-by: Ryan Anderson <ryan@michonline.com>\n\n---\n\n git-send-email.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\nc6b0c22e482aa6fe314e4be077d705c98fee7bf2\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex ec1428d..51b7513 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -125,7 +125,7 @@ if ($compose) {\n \t# effort to have it be unique\n \topen(C,\">\",$compose_filename)\n \t\tor die \"Failed to open for writing $compose_filename: $!\";\n-\tprint C \"From \\n\";\n+\tprint C \"From $from # This line is ignored.\\n\";\n \tprintf C \"Subject: %s\\n\\n\", $initial_subject;\n \tprintf C <<EOT;\n GIT: Please enter your email below.\n-- \n1.1.4.g3dcbd\n"}]}