{"thread":{"id":"32193","subject":"[PATCH] Fix typo in remote set-head usage","startedAt":"2012-11-25T13:43:39Z","lastAt":"2012-11-26T21:28:10Z","messageCount":4,"participants":["Antoine Pelisse","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"203811","messageId":"1353851019-27254-1-git-send-email-apelisse@gmail.com","threadId":"32193","inReplyTo":null,"subject":"[PATCH] Fix typo in remote set-head usage","fromName":"Antoine Pelisse","fromEmail":"apelisse@gmail.com","sentAt":"2012-11-25T13:43:39Z","receivedAt":"2012-11-25T13:43:39Z","isPatch":true,"sender":{"key":"apelisse@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1929644?v=4"},"body":"parenthesis are not matching in `builtin_remote_sethead_usage`\nas a square bracket is closing something never opened.\n---\nThis will also break all translation files, should I also send a patch\nto update them ?\n\nCheers,\nAntoine Pelisse\n\n builtin/remote.c |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/remote.c b/builtin/remote.c\nindex a5a4b23..937484d 100644\n--- a/builtin/remote.c\n+++ b/builtin/remote.c\n@@ -39,7 +39,7 @@ static const char * const builtin_remote_rm_usage[] = {\n };\n\n static const char * const builtin_remote_sethead_usage[] = {\n-\tN_(\"git remote set-head <name> (-a | -d | <branch>])\"),\n+\tN_(\"git remote set-head <name> (-a | -d | <branch>)\"),\n \tNULL\n };\n\n--\n1.7.9.5\n"},{"id":"203900","messageId":"7vwqx8rzzf.fsf@alter.siamese.dyndns.org","threadId":"32193","inReplyTo":"1353851019-27254-1-git-send-email-apelisse@gmail.com","subject":"Re: [PATCH] Fix typo in remote set-head usage","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-11-26T18:16:52Z","receivedAt":"2012-11-26T18:16:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Antoine Pelisse <apelisse@gmail.com> writes:\n\n> parenthesis are not matching in `builtin_remote_sethead_usage`\n> as a square bracket is closing something never opened.\n> ---\n> This will also break all translation files, should I also send a patch\n> to update them ?\n\n\"git grep -A2 -e 'remote set-head <name>' po/\" tells me that we\nalready have both the correct variant and the broken one, and they\nare both translated ;-) so I do not think we have much to worry\nabout the i18n fallout in this case, but thanks anyway for thinking\nabout it.\n\nYou would need to sign off your patch, but otherwise looks good to\nme.\n\nThanks.\n\n\n>\n> Cheers,\n> Antoine Pelisse\n>\n>  builtin/remote.c |    2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/remote.c b/builtin/remote.c\n> index a5a4b23..937484d 100644\n> --- a/builtin/remote.c\n> +++ b/builtin/remote.c\n> @@ -39,7 +39,7 @@ static const char * const builtin_remote_rm_usage[] = {\n>  };\n>\n>  static const char * const builtin_remote_sethead_usage[] = {\n> -\tN_(\"git remote set-head <name> (-a | -d | <branch>])\"),\n> +\tN_(\"git remote set-head <name> (-a | -d | <branch>)\"),\n>  \tNULL\n>  };\n>\n> --\n> 1.7.9.5\n"},{"id":"203907","messageId":"1353957714-7330-1-git-send-email-apelisse@gmail.com","threadId":"32193","inReplyTo":"7vwqx8rzzf.fsf@alter.siamese.dyndns.org","subject":"[PATCH] Fix typo in remote set-head usage","fromName":"Antoine Pelisse","fromEmail":"apelisse@gmail.com","sentAt":"2012-11-26T19:21:54Z","receivedAt":"2012-11-26T19:21:54Z","isPatch":true,"sender":{"key":"apelisse@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1929644?v=4"},"body":"parenthesis are not matching in `builtin_remote_sethead_usage`\nas a square bracket is closing something never opened.\n\nSigned-off-by: Antoine Pelisse <apelisse@gmail.com>\n---\n builtin/remote.c |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/remote.c b/builtin/remote.c\nindex a5a4b23..937484d 100644\n--- a/builtin/remote.c\n+++ b/builtin/remote.c\n@@ -39,7 +39,7 @@ static const char * const builtin_remote_rm_usage[] = {\n };\n \n static const char * const builtin_remote_sethead_usage[] = {\n-\tN_(\"git remote set-head <name> (-a | -d | <branch>])\"),\n+\tN_(\"git remote set-head <name> (-a | -d | <branch>)\"),\n \tNULL\n };\n \n-- \n1.7.9.5\n"},{"id":"203933","messageId":"7vfw3wqck5.fsf@alter.siamese.dyndns.org","threadId":"32193","inReplyTo":"1353957714-7330-1-git-send-email-apelisse@gmail.com","subject":"Re: [PATCH] Fix typo in remote set-head usage","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-11-26T21:28:10Z","receivedAt":"2012-11-26T21:28:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}