{"thread":{"id":"32162","subject":"[PATCH] Fix bash completion when `egrep` is aliased to `egrep --color=always`","startedAt":"2012-11-22T15:41:21Z","lastAt":"2012-11-26T11:30:48Z","messageCount":4,"participants":["Adam Tkac","Marc Khouzam","Frans Klaver"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"203634","messageId":"20121122154120.GA16835@redhat.com","threadId":"32162","inReplyTo":null,"subject":"[PATCH] Fix bash completion when `egrep` is aliased to `egrep --color=always`","fromName":"Adam Tkac","fromEmail":"atkac@redhat.com","sentAt":"2012-11-22T15:41:21Z","receivedAt":"2012-11-22T15:41:21Z","isPatch":true,"sender":{"key":"atkac@redhat.com","avatar":null},"body":"Hello all,\n\nattached patch fixes bash completion when `egrep` is aliased to `egrep --color=always`.\n\nComments are welcomed.\n\nRegards, Adam\n\n-- \nAdam Tkac, Red Hat, Inc.\n\n\n>From 2b62bd71af1158129492f74f0b77c9840a49507f Mon Sep 17 00:00:00 2001\nFrom: Adam Tkac <atkac@redhat.com>\nDate: Thu, 22 Nov 2012 16:34:58 +0100\nSubject: [PATCH] Fix bash completion when `egrep` is aliased to `egrep\n --color=always`\n\nOriginally reported as https://bugzilla.redhat.com/show_bug.cgi?id=863780\n\nSigned-off-by: Adam Tkac <atkac@redhat.com>\nSigned-off-by: Holger Arnold <holgerar@gmail.com>\n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex bc0657a..47613f9 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -565,7 +565,7 @@ __git_complete_strategy ()\n __git_list_all_commands ()\n {\n \tlocal i IFS=\" \"$'\\n'\n-\tfor i in $(git help -a|egrep '^  [a-zA-Z0-9]')\n+\tfor i in $(git help -a|egrep --color=never '^  [a-zA-Z0-9]')\n \tdo\n \t\tcase $i in\n \t\t*--*)             : helper pattern;;\n-- \n1.8.0\n\n"},{"id":"203656","messageId":"CAFj1UpG6H3bpoa7xbqpH6Hyb6pwqE_CCgP6iT36D-ELvtVi4wA@mail.gmail.com","threadId":"32162","inReplyTo":"20121122154120.GA16835@redhat.com","subject":"Re: [PATCH] Fix bash completion when `egrep` is aliased to `egrep --color=always`","fromName":"Marc Khouzam","fromEmail":"marc.khouzam@gmail.com","sentAt":"2012-11-22T19:55:21Z","receivedAt":"2012-11-22T19:55:21Z","isPatch":true,"sender":{"key":"marc.khouzam@ericsson.com","avatar":"https://gravatar.com/avatar/de564e23ad14e2945f9f1cdb4d0227c935b5b54c39576a304d47caa3e23dcd33?d=mp&s=160"},"body":"On Thu, Nov 22, 2012 at 10:41 AM, Adam Tkac <atkac@redhat.com> wrote:\n> Hello all,\n>\n> attached patch fixes bash completion when `egrep` is aliased to `egrep --color=always`.\n\nTo avoid any aliases, it may be better to use\n\\egrep\n\nThis could be worthwhile for all utilities used by the script.\n\nJust a thought.\n\nMarc\n\n\n>\n> Comments are welcomed.\n>\n> Regards, Adam\n>\n> --\n> Adam Tkac, Red Hat, Inc.\n"},{"id":"203866","messageId":"20121126112352.GA4481@redhat.com","threadId":"32162","inReplyTo":"CAFj1UpG6H3bpoa7xbqpH6Hyb6pwqE_CCgP6iT36D-ELvtVi4wA@mail.gmail.com","subject":"Re: [PATCH] Fix bash completion when `egrep` is aliased to `egrep --color=always`","fromName":"Adam Tkac","fromEmail":"atkac@redhat.com","sentAt":"2012-11-26T11:23:53Z","receivedAt":"2012-11-26T11:23:53Z","isPatch":true,"sender":{"key":"atkac@redhat.com","avatar":null},"body":"On Thu, Nov 22, 2012 at 02:55:21PM -0500, Marc Khouzam wrote:\n> On Thu, Nov 22, 2012 at 10:41 AM, Adam Tkac <atkac@redhat.com> wrote:\n> > Hello all,\n> >\n> > attached patch fixes bash completion when `egrep` is aliased to `egrep --color=always`.\n> \n> To avoid any aliases, it may be better to use\n> \\egrep\n\nGood idea, thanks. Improved patch is attached.\n\nRegards, Adam\n\n> \n> This could be worthwhile for all utilities used by the script.\n> \n> Just a thought.\n> \n> Marc\n> \n> \n> >\n> > Comments are welcomed.\n> >\n> > Regards, Adam\n> >\n> > --\n> > Adam Tkac, Red Hat, Inc.\n\n-- \nAdam Tkac, Red Hat, Inc.\n\n\n>From 255192296cd175fddcac2647447a66a0ca55b855 Mon Sep 17 00:00:00 2001\nFrom: Adam Tkac <atkac@redhat.com>\nDate: Thu, 22 Nov 2012 16:34:58 +0100\nSubject: [PATCH] If `egrep` is aliased, temporary disable it in\n bash.completion\n\nOriginally reported as https://bugzilla.redhat.com/show_bug.cgi?id=863780\n\nSigned-off-by: Adam Tkac <atkac@redhat.com>\nSigned-off-by: Holger Arnold <holgerar@gmail.com>\n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 0960acc..79073c2 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -565,7 +565,7 @@ __git_complete_strategy ()\n __git_list_all_commands ()\n {\n \tlocal i IFS=\" \"$'\\n'\n-\tfor i in $(git help -a|egrep '^  [a-zA-Z0-9]')\n+\tfor i in $(git help -a| \\egrep '^  [a-zA-Z0-9]')\n \tdo\n \t\tcase $i in\n \t\t*--*)             : helper pattern;;\n-- \n1.8.0\n\n"},{"id":"203867","messageId":"CAH6sp9PwsxLDDXfA5oZk-3X+d7h5OdR3TRX7aMMyTA+8WDuSmA@mail.gmail.com","threadId":"32162","inReplyTo":"20121126112352.GA4481@redhat.com","subject":"Re: [PATCH] Fix bash completion when `egrep` is aliased to `egrep --color=always`","fromName":"Frans Klaver","fromEmail":"fransklaver@gmail.com","sentAt":"2012-11-26T11:30:48Z","receivedAt":"2012-11-26T11:30:48Z","isPatch":true,"sender":{"key":"fransklaver@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1876483?v=4"},"body":"On Mon, Nov 26, 2012 at 12:23 PM, Adam Tkac <atkac@redhat.com> wrote:\n\n> Good idea, thanks. Improved patch is attached.\n\nIt is custom on this list to mail the patches, rather than attaching\nthem, so people can review your changes in-line. You can read more\nabout it in in git/Documentation/SubmittingPatches.\n\nCheers,\nFrans\n"}]}