{"thread":{"id":"32139","subject":"[PATCH v3 0/6] completion: test consolidations","startedAt":"2012-11-18T10:51:51Z","lastAt":"2012-11-19T22:58:13Z","messageCount":9,"participants":["Felipe Contreras","Junio C Hamano"],"isPatch":true,"patchVersion":3,"patchTotal":6},"messages":[{"id":"203466","messageId":"1353235917-13059-1-git-send-email-felipe.contreras@gmail.com","threadId":"32139","inReplyTo":null,"subject":"[PATCH v3 0/6] completion: test consolidations","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-18T10:51:51Z","receivedAt":"2012-11-18T10:51:51Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"These started from a discussion with SZEDER, but then I realized there were\nmany improvements possible.\n\nChanges since v2:\n\n * Updated comments and commit messages\n\nChanges since v1:\n\n * A lot more cleanups\n\nFelipe Contreras (6):\n  completion: add comment for test_completion()\n  completion: standardize final space marker in tests\n  completion: simplify tests using test_completion_long()\n  completion: consolidate test_completion*() tests\n  completion: refactor __gitcomp related tests\n  completion: simplify __gitcomp() test helper\n\n t/t9902-completion.sh | 133 +++++++++++++++++++-------------------------------\n 1 file changed, 51 insertions(+), 82 deletions(-)\n\n-- \n1.8.0\n"},{"id":"203467","messageId":"1353235917-13059-2-git-send-email-felipe.contreras@gmail.com","threadId":"32139","inReplyTo":"1353235917-13059-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 1/6] completion: add comment for test_completion()","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-18T10:51:52Z","receivedAt":"2012-11-18T10:51:52Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"So that it's easier to understand what it does.\n\nAlso, make sure we pass only the first argument for completion.\nShouldn't cause any functional changes because run_completion only\nchecks $1.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n t/t9902-completion.sh | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex 8fa025f..2276a37 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -54,10 +54,14 @@ run_completion ()\n \t__git_wrap__git_main && print_comp\n }\n \n+# Test high-level completion\n+# Arguments are:\n+# 1: current command line\n+# 2: expected completion\n test_completion ()\n {\n \ttest $# -gt 1 && echo \"$2\" > expected\n-\trun_completion \"$@\" &&\n+\trun_completion \"$1\" &&\n \ttest_cmp expected out\n }\n \n-- \n1.8.0\n"},{"id":"203468","messageId":"1353235917-13059-3-git-send-email-felipe.contreras@gmail.com","threadId":"32139","inReplyTo":"1353235917-13059-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 2/6] completion: standardize final space marker in tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-18T10:51:53Z","receivedAt":"2012-11-18T10:51:53Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"The rest of the code uses ' Z$'. Lets use that for\ntest_completion_long() as well.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n t/t9902-completion.sh | 27 +++++++++++++--------------\n 1 file changed, 13 insertions(+), 14 deletions(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex 2276a37..f4c7342 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -66,11 +66,10 @@ test_completion ()\n }\n \n # Like test_completion, but reads expectation from stdin,\n-# which is convenient when it is multiline. We also process \"_\" into\n-# spaces to make test vectors more readable.\n+# which is convenient when it is multiline.\n test_completion_long ()\n {\n-\ttr _ \" \" >expected &&\n+\tsed -e 's/Z$//' > expected &&\n \ttest_completion \"$1\"\n }\n \n@@ -252,24 +251,24 @@ test_expect_success 'setup for ref completion' '\n \n test_expect_success 'checkout completes ref names' '\n \ttest_completion_long \"git checkout m\" <<-\\EOF\n-\tmaster_\n-\tmybranch_\n-\tmytag_\n+\tmaster Z\n+\tmybranch Z\n+\tmytag Z\n \tEOF\n '\n \n test_expect_success 'show completes all refs' '\n \ttest_completion_long \"git show m\" <<-\\EOF\n-\tmaster_\n-\tmybranch_\n-\tmytag_\n+\tmaster Z\n+\tmybranch Z\n+\tmytag Z\n \tEOF\n '\n \n test_expect_success '<ref>: completes paths' '\n \ttest_completion_long \"git show mytag:f\" <<-\\EOF\n-\tfile1_\n-\tfile2_\n+\tfile1 Z\n+\tfile2 Z\n \tEOF\n '\n \n@@ -278,7 +277,7 @@ test_expect_success 'complete tree filename with spaces' '\n \tgit add . &&\n \tgit commit -m spaces &&\n \ttest_completion_long \"git show HEAD:nam\" <<-\\EOF\n-\tname with spaces_\n+\tname with spaces Z\n \tEOF\n '\n \n@@ -287,8 +286,8 @@ test_expect_failure 'complete tree filename with metacharacters' '\n \tgit add . &&\n \tgit commit -m meta &&\n \ttest_completion_long \"git show HEAD:nam\" <<-\\EOF\n-\tname with ${meta}_\n-\tname with spaces_\n+\tname with ${meta} Z\n+\tname with spaces Z\n \tEOF\n '\n \n-- \n1.8.0\n"},{"id":"203469","messageId":"1353235917-13059-4-git-send-email-felipe.contreras@gmail.com","threadId":"32139","inReplyTo":"1353235917-13059-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 3/6] completion: simplify tests using test_completion_long()","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-18T10:51:54Z","receivedAt":"2012-11-18T10:51:54Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"No need to duplicate that functionality.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n t/t9902-completion.sh | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex f4c7342..6a250ad 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -172,7 +172,7 @@ test_expect_success 'basic' '\n '\n \n test_expect_success 'double dash \"git\" itself' '\n-\tsed -e \"s/Z$//\" >expected <<-\\EOF &&\n+\ttest_completion_long \"git --\" <<-\\EOF\n \t--paginate Z\n \t--no-pager Z\n \t--git-dir=\n@@ -187,11 +187,10 @@ test_expect_success 'double dash \"git\" itself' '\n \t--no-replace-objects Z\n \t--help Z\n \tEOF\n-\ttest_completion \"git --\"\n '\n \n test_expect_success 'double dash \"git checkout\"' '\n-\tsed -e \"s/Z$//\" >expected <<-\\EOF &&\n+\ttest_completion_long \"git checkout --\" <<-\\EOF\n \t--quiet Z\n \t--ours Z\n \t--theirs Z\n@@ -202,17 +201,15 @@ test_expect_success 'double dash \"git checkout\"' '\n \t--orphan Z\n \t--patch Z\n \tEOF\n-\ttest_completion \"git checkout --\"\n '\n \n test_expect_success 'general options' '\n \ttest_completion \"git --ver\" \"--version \" &&\n \ttest_completion \"git --hel\" \"--help \" &&\n-\tsed -e \"s/Z$//\" >expected <<-\\EOF &&\n+\ttest_completion_long \"git --exe\" <<-\\EOF &&\n \t--exec-path Z\n \t--exec-path=\n \tEOF\n-\ttest_completion \"git --exe\" &&\n \ttest_completion \"git --htm\" \"--html-path \" &&\n \ttest_completion \"git --pag\" \"--paginate \" &&\n \ttest_completion \"git --no-p\" \"--no-pager \" &&\n-- \n1.8.0\n"},{"id":"203470","messageId":"1353235917-13059-5-git-send-email-felipe.contreras@gmail.com","threadId":"32139","inReplyTo":"1353235917-13059-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 4/6] completion: consolidate test_completion*() tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-18T10:51:55Z","receivedAt":"2012-11-18T10:51:55Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"No need to have two versions; if a second argument is specified, use\nthat, otherwise use stdin.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n t/t9902-completion.sh | 30 +++++++++++++-----------------\n 1 file changed, 13 insertions(+), 17 deletions(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex 6a250ad..90a9a91 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -60,19 +60,15 @@ run_completion ()\n # 2: expected completion\n test_completion ()\n {\n-\ttest $# -gt 1 && echo \"$2\" > expected\n+\tif [ $# -gt 1 ]; then\n+\t\techo \"$2\" > expected\n+\telse\n+\t\tsed -e 's/Z$//' > expected\n+\tfi &&\n \trun_completion \"$1\" &&\n \ttest_cmp expected out\n }\n \n-# Like test_completion, but reads expectation from stdin,\n-# which is convenient when it is multiline.\n-test_completion_long ()\n-{\n-\tsed -e 's/Z$//' > expected &&\n-\ttest_completion \"$1\"\n-}\n-\n newline=$'\\n'\n \n test_expect_success '__gitcomp - trailing space - options' '\n@@ -172,7 +168,7 @@ test_expect_success 'basic' '\n '\n \n test_expect_success 'double dash \"git\" itself' '\n-\ttest_completion_long \"git --\" <<-\\EOF\n+\ttest_completion \"git --\" <<-\\EOF\n \t--paginate Z\n \t--no-pager Z\n \t--git-dir=\n@@ -190,7 +186,7 @@ test_expect_success 'double dash \"git\" itself' '\n '\n \n test_expect_success 'double dash \"git checkout\"' '\n-\ttest_completion_long \"git checkout --\" <<-\\EOF\n+\ttest_completion \"git checkout --\" <<-\\EOF\n \t--quiet Z\n \t--ours Z\n \t--theirs Z\n@@ -206,7 +202,7 @@ test_expect_success 'double dash \"git checkout\"' '\n test_expect_success 'general options' '\n \ttest_completion \"git --ver\" \"--version \" &&\n \ttest_completion \"git --hel\" \"--help \" &&\n-\ttest_completion_long \"git --exe\" <<-\\EOF &&\n+\ttest_completion \"git --exe\" <<-\\EOF &&\n \t--exec-path Z\n \t--exec-path=\n \tEOF\n@@ -247,7 +243,7 @@ test_expect_success 'setup for ref completion' '\n '\n \n test_expect_success 'checkout completes ref names' '\n-\ttest_completion_long \"git checkout m\" <<-\\EOF\n+\ttest_completion \"git checkout m\" <<-\\EOF\n \tmaster Z\n \tmybranch Z\n \tmytag Z\n@@ -255,7 +251,7 @@ test_expect_success 'checkout completes ref names' '\n '\n \n test_expect_success 'show completes all refs' '\n-\ttest_completion_long \"git show m\" <<-\\EOF\n+\ttest_completion \"git show m\" <<-\\EOF\n \tmaster Z\n \tmybranch Z\n \tmytag Z\n@@ -263,7 +259,7 @@ test_expect_success 'show completes all refs' '\n '\n \n test_expect_success '<ref>: completes paths' '\n-\ttest_completion_long \"git show mytag:f\" <<-\\EOF\n+\ttest_completion \"git show mytag:f\" <<-\\EOF\n \tfile1 Z\n \tfile2 Z\n \tEOF\n@@ -273,7 +269,7 @@ test_expect_success 'complete tree filename with spaces' '\n \techo content >\"name with spaces\" &&\n \tgit add . &&\n \tgit commit -m spaces &&\n-\ttest_completion_long \"git show HEAD:nam\" <<-\\EOF\n+\ttest_completion \"git show HEAD:nam\" <<-\\EOF\n \tname with spaces Z\n \tEOF\n '\n@@ -282,7 +278,7 @@ test_expect_failure 'complete tree filename with metacharacters' '\n \techo content >\"name with \\${meta}\" &&\n \tgit add . &&\n \tgit commit -m meta &&\n-\ttest_completion_long \"git show HEAD:nam\" <<-\\EOF\n+\ttest_completion \"git show HEAD:nam\" <<-\\EOF\n \tname with ${meta} Z\n \tname with spaces Z\n \tEOF\n-- \n1.8.0\n"},{"id":"203471","messageId":"1353235917-13059-6-git-send-email-felipe.contreras@gmail.com","threadId":"32139","inReplyTo":"1353235917-13059-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 5/6] completion: refactor __gitcomp related tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-18T10:51:56Z","receivedAt":"2012-11-18T10:51:56Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Lots of duplicated code removed!\n\nNo functional changes.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n t/t9902-completion.sh | 76 ++++++++++++++++++---------------------------------\n 1 file changed, 27 insertions(+), 49 deletions(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex 90a9a91..fba632f 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -71,87 +71,65 @@ test_completion ()\n \n newline=$'\\n'\n \n-test_expect_success '__gitcomp - trailing space - options' '\n-\tsed -e \"s/Z$//\" >expected <<-\\EOF &&\n-\t--reuse-message=Z\n-\t--reedit-message=Z\n-\t--reset-author Z\n-\tEOF\n+# Test __gitcomp\n+# Arguments are:\n+# 1: current word (cur)\n+# -: the rest are passed to __gitcomp\n+test_gitcomp ()\n+{\n+\tsed -e 's/Z$//' > expected &&\n \t(\n \t\tlocal -a COMPREPLY &&\n-\t\tcur=\"--re\" &&\n-\t\t__gitcomp \"--dry-run --reuse-message= --reedit-message=\n-\t\t\t\t--reset-author\" &&\n+\t\tcur=\"$1\" &&\n+\t\tshift &&\n+\t\t__gitcomp \"$@\" &&\n \t\tIFS=\"$newline\" &&\n \t\techo \"${COMPREPLY[*]}\" > out\n \t) &&\n \ttest_cmp expected out\n+}\n+\n+test_expect_success '__gitcomp - trailing space - options' '\n+\ttest_gitcomp \"--re\" \"--dry-run --reuse-message= --reedit-message=\n+\t\t--reset-author\" <<-EOF\n+\t--reuse-message=Z\n+\t--reedit-message=Z\n+\t--reset-author Z\n+\tEOF\n '\n \n test_expect_success '__gitcomp - trailing space - config keys' '\n-\tsed -e \"s/Z$//\" >expected <<-\\EOF &&\n+\ttest_gitcomp \"br\" \"branch. branch.autosetupmerge\n+\t\tbranch.autosetuprebase browser.\" <<-\\EOF\n \tbranch.Z\n \tbranch.autosetupmerge Z\n \tbranch.autosetuprebase Z\n \tbrowser.Z\n \tEOF\n-\t(\n-\t\tlocal -a COMPREPLY &&\n-\t\tcur=\"br\" &&\n-\t\t__gitcomp \"branch. branch.autosetupmerge\n-\t\t\t\tbranch.autosetuprebase browser.\" &&\n-\t\tIFS=\"$newline\" &&\n-\t\techo \"${COMPREPLY[*]}\" > out\n-\t) &&\n-\ttest_cmp expected out\n '\n \n test_expect_success '__gitcomp - option parameter' '\n-\tsed -e \"s/Z$//\" >expected <<-\\EOF &&\n+\ttest_gitcomp \"--strategy=re\" \"octopus ours recursive resolve subtree\" \\\n+\t\t\"\" \"re\" <<-\\EOF\n \trecursive Z\n \tresolve Z\n \tEOF\n-\t(\n-\t\tlocal -a COMPREPLY &&\n-\t\tcur=\"--strategy=re\" &&\n-\t\t__gitcomp \"octopus ours recursive resolve subtree\n-\t\t\t\" \"\" \"re\" &&\n-\t\tIFS=\"$newline\" &&\n-\t\techo \"${COMPREPLY[*]}\" > out\n-\t) &&\n-\ttest_cmp expected out\n '\n \n test_expect_success '__gitcomp - prefix' '\n-\tsed -e \"s/Z$//\" >expected <<-\\EOF &&\n+\ttest_gitcomp \"branch.me\" \"remote merge mergeoptions rebase\" \\\n+\t\t\"branch.maint.\" \"me\" <<-\\EOF\n \tbranch.maint.merge Z\n \tbranch.maint.mergeoptions Z\n \tEOF\n-\t(\n-\t\tlocal -a COMPREPLY &&\n-\t\tcur=\"branch.me\" &&\n-\t\t__gitcomp \"remote merge mergeoptions rebase\n-\t\t\t\" \"branch.maint.\" \"me\" &&\n-\t\tIFS=\"$newline\" &&\n-\t\techo \"${COMPREPLY[*]}\" > out\n-\t) &&\n-\ttest_cmp expected out\n '\n \n test_expect_success '__gitcomp - suffix' '\n-\tsed -e \"s/Z$//\" >expected <<-\\EOF &&\n+\ttest_gitcomp \"branch.me\" \"master maint next pu\" \"branch.\" \\\n+\t\t\"ma\" \".\" <<-\\EOF\n \tbranch.master.Z\n \tbranch.maint.Z\n \tEOF\n-\t(\n-\t\tlocal -a COMPREPLY &&\n-\t\tcur=\"branch.me\" &&\n-\t\t__gitcomp \"master maint next pu\n-\t\t\t\" \"branch.\" \"ma\" \".\" &&\n-\t\tIFS=\"$newline\" &&\n-\t\techo \"${COMPREPLY[*]}\" > out\n-\t) &&\n-\ttest_cmp expected out\n '\n \n test_expect_success 'basic' '\n-- \n1.8.0\n"},{"id":"203472","messageId":"1353235917-13059-7-git-send-email-felipe.contreras@gmail.com","threadId":"32139","inReplyTo":"1353235917-13059-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 6/6] completion: simplify __gitcomp() test helper","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-18T10:51:57Z","receivedAt":"2012-11-18T10:51:57Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"By using print_comp as suggested by SZEDER Gábor.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n t/t9902-completion.sh | 15 +++++----------\n 1 file changed, 5 insertions(+), 10 deletions(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex fba632f..42db3da 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -69,23 +69,18 @@ test_completion ()\n \ttest_cmp expected out\n }\n \n-newline=$'\\n'\n-\n # Test __gitcomp\n # Arguments are:\n # 1: current word (cur)\n # -: the rest are passed to __gitcomp\n test_gitcomp ()\n {\n+\tlocal -a COMPREPLY &&\n \tsed -e 's/Z$//' > expected &&\n-\t(\n-\t\tlocal -a COMPREPLY &&\n-\t\tcur=\"$1\" &&\n-\t\tshift &&\n-\t\t__gitcomp \"$@\" &&\n-\t\tIFS=\"$newline\" &&\n-\t\techo \"${COMPREPLY[*]}\" > out\n-\t) &&\n+\tcur=\"$1\" &&\n+\tshift &&\n+\t__gitcomp \"$@\" &&\n+\tprint_comp &&\n \ttest_cmp expected out\n }\n \n-- \n1.8.0\n"},{"id":"203512","messageId":"7v6251xrfb.fsf@alter.siamese.dyndns.org","threadId":"32139","inReplyTo":"1353235917-13059-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH v3 0/6] completion: test consolidations","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-11-19T20:34:48Z","receivedAt":"2012-11-19T20:34:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras <felipe.contreras@gmail.com> writes:\n\n> These started from a discussion with SZEDER, but then I realized there were\n> many improvements possible.\n\nThanks; I'd loop him in and wait for his acks/reviews.\n\n>\n> Changes since v2:\n>\n>  * Updated comments and commit messages\n>\n> Changes since v1:\n>\n>  * A lot more cleanups\n>\n> Felipe Contreras (6):\n>   completion: add comment for test_completion()\n>   completion: standardize final space marker in tests\n>   completion: simplify tests using test_completion_long()\n>   completion: consolidate test_completion*() tests\n>   completion: refactor __gitcomp related tests\n>   completion: simplify __gitcomp() test helper\n>\n>  t/t9902-completion.sh | 133 +++++++++++++++++++-------------------------------\n>  1 file changed, 51 insertions(+), 82 deletions(-)\n"},{"id":"203521","messageId":"CAMP44s2=Tk0Yc9sNBP_wAzfGjdA+N429Xtexb2qK7kB0wJi1OA@mail.gmail.com","threadId":"32139","inReplyTo":"7v6251xrfb.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH v3 0/6] completion: test consolidations","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-19T22:58:13Z","receivedAt":"2012-11-19T22:58:13Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Mon, Nov 19, 2012 at 9:34 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Felipe Contreras <felipe.contreras@gmail.com> writes:\n>\n>> These started from a discussion with SZEDER, but then I realized there were\n>> many improvements possible.\n>\n> Thanks; I'd loop him in and wait for his acks/reviews.\n\nI thought my series-cc-cmd would add him. Maybe I'm using a version of\n'git send-email' that doesn't have that.\n\nEither way, we already know what he will say, to the previous series\nhe said he was against consolidation of test scripts. So I don't see\nhow the situation would change.\n\nCheers.\n\n-- \nFelipe Contreras\n"}]}