{"thread":{"id":"32062","subject":"Reviews on mailing-list","startedAt":"2012-11-10T23:19:21Z","lastAt":"2012-11-13T13:38:49Z","messageCount":17,"participants":["Deniz Türkoglu","Felipe Contreras","Thiago Farina","Junio C Hamano","Ramkumar Ramachandra","suvayu ali","Nguyen Thai Ngoc Duy","Krzysztof Mazur","David Lang"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"202790","messageId":"CA+ZXwZOnZZyk_KWmLLLNChWb1R_Av1s5jM4PsLFWKaG8BB+uXQ@mail.gmail.com","threadId":"32062","inReplyTo":null,"subject":"Reviews on mailing-list","fromName":"Deniz Türkoglu","fromEmail":"deniz@spotify.com","sentAt":"2012-11-10T23:19:21Z","receivedAt":"2012-11-10T23:19:21Z","isPatch":false,"sender":{"key":"deniz@spotify.com","avatar":"https://gravatar.com/avatar/f952d239a4e039dea3acabdc83539a4025886b4104f0274bd7e2ac2c738406f6?d=mp&s=160"},"body":"Hi all,\n\nThis is my first mail to the git mailing list. I have been following\nthe list for some time now and I would like to suggest moving the\nreviews out of the mailing list, for example to a gerrit instance, I\nbelieve it would improve the commits and the mailing list. I have a\nfilter on 'PATCH', but I feel I miss some of the discussion, and\nthings that I would be interested in.\n\nI have spoken to Shawn Pearce (gerrit project lead, google) and he\nsaid he is OK with hosting the gerrit instance.\n\nI would like to hear your thoughts on this.\n\ncheers,\n-deniz\n"},{"id":"202791","messageId":"CAMP44s2AvaAs-dn_eoSFWoLHBQk5QrrV=zYTOpRi2nEywoua4w@mail.gmail.com","threadId":"32062","inReplyTo":"CA+ZXwZOnZZyk_KWmLLLNChWb1R_Av1s5jM4PsLFWKaG8BB+uXQ@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-10T23:40:09Z","receivedAt":"2012-11-10T23:40:09Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote:\n\n> This is my first mail to the git mailing list. I have been following\n> the list for some time now and I would like to suggest moving the\n> reviews out of the mailing list, for example to a gerrit instance, I\n> believe it would improve the commits and the mailing list. I have a\n> filter on 'PATCH', but I feel I miss some of the discussion, and\n> things that I would be interested in.\n>\n> I have spoken to Shawn Pearce (gerrit project lead, google) and he\n> said he is OK with hosting the gerrit instance.\n>\n> I would like to hear your thoughts on this.\n\nPersonally I think reviews on the mailing list is far superior than\nany other review methods. I've even blogged about it and all the\nreasons[1]. Gerrit is better than bugzilla, but it still requires a\nweb browser, and logging in.\n\nI love to be able to just hit 'reply' with my favorite MUA, comment\ninline, and hit send.\n\nCheers.\n\n[1] http://felipec.wordpress.com/2010/01/19/why-bugzilla-sucks-for-handling-patches/\n\n-- \nFelipe Contreras\n"},{"id":"202796","messageId":"CACnwZYekU0CYnqQT8L2siJbUsn=T9qowgth94TWc8KN472Ziag@mail.gmail.com","threadId":"32062","inReplyTo":"CAMP44s2AvaAs-dn_eoSFWoLHBQk5QrrV=zYTOpRi2nEywoua4w@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2012-11-11T01:13:35Z","receivedAt":"2012-11-11T01:13:35Z","isPatch":false,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras\n wrote:\n> On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote:\n>\n>> This is my first mail to the git mailing list. I have been following\n>> the list for some time now and I would like to suggest moving the\n>> reviews out of the mailing list, for example to a gerrit instance, I\n>> believe it would improve the commits and the mailing list. I have a\n>> filter on 'PATCH', but I feel I miss some of the discussion, and\n>> things that I would be interested in.\n>>\n>> I have spoken to Shawn Pearce (gerrit project lead, google) and he\n>> said he is OK with hosting the gerrit instance.\n>>\n>> I would like to hear your thoughts on this.\n>\n> Personally I think reviews on the mailing list is far superior than\n> any other review methods. I've even blogged about it and all the\n> reasons[1]. Gerrit is better than bugzilla, but it still requires a\n> web browser, and logging in.\n>\nRequiring a web browser is a huge requirement, ham?? How come that can\nbe an impediment to move forward way of this awkward way of reviewing\npatches through email? Switching to Gerrit would mean everyone would\nbe using the same tool instead of anyone using its own email client\n(gmail, mutt, thunderbird, whatever...) and having to figure out git\nformat-patch, git send-email (--reply-to where?).\n\nThere are a lot of issues of having to use email for reviewing patches\nthat I think Gerrit is a superior alternative.\n\nAnd many people are arguing for it!\n\nLet's move on...\n"},{"id":"202797","messageId":"CA+ZXwZO8tpGi7_njbFx6w2ZAWoySVb2Bcc+DSupLenKrNAGV_A@mail.gmail.com","threadId":"32062","inReplyTo":"CAMP44s2AvaAs-dn_eoSFWoLHBQk5QrrV=zYTOpRi2nEywoua4w@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Deniz Türkoglu","fromEmail":"deniz@spotify.com","sentAt":"2012-11-11T01:28:11Z","receivedAt":"2012-11-11T01:28:11Z","isPatch":false,"sender":{"key":"deniz@spotify.com","avatar":"https://gravatar.com/avatar/f952d239a4e039dea3acabdc83539a4025886b4104f0274bd7e2ac2c738406f6?d=mp&s=160"},"body":"On Sat, Nov 10, 2012 at 3:40 PM, Felipe Contreras\n wrote:\n> On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote:\n>\n>> This is my first mail to the git mailing list. I have been following\n>> the list for some time now and I would like to suggest moving the\n>> reviews out of the mailing list, for example to a gerrit instance, I\n>> believe it would improve the commits and the mailing list. I have a\n>> filter on 'PATCH', but I feel I miss some of the discussion, and\n>> things that I would be interested in.\n>>\n>> I have spoken to Shawn Pearce (gerrit project lead, google) and he\n>> said he is OK with hosting the gerrit instance.\n>>\n>> I would like to hear your thoughts on this.\n>\n> Personally I think reviews on the mailing list is far superior than\n> any other review methods. I've even blogged about it and all the\n> reasons[1]. Gerrit is better than bugzilla, but it still requires a\n> web browser, and logging in.\n\nI disagree that the current approach is optimal. Bugzilla is a\nbug-tracker and is not meant to be used for reviews. I believe in\nusing the right tool for the right job. An e-mail should be concise\nand to the point, in this case only contain the discussion. This will\nhelp it to reach a wider audience and be more useful when people\nstumble upon it through a google search.\n\ncheers,\n-deniz\n"},{"id":"202800","messageId":"565469f2-0aee-442a-b038-57e11112a8c7@email.android.com","threadId":"32062","inReplyTo":"CACnwZYekU0CYnqQT8L2siJbUsn=T9qowgth94TWc8KN472Ziag@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-11-11T05:54:33Z","receivedAt":"2012-11-11T05:54:33Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\n\nThiago Farina wrote:\n\n>Requiring a web browser is a huge requirement, ham??\n\nNo, but requiring reviews and discussions typed in the browser is.\n\nPardon terseness, typo and HTML from a tablet.\n"},{"id":"202802","messageId":"CALkWK0mpzc8jXs5=HhO0Bk78UgwKt+JGOThB6z_4AnEYmz_=+w@mail.gmail.com","threadId":"32062","inReplyTo":"CA+ZXwZOnZZyk_KWmLLLNChWb1R_Av1s5jM4PsLFWKaG8BB+uXQ@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2012-11-11T07:26:48Z","receivedAt":"2012-11-11T07:26:48Z","isPatch":false,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Deniz Türkoglu wrote:\n> I have spoken to Shawn Pearce (gerrit project lead, google) and he\n> said he is OK with hosting the gerrit instance.\n>\n> I would like to hear your thoughts on this.\n\nI personally think email is by far the best interface for patches,\nreviews, and discussions. Git patches are very high-volume, and not\neveryone can read everything. People should have the flexibility to\nchoose the client they'd like to use to read patches and follow-ups;\nthe freedom to use a scriptable client like Gnus is very important to\nme. Primarily, I want people to be able to:\n1. Choose what to read, by scripting Gnus to score email that they'd\nlikely find relevant.\n2. Try out new patches on the list, by assigning one keybinding to\ngit-am a series.\n3. Display email the way they like. Many email clients have features\nto run filters through emails.\n4. Read patches/ follow-ups offline, while travelling (on a phone, for\ninstance). The GMail app, for instance, downloads mails for offline\nviewing.\n5. Interact with other lists seamlessly (the kernel list, for\ninstance). Email is a universal interface on which lists can be CC'ed\neasily.\n\nI'm not attacking a specific web interface, but I don't see how any of\nthe following would be possible even with the most advanced web\ninterface. Besides, nobody has made a proper case for using one.\nTherefore, I'm strongly opposed to the move.\n\nRam\n"},{"id":"202813","messageId":"CAMXnza0xcH0M53BEaEyvEnShz5fGLjOtgxmTC9YMGtBsR8ratw@mail.gmail.com","threadId":"32062","inReplyTo":"CACnwZYekU0CYnqQT8L2siJbUsn=T9qowgth94TWc8KN472Ziag@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"suvayu ali","fromEmail":"fatkasuvayu+linux@gmail.com","sentAt":"2012-11-11T11:11:42Z","receivedAt":"2012-11-11T11:11:42Z","isPatch":false,"sender":{"key":"fatkasuvayu+linux@gmail.com","avatar":"https://gravatar.com/avatar/f1adf659f41e5846ddf6ab73bb474a3d9c29ac8ff8fa32adbf5796fc945096d0?d=mp&s=160"},"body":"Hi,\n\nOn Sun, Nov 11, 2012 at 2:13 AM, Thiago Farina wrote:\n> On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras\n> wrote:\n>> On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote:\n>>\n>>> This is my first mail to the git mailing list. I have been following\n>>> the list for some time now and I would like to suggest moving the\n>>> reviews out of the mailing list, for example to a gerrit instance, I\n>>> believe it would improve the commits and the mailing list. I have a\n>>> filter on 'PATCH', but I feel I miss some of the discussion, and\n>>> things that I would be interested in.\n>>>\n>>> I have spoken to Shawn Pearce (gerrit project lead, google) and he\n>>> said he is OK with hosting the gerrit instance.\n>>>\n>>> I would like to hear your thoughts on this.\n>>\n>> Personally I think reviews on the mailing list is far superior than\n>> any other review methods. I've even blogged about it and all the\n>> reasons[1]. Gerrit is better than bugzilla, but it still requires a\n>> web browser, and logging in.\n>>\n> Requiring a web browser is a huge requirement, ham?? How come that can\n> be an impediment to move forward way of this awkward way of reviewing\n> patches through email? Switching to Gerrit would mean everyone would\n> be using the same tool instead of anyone using its own email client\n> (gmail, mutt, thunderbird, whatever...) and having to figure out git\n> format-patch, git send-email (--reply-to where?).\n>\n> There are a lot of issues of having to use email for reviewing patches\n> that I think Gerrit is a superior alternative.\n>\n> And many people are arguing for it!\n>\n> Let's move on...\n\n\nI'm just a user, I found this discussion intriguing and was wondering if\nany of you have heard of patchwork server[1]. It is a patch aggregator\nfor mailing lists and provides a convenient bug tracker like web\ninterface without getting in the way of the workflow of reviewing\npatches on the mailing list. If you are interested the Org mode\ncommunity (an Emacs library) uses it. You can take a look here:\n\n \n\nI just thought this might be a nice middle ground for people.\n\nCheers,\n\n\nFootnotes:\n\n[1] \n\n\n--\nSuvayu\n\nOpen source is the future. It sets us free.\n"},{"id":"202818","messageId":"CACsJy8CDCgea+GVU6qVojEBqsZafZAk90hBMrMzo02T5fmd-tg@mail.gmail.com","threadId":"32062","inReplyTo":"CAMXnza0xcH0M53BEaEyvEnShz5fGLjOtgxmTC9YMGtBsR8ratw@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-11-11T12:02:30Z","receivedAt":"2012-11-11T12:02:30Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Sun, Nov 11, 2012 at 6:11 PM, suvayu ali wrote:\n> I'm just a user, I found this discussion intriguing and was wondering if\n> any of you have heard of patchwork server[1]. It is a patch aggregator\n> for mailing lists and provides a convenient bug tracker like web\n> interface without getting in the way of the workflow of reviewing\n> patches on the mailing list. If you are interested the Org mode\n> community (an Emacs library) uses it. You can take a look here:\n>\n> \n>\n> I just thought this might be a nice middle ground for people.\n\nIt's been brought up several times [1] before. And Shawn wanted to do\nsomething about this too [2]. I don't monitor gerrit so I don't know\nif it has become true.\n\n[1] http://search.gmane.org/search.php?group=gmane.comp.version-control.git&query=patchwork\n[2] http://thread.gmane.org/gmane.comp.version-control.git/102887/focus=102901\n-- \nDuy\n"},{"id":"202820","messageId":"CAMP44s2P-nhAGgj9nuJ3cKqb6+enAthwiUNS8QTZn8MP1poJ2g@mail.gmail.com","threadId":"32062","inReplyTo":"CACnwZYekU0CYnqQT8L2siJbUsn=T9qowgth94TWc8KN472Ziag@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-11T12:14:43Z","receivedAt":"2012-11-11T12:14:43Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, Nov 11, 2012 at 2:13 AM, Thiago Farina wrote:\n> On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras\n\n>> Personally I think reviews on the mailing list is far superior than\n>> any other review methods. I've even blogged about it and all the\n>> reasons[1]. Gerrit is better than bugzilla, but it still requires a\n>> web browser, and logging in.\n>>\n> Requiring a web browser is a huge requirement, ham??\n\nYes. Today people can use any mail interface: web, console-based,\ngraphical. They can use Gmail clients in their phone, or IMAP, or\nwhatever.\n\nRequiring everyone to use a web browser would limit the amount of ways\npeople can review patches. Also, not everyone has javascript enabled\nin their browser (I assume Gerrit needs that).\n\n> How come that can\n> be an impediment to move forward way of this awkward way of reviewing\n> patches through email?\n\nIt's not awkward, it's the most sensible way.\n\nYou just replied to my mail the same way I would reply to a patch.\n\n> Switching to Gerrit would mean everyone would\n> be using the same tool instead of anyone using its own email client\n> (gmail, mutt, thunderbird, whatever...)\n\nYes, that's bad.\n\n> and having to figure out git\n> format-patch, git send-email (--reply-to where?).\n\nNo need to figure anything.\n\n% git config sendemail.to git@vger.kernel.org\n% git send-email @{upstream}..\n\nDone.\n\n> There are a lot of issues of having to use email for reviewing patches\n> that I think Gerrit is a superior alternative.\n\nThere are no issues. It works for Linux, qemu, libav, ffmpeg, git, and\nmany other projects.\n\n> And many people are arguing for it!\n\nNope, they are not.\n\n-- \nFelipe Contreras\n"},{"id":"202821","messageId":"CAMP44s2GF03sKDA141d_5zY0tTDpBKqyb1hqoBmBJBbod-FL7w@mail.gmail.com","threadId":"32062","inReplyTo":"CA+ZXwZO8tpGi7_njbFx6w2ZAWoySVb2Bcc+DSupLenKrNAGV_A@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-11T12:24:14Z","receivedAt":"2012-11-11T12:24:14Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, Nov 11, 2012 at 2:28 AM, Deniz Türkoglu wrote:\n> On Sat, Nov 10, 2012 at 3:40 PM, Felipe Contreras\n> wrote:\n>> On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote:\n>>\n>>> This is my first mail to the git mailing list. I have been following\n>>> the list for some time now and I would like to suggest moving the\n>>> reviews out of the mailing list, for example to a gerrit instance, I\n>>> believe it would improve the commits and the mailing list. I have a\n>>> filter on 'PATCH', but I feel I miss some of the discussion, and\n>>> things that I would be interested in.\n>>>\n>>> I have spoken to Shawn Pearce (gerrit project lead, google) and he\n>>> said he is OK with hosting the gerrit instance.\n>>>\n>>> I would like to hear your thoughts on this.\n>>\n>> Personally I think reviews on the mailing list is far superior than\n>> any other review methods. I've even blogged about it and all the\n>> reasons[1]. Gerrit is better than bugzilla, but it still requires a\n>> web browser, and logging in.\n>\n> I disagree that the current approach is optimal. Bugzilla is a\n> bug-tracker and is not meant to be used for reviews. I believe in\n> using the right tool for the right job. An e-mail should be concise\n> and to the point, in this case only contain the discussion. This will\n> help it to reach a wider audience and be more useful when people\n> stumble upon it through a google search.\n\nI don't understand what you are saying. If you google 'git reviews on\nmailing lit', you will find results like this:\n\nhttp://article.gmane.org/gmane.comp.version-control.git/209313\n\nYou don't get any patches because you didn't search for patches, and\neither way Google would not filter out the results from gerrit either.\nFor example: googing 'cyanogenmod \"Remove tabs from GNexusParts\" will\nthrow:\n\nhttp://review.cyanogenmod.org/\n\n-- \nFelipe Contreras\n"},{"id":"202827","messageId":"CACnwZYfP4=Fvt8T0GOEzjTOaEyYF_Ao6e_f02eqO_5_DyzM0Zw@mail.gmail.com","threadId":"32062","inReplyTo":"CAMP44s2P-nhAGgj9nuJ3cKqb6+enAthwiUNS8QTZn8MP1poJ2g@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2012-11-11T13:09:36Z","receivedAt":"2012-11-11T13:09:36Z","isPatch":false,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras\n wrote:\n> Requiring everyone to use a web browser would limit the amount of ways\n> people can review patches.\nI don't see that as a limitation as I think everyone has access to a\nweb browser these days, don't have?\n\n>> How come that can\n>> be an impediment to move forward way of this awkward way of reviewing\n>> patches through email?\n>\n> It's not awkward, it's the most sensible way.\n>\nThe most harder way I think?\n\nLook at this:\nhttps://gerrit.chromium.org/gerrit/#/q/status:open+project:chromiumos/platform/power_manager,n,z\n\nThere I can go and see many informations that through this mailing\nlist I can't or have to do much more work in order to archive this.\n\nIf you open one of the 'patches' you can see some relevant information:\n- Who is the owner/author\n- Was it verified?\n- Is it ready for landing?\n- If I click on Side-by-side I get a nice diff view interface that\nplan text email does NOT give me.\n- Was it reviewed/approved (+1, +2)?\n- It can be merged by one click.\n- The interface also provide the command line to download/apply the\npatch for me.\n- Isn't there a reason (implicit there) for Google being using tools\nlike Gerrit/CodeReview(rietveld)/Mondrian for handling his code\nreviews rather than solely by 'email'?\n\n> You just replied to my mail the same way I would reply to a patch.\n>\nI replied through a web browser by the Gmail interface. ;)\n\n>> There are a lot of issues of having to use email for reviewing patches\n>> that I think Gerrit is a superior alternative.\n>\n> There are no issues. It works for Linux, qemu, libav, ffmpeg, git, and\n> many other projects.\n>\n>> And many people are arguing for it!\n>\n> Nope, they are not.\n>\nIf they weren't then nobody would be suggesting to use Gerrit for\nhandling the review of git patches.\n\nBut I think the big resistance comes from the fact that the core\ndevelopers handle/review the git patches through Gnus/Emacs, so that\nis enough for them and they don't want to make the switch because of\nthat?\n"},{"id":"202828","messageId":"CAMP44s2s9qL_ytb3vvrh02M0zWXyrE2Mt25bBi4Y_+Ur=5C4TA@mail.gmail.com","threadId":"32062","inReplyTo":"CACnwZYfP4=Fvt8T0GOEzjTOaEyYF_Ao6e_f02eqO_5_DyzM0Zw@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-11T13:40:48Z","receivedAt":"2012-11-11T13:40:48Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, Nov 11, 2012 at 2:09 PM, Thiago Farina wrote:\n> On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras\n> wrote:\n>> Requiring everyone to use a web browser would limit the amount of ways\n>> people can review patches.\n> I don't see that as a limitation as I think everyone has access to a\n> web browser these days, don't have?\n>\n>>> How come that can\n>>> be an impediment to move forward way of this awkward way of reviewing\n>>> patches through email?\n>>\n>> It's not awkward, it's the most sensible way.\n>>\n> The most harder way I think?\n>\n> Look at this:\n> https://gerrit.chromium.org/gerrit/#/q/status:open+project:chromiumos/platform/power_manager,n,z\n>\n> There I can go and see many informations that through this mailing\n> list I can't or have to do much more work in order to archive this.\n\nThat information has nothing to do with reviews. That's patch state-tracking.\n\n> If you open one of the 'patches' you can see some relevant information:\n> - Who is the owner/author\n> - Was it verified?\n> - Is it ready for landing?\n\nIrrelevant for git.\n\n> - If I click on Side-by-side I get a nice diff view interface that\n> plan text email does NOT give me.\n\nNot useful.\n\n> - Was it reviewed/approved (+1, +2)?\n\nYou can see the same in a mail thread.\n\n> - It can be merged by one click.\n\nIrrelevant for git.\n\n> - The interface also provide the command line to download/apply the\n> patch for me.\n\nNot useful.\n\n> - Isn't there a reason (implicit there) for Google being using tools\n> like Gerrit/CodeReview(rietveld)/Mondrian for handling his code\n> reviews rather than solely by 'email'?\n\nWho knows And if there is, who knows if it's valid.\n\nAnd none of those points has anything to do with code *review*.\n\nAll these points are about state-tracking, and that can be implemented\n*on top* of the mailing list, for example through patchwork:\n\nhttp://patchwork.newartisans.com/patch/1531/\n\nThat's if somebody actually cared about that, but that doesn't seem to\nbe the case.\n\n>> You just replied to my mail the same way I would reply to a patch.\n>>\n> I replied through a web browser by the Gmail interface. ;)\n\nIndeed, Gmail is one of the many ways you can review a patch.\n\nYou clik reply, you add the comments in line, and click send. Couldn't\nbe easier.\n\n>>> There are a lot of issues of having to use email for reviewing patches\n>>> that I think Gerrit is a superior alternative.\n>>\n>> There are no issues. It works for Linux, qemu, libav, ffmpeg, git, and\n>> many other projects.\n>>\n>>> And many people are arguing for it!\n>>\n>> Nope, they are not.\n>>\n> If they weren't then nobody would be suggesting to use Gerrit for\n> handling the review of git patches.\n\nExcept you, of course.\n\n> But I think the big resistance comes from the fact that the core\n> developers handle/review the git patches through Gnus/Emacs, so that\n> is enough for them and they don't want to make the switch because of\n> that?\n\ngnus/emacs/notmuch/thunderbird/Gmail, and pretty much every mail\nclient out there.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"202896","messageId":"20121111171451.GA26695@shrek.podlesie.net","threadId":"32062","inReplyTo":"CACnwZYfP4=Fvt8T0GOEzjTOaEyYF_Ao6e_f02eqO_5_DyzM0Zw@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"Krzysztof Mazur","fromEmail":"krzysiek@podlesie.net","sentAt":"2012-11-11T17:14:52Z","receivedAt":"2012-11-11T17:14:52Z","isPatch":false,"sender":{"key":"krzysiek@podlesie.net","avatar":null},"body":"On Sun, Nov 11, 2012 at 11:09:36AM -0200, Thiago Farina wrote:\n> On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras\n> wrote:\n> > Requiring everyone to use a web browser would limit the amount of ways\n> > people can review patches.\n> I don't see that as a limitation as I think everyone has access to a\n> web browser these days, don't have?\n\nAlmost everyone, but not everyone likes using web browser.\n\nWith emails you can use your favorite interface: favorite MUA and in good\nMUA also your favorite editor (program for writing text, not some\neditor-like product in web browser). With web-based system you have only\nONE interface (or few), not chosen by you, you cannot change it, web admin\nmay change it in way you not like.\n\nKrzysiek\n"},{"id":"202923","messageId":"alpine.DEB.2.02.1211111313140.19687@nftneq.ynat.uz","threadId":"32062","inReplyTo":"20121111171451.GA26695@shrek.podlesie.net","subject":"Re: Reviews on mailing-list","fromName":"David Lang","fromEmail":"david@lang.hm","sentAt":"2012-11-11T21:15:08Z","receivedAt":"2012-11-11T21:15:08Z","isPatch":false,"sender":{"key":"david@lang.hm","avatar":null},"body":"On Sun, 11 Nov 2012, Krzysztof Mazur wrote:\n\n> On Sun, Nov 11, 2012 at 11:09:36AM -0200, Thiago Farina wrote:\n>> On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras\n>> wrote:\n>>> Requiring everyone to use a web browser would limit the amount of ways\n>>> people can review patches.\n>> I don't see that as a limitation as I think everyone has access to a\n>> web browser these days, don't have?\n>\n> Almost everyone, but not everyone likes using web browser.\n\nUsing a web browser requires connectivity at the time you are doing the review.\n\nMailing list based reviews can be done at times when you don't have \nconnectivity.\n\nCoincidently, one of the common times when people don't have connectivity is \nwhen they are traveling, and this can be a good time to do things like code \nreview.\n\nDavid Lang\n"},{"id":"202933","messageId":"CA+ZXwZMh=ON4g32nRHD5cMTX1c7ohhqhXHUNdh57BMvSHG0cYA@mail.gmail.com","threadId":"32062","inReplyTo":"alpine.DEB.2.02.1211111313140.19687@nftneq.ynat.uz","subject":"Re: Reviews on mailing-list","fromName":"Deniz Türkoglu","fromEmail":"deniz@spotify.com","sentAt":"2012-11-12T00:35:48Z","receivedAt":"2012-11-12T00:35:48Z","isPatch":false,"sender":{"key":"deniz@spotify.com","avatar":"https://gravatar.com/avatar/f952d239a4e039dea3acabdc83539a4025886b4104f0274bd7e2ac2c738406f6?d=mp&s=160"},"body":"I understand from the feedback that gerrit should get better on making\nit possible to review code via e-mail, as pointed out in Nguyen's\nmail, a flow like Shawn mentioned[1] can be a good solution.\n\nFWIW, I can fetch the change(s) from gerrit I am interested in and\nreview it any time I want. I currently have many checked out topics I\nam working on for instance.\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/102887/focus=102901\n\ncheers,\n-deniz\n"},{"id":"202934","messageId":"alpine.DEB.2.02.1211111642030.19687@nftneq.ynat.uz","threadId":"32062","inReplyTo":"CA+ZXwZMh=ON4g32nRHD5cMTX1c7ohhqhXHUNdh57BMvSHG0cYA@mail.gmail.com","subject":"Re: Reviews on mailing-list","fromName":"David Lang","fromEmail":"david@lang.hm","sentAt":"2012-11-12T00:43:05Z","receivedAt":"2012-11-12T00:43:05Z","isPatch":false,"sender":{"key":"david@lang.hm","avatar":null},"body":"On Sun, 11 Nov 2012, Deniz Türkoglu wrote:\n\n> I understand from the feedback that gerrit should get better on making\n> it possible to review code via e-mail, as pointed out in Nguyen's\n> mail, a flow like Shawn mentioned[1] can be a good solution.\n>\n> FWIW, I can fetch the change(s) from gerrit I am interested in and\n> review it any time I want. I currently have many checked out topics I\n> am working on for instance.\n\nThat requires that you know before you loose connectivity what changes you want \nto review.\n\nWith e-mail based reviews, you just pull copies of all your mail and it includes \nany pending reviews along with everything else.\n\nDavid Lang"},{"id":"203075","messageId":"CACsJy8Dh6h8gXDjYuBELOOj5HcYfEuW8pCFuhwsuovpU9u3puA@mail.gmail.com","threadId":"32062","inReplyTo":"alpine.DEB.2.02.1211111313140.19687@nftneq.ynat.uz","subject":"Re: Reviews on mailing-list","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-11-13T13:38:49Z","receivedAt":"2012-11-13T13:38:49Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Mon, Nov 12, 2012 at 4:15 AM, David Lang wrote:\n> Using a web browser requires connectivity at the time you are doing the\n> review.\n>\n> Mailing list based reviews can be done at times when you don't have\n> connectivity.\n\nI am not against email-based reviews but I'd like to point out that\nwith Google Gears (and HTML5 Storage?) Gerrit can be made work offline\ntoo. I don't know how much work required though.\n-- \nDuy\n"}]}