{"thread":{"id":"3206","subject":"[Announce] gitview-0.1","startedAt":"2006-02-01T04:16:59Z","lastAt":"2006-02-01T21:02:04Z","messageCount":9,"participants":["Aneesh Kumar","Dave Jones","Junio C Hamano","Linus Torvalds","Alex Riesen","Fernando J. Pereda"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"15365","messageId":"cc723f590601312016vabba201ye6d3739b3927f1a@mail.gmail.com","threadId":"3206","inReplyTo":null,"subject":"[Announce] gitview-0.1","fromName":"Aneesh Kumar","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-02-01T04:16:59Z","receivedAt":"2006-02-01T04:16:59Z","isPatch":false,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"Hi,\n\nGnome based git repository browser. The code is derived from bazaar-ng\nrepository browser.\n\nTo see how it looks\n\nhttp://www.flickr.com/photos/17388011@N00/92918446/\n\nI don't have a web location where i can host it so i am attaching it below.\nIt would be great if we can get it added to git repository\n\nsample usage\ntakes same argument as git rev-list\n\ngitview --since=2.week.ago\n\n-aneesh\n"},{"id":"15366","messageId":"20060201042930.GV16557@redhat.com","threadId":"3206","inReplyTo":"cc723f590601312016vabba201ye6d3739b3927f1a@mail.gmail.com","subject":"Re: [Announce] gitview-0.1","fromName":"Dave Jones","fromEmail":"davej@redhat.com","sentAt":"2006-02-01T04:29:30Z","receivedAt":"2006-02-01T04:29:30Z","isPatch":false,"sender":{"key":"davej@redhat.com","avatar":null},"body":"On Wed, Feb 01, 2006 at 09:46:59AM +0530, Aneesh Kumar wrote:\n\n > I don't have a web location where i can host it so i am attaching it below.\n > It would be great if we can get it added to git repository\n > \n > sample usage\n > takes same argument as git rev-list\n > \n > gitview --since=2.week.ago\n\nNice, here's your first patch against it :-)\n\nThe one thing I like about gitk over this though is that with gitk\nyou don't have to click a button to see the diff.\nFor casual history browsing, it's much nicer to just scroll the bottom\nwindow. Making it pop up a new window for each diff is just irritating.\n\n\t\tDave\n\n\n--- gitview~\t2006-01-31 23:24:36.000000000 -0500\n+++ gitview\t2006-01-31 23:24:49.000000000 -0500\n@@ -254,7 +254,7 @@ class DiffWindow:\n \tdef __init__(self):\n \t\tself.window = gtk.Window(gtk.WINDOW_TOPLEVEL)\n \t\tself.window.set_border_width(0)\n-\t\tself.window.set_title(\"Git reposotiry browser diff window\")\n+\t\tself.window.set_title(\"Git repository browser diff window\")\n \n \t\t# Use two thirds of the screen by default\n \t\tscreen = self.window.get_screen()\n"},{"id":"15367","messageId":"cc723f590601312041o1dc594c7t69418b735ef29ee@mail.gmail.com","threadId":"3206","inReplyTo":"20060201042930.GV16557@redhat.com","subject":"Re: [Announce] gitview-0.1","fromName":"Aneesh Kumar","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-02-01T04:41:00Z","receivedAt":"2006-02-01T04:41:00Z","isPatch":false,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"On 2/1/06, Dave Jones wrote:\n> On Wed, Feb 01, 2006 at 09:46:59AM +0530, Aneesh Kumar wrote:\n>\n> > I don't have a web location where i can host it so i am attaching it below.\n> > It would be great if we can get it added to git repository\n> >\n> > sample usage\n> > takes same argument as git rev-list\n> >\n> > gitview --since=2.week.ago\n>\n> Nice, here's your first patch against it :-)\n>\n> The one thing I like about gitk over this though is that with gitk\n> you don't have to click a button to see the diff.\n> For casual history browsing, it's much nicer to just scroll the bottom\n> window. Making it pop up a new window for each diff is just irritating.\n>\n\nI always browse the repository looking at the commit message and only\nif interested i look at the changes. That's why i made it look that\nway.\n\n-aneesh\n"},{"id":"15383","messageId":"cc723f590602010328w7b4a7befr40a76620e197d00c@mail.gmail.com","threadId":"3206","inReplyTo":"cc723f590601312041o1dc594c7t69418b735ef29ee@mail.gmail.com","subject":"Re: [Announce] gitview-0.1","fromName":"Aneesh Kumar","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-02-01T11:28:32Z","receivedAt":"2006-02-01T11:28:32Z","isPatch":false,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"On 2/1/06, Aneesh Kumar wrote:\n> On 2/1/06, Dave Jones wrote:\n\n[..snip...]\n\n> >\n> > The one thing I like about gitk over this though is that with gitk\n> > you don't have to click a button to see the diff.\n> > For casual history browsing, it's much nicer to just scroll the bottom\n> > window. Making it pop up a new window for each diff is just irritating.\n> >\n>\n> I always browse the repository looking at the commit message and only\n> if interested i look at the changes. That's why i made it look that\n> way.\n\n\nwith gitview (attached) I have added an option --with-diff. That will\nadd the diff details. Now I would like somebody with good git\nknowledge to review the different commands that i am using to get\ninformation out of git For example with --with-diff option i am\ngetting the complete diff by\n\nfor parent_id in parent_sha1 parent_sha2 parent_sha3 .......\ncommit_diff = commit_diff + git diff tree -p parent_id commit_sha1\n\nis this the correct way ?\n\n-aneesh\n"},{"id":"15420","messageId":"7v3bj2df1b.fsf@assigned-by-dhcp.cox.net","threadId":"3206","inReplyTo":"cc723f590602010328w7b4a7befr40a76620e197d00c@mail.gmail.com","subject":"Re: [Announce] gitview-0.1","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-02-01T20:01:36Z","receivedAt":"2006-02-01T20:01:36Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Aneesh Kumar writes:\n\n> for parent_id in parent_sha1 parent_sha2 parent_sha3 .......\n> commit_diff = commit_diff + git diff tree -p parent_id commit_sha1\n>\n> is this the correct way ?\n\nAre parent_sha$N true parents of commit_sha1? If you want to\nget three independent diffs, \"git diff-tree -m -p $commit_sha1\"\nwould give that to you in one go.\n"},{"id":"15421","messageId":"Pine.LNX.4.64.0602011206040.21884@g5.osdl.org","threadId":"3206","inReplyTo":"7v3bj2df1b.fsf@assigned-by-dhcp.cox.net","subject":"Re: [Announce] gitview-0.1","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2006-02-01T20:17:02Z","receivedAt":"2006-02-01T20:17:02Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Wed, 1 Feb 2006, Junio C Hamano wrote:\n> \n> Are parent_sha$N true parents of commit_sha1? If you want to\n> get three independent diffs, \"git diff-tree -m -p $commit_sha1\"\n> would give that to you in one go.\n\nBtw, I think we should change\n\n\tgit-diff-tree --stdin\n\nto look at the rest of the line.\n\nRight now it _only_ takes the commit from that line, along with possibly \nthe first parent if one exists (if one is not listed, the list of parents \nwill be correctly taken from the commit).\n\nWhich makes it mostly useless for merges with a dense history.\n\nEspecially with the new \"-cc\" flag, using it for merges really does make \na lot of sense, but it's not workable.\n\nSo right now, git-whatchanged does\n\n\tgit-rev-list | git-diff-tree --stdin \n\nwhich means that it handles merges in a pruned-down history wrong. Now, \nthat's ok, because it currently never prunes the history of git-rev-list \n(it instead prunes purely in git-diff-tree). So it works right, and can \ntake the -cc flag because it always gets the parent information from the \ncommit.\n\nHOWEVER, currently doing the pruning the other way around, ie\n\n\tgit-rev-list --parents | git-diff-tree --stdin\n\ndoes _not_ work right. It ignores anything but the first parent, because \n\"git-diff-tree --stdin\" doesn't understand merges.\n\nAnd doing the pruning the other way around would actually make sense \nsometimes. Not for git-whatchanged (where doing the pruning in \ngit-diff-tree means that we don't have to parse the history ahead of time, \nso we get immediate feedback), but in a git-annotate context you want to \ndo the pruning ahead-of-time. So git-diff-tree not supporting it is sad ;(\n\n\t\tLinus\n"},{"id":"15425","messageId":"7vzmlaakdc.fsf@assigned-by-dhcp.cox.net","threadId":"3206","inReplyTo":"Pine.LNX.4.64.0602011206040.21884@g5.osdl.org","subject":"Re: [Announce] gitview-0.1","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-02-01T20:34:39Z","receivedAt":"2006-02-01T20:34:39Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Linus Torvalds writes:\n\n> Btw, I think we should change\n>\n> \tgit-diff-tree --stdin\n>\n> to look at the rest of the line.\n\nYes it is one of the \"broken things I am aware of\". It does not\neven show --pretty for the same reason, and I was planning to do\na fake commit objects to handle them (taking the message from\ncommit, locally grafting the parents from the line to it).\n"},{"id":"15428","messageId":"20060201205805.GA6384@steel.home","threadId":"3206","inReplyTo":"cc723f590601312016vabba201ye6d3739b3927f1a@mail.gmail.com","subject":"Re: [Announce] gitview-0.1","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-02-01T20:58:05Z","receivedAt":"2006-02-01T20:58:05Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Aneesh Kumar, Wed, Feb 01, 2006 05:16:59 +0100:\n> \n> Gnome based git repository browser. The code is derived from bazaar-ng\n> repository browser.\n> \n> To see how it looks\n> \n> http://www.flickr.com/photos/17388011@N00/92918446/\n> \n> I don't have a web location where i can host it so i am attaching it below.\n> It would be great if we can get it added to git repository\n> \n> sample usage\n> takes same argument as git rev-list\n> \n> gitview --since=2.week.ago\n> \n\nDoesn't really work here: no tree like on your screenshot, and a lot\nof messages like this:\n\n(gitview:14905): GLib-GObject-WARNING **: IA__g_object_set_property: object clas\ns `PyGtkGenericCellRenderer' has no property named `out-lines'\n\n(gitview:14905): GLib-GObject-WARNING **: IA__g_object_set_property: object clas\ns `PyGtkGenericCellRenderer' has no property named `in-lines'\n\n(gitview:14905): GLib-GObject-WARNING **: IA__g_object_set_property: object clas\ns `PyGtkGenericCellRenderer' has no property named `node'\n\n(gitview:14905): GLib-GObject-WARNING **: IA__g_object_set_property: object clas\ns `PyGtkGenericCellRenderer' has no property named `out-lines'\n\n(gitview:14905): GLib-GObject-WARNING **: IA__g_object_set_property: object clas\ns `PyGtkGenericCellRenderer' has no property named `in-lines'\n\n(gitview:14905): GLib-GObject-WARNING **: IA__g_object_set_property: object clas\ns `PyGtkGenericCellRenderer' has no property named `node'\nTraceback (most recent call last):\n File \"/home/raa/gitview\", line 166, in on_render\n ctx = window.cairo_create()\nAttributeError: 'gtk.gdk.Window' object has no attribute 'cairo_create'\n\nGentoo, Python 2.4.2, pycairo 1.0.2.\n"},{"id":"15429","messageId":"20060201210204.GB15900@ferdyx.org","threadId":"3206","inReplyTo":"20060201205805.GA6384@steel.home","subject":"Re: [Announce] gitview-0.1","fromName":"Fernando J. Pereda","fromEmail":"ferdy@ferdyx.org","sentAt":"2006-02-01T21:02:04Z","receivedAt":"2006-02-01T21:02:04Z","isPatch":false,"sender":{"key":"ferdy@ferdyx.org","avatar":"https://gravatar.com/avatar/96bf7c1ddf7ccd430255bd12d9d42b212dbc033b28c668a2bdf9c3995aa81e61?d=mp&s=160"},"body":"On Wed, Feb 01, 2006 at 09:58:05PM +0100, Alex Riesen wrote:\n| Gentoo, Python 2.4.2, pycairo 1.0.2.\n\nJust upgrade to a newer pygtk and it'll work fine:\n\n[ebuild R ] dev-python/pygtk-2.8.2 -doc +opengl 0 kB\n\nI had the same problem until I installed the above version.\n\nCheers,\nFerdy\n\n-- \nFernando J. Pereda Garcimartín\nGentoo Developer (Alpha,net-mail,mutt,git)\n20BB BDC3 761A 4781 E6ED ED0B 0A48 5B0C 60BD 28D4\n"}]}