{"thread":{"id":"32056","subject":"Do not add an empty value from config credential.helper","startedAt":"2012-11-10T15:08:04Z","lastAt":"2012-11-10T15:08:04Z","messageCount":1,"participants":["乙酸鋰"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"202754","messageId":"CAHtLG6Snuv4x+xvqJRmEo8b8TJRPqBP46kanSsfvhgDWfDbuOg@mail.gmail.com","threadId":"32056","inReplyTo":null,"subject":"Do not add an empty value from config credential.helper","fromName":"乙酸鋰","fromEmail":"ch3cooli@gmail.com","sentAt":"2012-11-10T15:08:04Z","receivedAt":"2012-11-10T15:08:04Z","isPatch":false,"sender":{"key":"ch3cooli@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2804967?v=4"},"body":"Below is current git message when a local config credential.helper has\nan empty value. Please skip an empty value.\n\n$ git push --force origin master\ngit: 'credential-' is not a git command. See 'git --help'.\n\nDid you mean this?\n        credential\nTotal 0 (delta 0), reused 0 (delta 0)\nTo https://user@github.com/user/myrepo.git\n + d23aa6a...3405990 master -> master (forced update)\n\n\nFrom 0b3ec07ed893a0d595cf48c55d884ff844f1108f Mon Sep 17 00:00:00 2001\nFrom: Sup Yut Sum <ch3cooli@gmail.com>\nDate: Sat, 10 Nov 2012 22:24:30 +0800\nSubject: [PATCH] credential: do not recognize a credential helper if config\n value is empty\n\nSigned-off-by: Sup Yut Sum <ch3cooli@gmail.com>\n---\n credential.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/credential.c b/credential.c\nindex e54753c..1489e7a 100644\n--- a/credential.c\n+++ b/credential.c\n@@ -64,7 +64,7 @@ static int credential_config_callback(const char *var, const char *value,\n \t\tkey = dot + 1;\n \t}\n \n-\tif (!strcmp(key, \"helper\"))\n+\tif (!strcmp(key, \"helper\") && *value)\n \t\tstring_list_append(&c->helpers, value);\n \telse if (!strcmp(key, \"username\")) {\n \t\tif (!c->username)\n-- \n1.8.0.msysgit.0\n\n"}]}