{"thread":{"id":"3204","subject":"[PATCH] Use local structs for HTTP slot callback data","startedAt":"2006-02-01T02:00:37Z","lastAt":"2006-02-01T02:00:37Z","messageCount":1,"participants":["Nick Hengeveld"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"15356","messageId":"20060201020037.GG3873@reactrix.com","threadId":"3204","inReplyTo":null,"subject":"[PATCH] Use local structs for HTTP slot callback data","fromName":"Nick Hengeveld","fromEmail":"nickh@reactrix.com","sentAt":"2006-02-01T02:00:37Z","receivedAt":"2006-02-01T02:00:37Z","isPatch":true,"sender":{"key":"nickh@reactrix.com","avatar":null},"body":"There's no need for these structures to be static, and it could potentially\ncause problems down the road.\n\nSigned-off-by: Nick Hengeveld <nickh@reactrix.com>\n\n\n---\n\n http-fetch.c |   10 +++++-----\n 1 files changed, 5 insertions(+), 5 deletions(-)\n\n6146f9e8be9d4bb49b7008af5b99853ee7c0afc1\ndiff --git a/http-fetch.c b/http-fetch.c\nindex 92326f9..97ce13c 100644\n--- a/http-fetch.c\n+++ b/http-fetch.c\n@@ -375,7 +375,7 @@ static int fetch_index(struct alt_base *\n \n \tFILE *indexfile;\n \tstruct active_request_slot *slot;\n-\tstatic struct slot_results results;\n+\tstruct slot_results results;\n \n \tif (has_pack_index(sha1))\n \t\treturn 0;\n@@ -555,7 +555,7 @@ static void fetch_alternates(char *base)\n \tchar *url;\n \tchar *data;\n \tstruct active_request_slot *slot;\n-\tstatic struct alternates_request alt_req;\n+\tstruct alternates_request alt_req;\n \n \t/* If another request has already started fetching alternates,\n \t   wait for them to arrive and return to processing this request's\n@@ -618,7 +618,7 @@ static int fetch_indices(struct alt_base\n \tint i = 0;\n \n \tstruct active_request_slot *slot;\n-\tstatic struct slot_results results;\n+\tstruct slot_results results;\n \n \tif (repo->got_indices)\n \t\treturn 0;\n@@ -699,7 +699,7 @@ static int fetch_pack(struct alt_base *r\n \tstruct curl_slist *range_header = NULL;\n \n \tstruct active_request_slot *slot;\n-\tstatic struct slot_results results;\n+\tstruct slot_results results;\n \n \tif (fetch_indices(repo))\n \t\treturn -1;\n@@ -900,7 +900,7 @@ int fetch_ref(char *ref, unsigned char *\n         struct buffer buffer;\n \tchar *base = alt->base;\n \tstruct active_request_slot *slot;\n-\tstatic struct slot_results results;\n+\tstruct slot_results results;\n         buffer.size = 41;\n         buffer.posn = 0;\n         buffer.buffer = hex;\n-- \n1.1.6.g1417-dirty\n"}]}