{"thread":{"id":"31975","subject":"[PATCH] test-lib: avoid full path to store test results","startedAt":"2012-10-30T04:12:57Z","lastAt":"2012-11-02T15:20:51Z","messageCount":18,"participants":["Felipe Contreras","Jeff King","Jonathan Nieder","Elia Pinto","Stefano Lattarini","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"202160","messageId":"1351570377-894-1-git-send-email-felipe.contreras@gmail.com","threadId":"31975","inReplyTo":null,"subject":"[PATCH] test-lib: avoid full path to store test results","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-10-30T04:12:57Z","receivedAt":"2012-10-30T04:12:57Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"No reason to use the full path in case this is used externally.\n\nSigned-off-by: Felipe Contreras \n---\n t/test-lib.sh | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 514282c..5a3d665 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -389,7 +389,8 @@ test_done () {\n \tthen\n \t\ttest_results_dir=\"$TEST_OUTPUT_DIRECTORY/test-results\"\n \t\tmkdir -p \"$test_results_dir\"\n-\t\ttest_results_path=\"$test_results_dir/${0%.sh}-$$.counts\"\n+\t\tbase=${0##*/}\n+\t\ttest_results_path=\"$test_results_dir/${base%.sh}-$$.counts\"\n \n \t\tcat >>\"$test_results_path\" <<-EOF\n \t\ttotal $test_count\n-- \n1.8.0\n"},{"id":"202161","messageId":"20121030042850.GA23263@sigill.intra.peff.net","threadId":"31975","inReplyTo":"1351570377-894-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-30T04:28:50Z","receivedAt":"2012-10-30T04:28:50Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Oct 30, 2012 at 05:12:57AM +0100, Felipe Contreras wrote:\n\n> No reason to use the full path in case this is used externally.\n\nI think it is not just \"no reason to\", but it is actively wrong to use a\nfull path, as we do not take care to \"mkdir -p\" the intervening path\ncomponents.\n\nHowever, this never comes up in practice, because all of the test\nscripts assume you are running them from the test directory (i.e.,\nthey will fail otherwise because they will not find ./test-lib.sh).\n\nIs this in support of putting remote-hg tests in contrib/? I had\nexpected you to just put\n\n export TEST_DIRECTORY=\"$(pwd)/../../../t\"\n . \"$TEST_DIRECTORY/test-lib.sh\"\n\ninto the test script in contrib/remote-hg/t. I guess you are doing\nsomething like:\n\n cd ../../../t && ../contrib/remote-hg/t/twhatever...\n\nbut the former seems much simpler to invoke (and if the goal is to get\nyour test-results in the right place, setting TEST_OUTPUT_DIRECTORY is\nthe best way to do that).\n\nIf this is part of the remote-hg series, I'd prefer to just see it as\npart of the re-roll. It's much easier to evaluate it in context.\n\nOr are you really just doing:\n\n cd git/t\n $PWD/t0000-basic.sh\n\nI guess there is nothing wrong with that, though there is no reason not\nto use \"./\" instead of $PWD.\n\n-Peff\n"},{"id":"202177","messageId":"CAMP44s2a40Bx2X3QfbtCZFDR71W5puadfpSRQSy9kjbkm_f-sA@mail.gmail.com","threadId":"31975","inReplyTo":"20121030042850.GA23263@sigill.intra.peff.net","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-10-30T04:39:22Z","receivedAt":"2012-10-30T04:39:22Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Tue, Oct 30, 2012 at 5:28 AM, Jeff King wrote:\n> On Tue, Oct 30, 2012 at 05:12:57AM +0100, Felipe Contreras wrote:\n>\n>> No reason to use the full path in case this is used externally.\n>\n> I think it is not just \"no reason to\", but it is actively wrong to use a\n> full path, as we do not take care to \"mkdir -p\" the intervening path\n> components.\n>\n> However, this never comes up in practice, because all of the test\n> scripts assume you are running them from the test directory (i.e.,\n> they will fail otherwise because they will not find ./test-lib.sh).\n>\n> Is this in support of putting remote-hg tests in contrib/? I had\n> expected you to just put\n>\n> export TEST_DIRECTORY=\"$(pwd)/../../../t\"\n> . \"$TEST_DIRECTORY/test-lib.sh\"\n\nIf there was a single script and we didn't want reports, sure, but\nthis is not too bad:\n\nTESTS := $(wildcard test*.sh)\n\nexport T := $(addprefix $(CURDIR)/,$(TESTS))\nexport MAKE := $(MAKE) -e\nexport PATH := $(CURDIR):$(PATH)\n\ntest:\n\t$(MAKE) -C ../../t $@\n\n$(TESTS):\n\t$(MAKE) -C ../../t $(CURDIR)/$@\n\n.PHONY: $(TESTS)\n\nI just sent the new remote-hg patch series with that.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"202178","messageId":"20121030044609.GA10873@elie.Belkin","threadId":"31975","inReplyTo":"1351570377-894-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-10-30T04:46:09Z","receivedAt":"2012-10-30T04:46:09Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nFelipe Contreras wrote:\n\n> No reason to use the full path in case this is used externally.\n>\n> Signed-off-by: Felipe Contreras \n\n\"No reason not to\" is not a reason to do anything. What symptoms does\nthis prevent? Could you describe the benefit of this patch in a\nparagraph starting \"Now you can ...\"?\n\nThanks,\nJonathan\n"},{"id":"202180","messageId":"CA+EOSB=Rr8czjVJfA+F6DmHjDUBy0QQ-wd4t-3Uwb1Ksoadr0Q@mail.gmail.com","threadId":"31975","inReplyTo":"1351570377-894-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2012-10-30T06:58:59Z","receivedAt":"2012-10-30T06:58:59Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The shell word splitting done in base is a bashism, iow not portable.\n\nBest\n\n2012/10/30, Felipe Contreras :\n> No reason to use the full path in case this is used externally.\n>\n> Signed-off-by: Felipe Contreras \n> ---\n> t/test-lib.sh | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/t/test-lib.sh b/t/test-lib.sh\n> index 514282c..5a3d665 100644\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -389,7 +389,8 @@ test_done () {\n> \tthen\n> \t\ttest_results_dir=\"$TEST_OUTPUT_DIRECTORY/test-results\"\n> \t\tmkdir -p \"$test_results_dir\"\n> -\t\ttest_results_path=\"$test_results_dir/${0%.sh}-$$.counts\"\n> +\t\tbase=${0##*/}\n> +\t\ttest_results_path=\"$test_results_dir/${base%.sh}-$$.counts\"\n>\n> \t\tcat >>\"$test_results_path\" <<-EOF\n> \t\ttotal $test_count\n> --\n> 1.8.0\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>\n\n-- \nInviato dal mio dispositivo mobile\n"},{"id":"202182","messageId":"20121030070152.GA13324@elie.Belkin","threadId":"31975","inReplyTo":"CA+EOSB=Rr8czjVJfA+F6DmHjDUBy0QQ-wd4t-3Uwb1Ksoadr0Q@mail.gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-10-30T07:01:52Z","receivedAt":"2012-10-30T07:01:52Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Elia Pinto wrote:\n\n> The shell word splitting done in base is a bashism, iow not portable.\n\nNo, ${varname##glob} is in POSIX and we already use it here and there.\nSee Documentation/CodingGuidelines:\n\n - We use ${parameter#word} and its [#%] siblings, and their\n doubled \"longest matching\" form.\n\nThanks for looking the patch over.\nJonathan\n"},{"id":"202205","messageId":"CAMP44s3ap19TDsSo_fmNqJp+ROWo2Ka8bc35YQmR3mMw375WsQ@mail.gmail.com","threadId":"31975","inReplyTo":"20121030044609.GA10873@elie.Belkin","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-10-30T16:02:21Z","receivedAt":"2012-10-30T16:02:21Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Tue, Oct 30, 2012 at 5:46 AM, Jonathan Nieder wrote:\n> Felipe Contreras wrote:\n>\n>> No reason to use the full path in case this is used externally.\n>>\n>> Signed-off-by: Felipe Contreras \n>\n> \"No reason not to\" is not a reason to do anything. What symptoms does\n> this prevent? Could you describe the benefit of this patch in a\n> paragraph starting \"Now you can ...\"?\n\n./test-lib.sh: line 394:\n/home/felipec/dev/git/t/test-results//home/felipec/dev/git/contrib/remote-hg/test-21865.counts:\nNo such file or directory\n\n-- \nFelipe Contreras\n"},{"id":"202257","messageId":"CA+EOSBmTjwmf+dO-dgU+rGQaVEKDZw7u9ujrh5jYZkPM2zisOA@mail.gmail.com","threadId":"31975","inReplyTo":"20121030070152.GA13324@elie.Belkin","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2012-10-30T22:17:31Z","receivedAt":"2012-10-30T22:17:31Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Thanks. I know that posix support these usages, but exists some\ntraditional shell that not support it. These are described in the\nautoconf manual, last time i have checked. As the construct ; export\nvar = x should be portable, but it is not. If this is important these\ndays i don't know.\n\n\nBest\n\n2012/10/30, Jonathan Nieder :\n> Elia Pinto wrote:\n>\n>> The shell word splitting done in base is a bashism, iow not portable.\n>\n> No, ${varname##glob} is in POSIX and we already use it here and there.\n> See Documentation/CodingGuidelines:\n>\n> - We use ${parameter#word} and its [#%] siblings, and their\n> doubled \"longest matching\" form.\n>\n> Thanks for looking the patch over.\n> Jonathan\n>\n\n-- \nInviato dal mio dispositivo mobile\n"},{"id":"202277","messageId":"20121031012730.GY15167@elie.Belkin","threadId":"31975","inReplyTo":"CAMP44s3ap19TDsSo_fmNqJp+ROWo2Ka8bc35YQmR3mMw375WsQ@mail.gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-10-31T01:27:30Z","receivedAt":"2012-10-31T01:27:30Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Felipe Contreras wrote:\n> On Tue, Oct 30, 2012 at 5:46 AM, Jonathan Nieder wrote:\n> > Felipe Contreras wrote:\n\n>>> No reason to use the full path in case this is used externally.\n>>>\n>>> Signed-off-by: Felipe Contreras \n>>\n>> \"No reason not to\" is not a reason to do anything. What symptoms does\n>> this prevent? Could you describe the benefit of this patch in a\n>> paragraph starting \"Now you can ...\"?\n>\n> ./test-lib.sh: line 394:\n> /home/felipec/dev/git/t/test-results//home/felipec/dev/git/contrib/remote-hg/test-21865.counts:\n> No such file or directory\n\nOk, so a description for this patch is\n\n\ttest: use test's basename to name results file\n\n\tRunning a test using its full path produces an error:\n\n\t\t$ ~/dev/git/contrib/remote-hg/test-21865.sh\n\t[...]\n\t\t./test-lib.sh: line 394: /home/felipec/dev/t/\\\n\t\ttest-results//home/felipec/dev/git/contrib/remote-hg/\\\n\t\ttest-21865.counts: No such file or directory\n\n\tIn --tee and --valgrind modes we already use the basename\n\tto name the .out and .exit files; this patch teaches the test-lib\n\tto name the .counts file the same way.\n\nThat is still not enough to tell if it is a good change, though.\nShould the test results for contrib/remote-hg/test-* be included with\nthe results for t/t*.sh when I run \"make aggregate-results\"?\n\nBefore 60d02ccc, git-svn had its own testsuite under contrib/, with\nglue in contrib/git-svn/t/lib-git-svn.sh to use test-lib --- maybe\nthat code could provide some inspiration for questions like these.\n\nHope that helps,\nJonathan\n"},{"id":"202282","messageId":"CAMP44s1xAeW2QZsNwRVRx+DEhYVVdiKbw-y-aNuo6unuv7pYZQ@mail.gmail.com","threadId":"31975","inReplyTo":"20121031012730.GY15167@elie.Belkin","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-10-31T01:59:55Z","receivedAt":"2012-10-31T01:59:55Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Wed, Oct 31, 2012 at 2:27 AM, Jonathan Nieder wrote:\n> Felipe Contreras wrote:\n>> On Tue, Oct 30, 2012 at 5:46 AM, Jonathan Nieder wrote:\n>> > Felipe Contreras wrote:\n>\n>>>> No reason to use the full path in case this is used externally.\n>>>>\n>>>> Signed-off-by: Felipe Contreras \n>>>\n>>> \"No reason not to\" is not a reason to do anything. What symptoms does\n>>> this prevent? Could you describe the benefit of this patch in a\n>>> paragraph starting \"Now you can ...\"?\n>>\n>> ./test-lib.sh: line 394:\n>> /home/felipec/dev/git/t/test-results//home/felipec/dev/git/contrib/remote-hg/test-21865.counts:\n>> No such file or directory\n>\n> Ok, so a description for this patch is\n>\n> test: use test's basename to name results file\n\nIs this solving an actual problem or is it just something nice to do?\nLike in all good novels, one has to read more find out...\n\n> Running a test using its full path produces an error:\n\nI'm not sure what that even means. Do you mean this produces an error?\n\n% make -C t $PWD/t9902-completion.sh\n\nWell, sure it does, but this patch doesn't fix that.\n\nIf you want a precise explanation of what kind of usages are enabled\nby this patch, that would require some work, and no I haven't done it,\nand no, I'm not sure.\n\n> $ ~/dev/git/contrib/remote-hg/test-21865.sh\n> [...]\n> ./test-lib.sh: line 394: /home/felipec/dev/t/\\\n> test-results//home/felipec/dev/git/contrib/remote-hg/\\\n> test-21865.counts: No such file or directory\n\nExcept that I didn't do this. So the fact that this happens is an\nassumption, and I'm not willing to make that.\n\nMost likely if somebody does that they are doing something wrong; they\ndidn't define the TESTDIR variable (or something like that).\n\nIt's all fun and games to write explanations for things, but it's not\nthat easy when you want those explanations to be actually true, and\ncorrent--you have to spend time to make sure of that.\n\n> In --tee and --valgrind modes we already use the basename\n> to name the .out and .exit files; this patch teaches the test-lib\n> to name the .counts file the same way.\n\nI don't see the point of listing each and every place where this\nalready happens. As a matter of fact, the base-name is used in other\nplaces as well, and just saying \"This is already done in other\nplaces\", is more than enough. But who says they are not the ones doing\nit wrong? Maybe this part of the code is right, and it's the others\nthat need fixing. I don't see how saying \"Others are doing it\" makes\nthe patch better or worse in any way. There might also be different\nreasons for why they do it that doesn't apply here.\n\n> That is still not enough to tell if it is a good change, though.\n> Should the test results for contrib/remote-hg/test-* be included with\n> the results for t/t*.sh when I run \"make aggregate-results\"?\n>\n> Before 60d02ccc, git-svn had its own testsuite under contrib/, with\n> glue in contrib/git-svn/t/lib-git-svn.sh to use test-lib --- maybe\n> that code could provide some inspiration for questions like these.\n\nOr maybe they are the ones that should look for inspiration in\ncontrib/remote-hg.\n\nThe patch is obviously correct; it's generally good not to name files\nwith slashes in them, and $0 is not guaranteed not to have slashes.\nEven if you run all the tests inside the 't' directory, this script is\nnot only used by git, and others might want sub-directories, and not\nthousands of tests on the same directory like git.\n\nEither way, if obvious fixes that are one-liners require an essay for\nyou, I give up.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"202285","messageId":"20121031021318.GB15167@elie.Belkin","threadId":"31975","inReplyTo":"CAMP44s1xAeW2QZsNwRVRx+DEhYVVdiKbw-y-aNuo6unuv7pYZQ@mail.gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-10-31T02:13:18Z","receivedAt":"2012-10-31T02:13:18Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Felipe Contreras wrote:\n\n> It's all fun and games to write explanations for things, but it's not\n> that easy when you want those explanations to be actually true, and\n> corrent--you have to spend time to make sure of that.\n\nThat's why it's useful for the patch submitter to write them, asking\nfor help when necessary.\n\nAs a bonus, it helps reviewers understand the effect of the patch.\nBugs averted!\n\n[...]\n> Either way, if obvious fixes that are one-liners require an essay for\n> you, I give up.\n\nI guess it is fair to call a reasonable subject line plus a couple of\nsentences an essay. Yes, obvious fixes especially require that, since\nthe bug caused by an obvious fix is one of the worst kinds.\n"},{"id":"202287","messageId":"CAMP44s3WODA2Vru0Q1b5EWA6_1vdHnPmFfUmDg0Phh0S=76O9w@mail.gmail.com","threadId":"31975","inReplyTo":"20121031021318.GB15167@elie.Belkin","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-10-31T02:28:05Z","receivedAt":"2012-10-31T02:28:05Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Wed, Oct 31, 2012 at 3:13 AM, Jonathan Nieder wrote:\n> Felipe Contreras wrote:\n>\n>> It's all fun and games to write explanations for things, but it's not\n>> that easy when you want those explanations to be actually true, and\n>> corrent--you have to spend time to make sure of that.\n>\n> That's why it's useful for the patch submitter to write them, asking\n> for help when necessary.\n>\n> As a bonus, it helps reviewers understand the effect of the patch.\n> Bugs averted!\n\nYeah, that would be nice. Too bad I don't have that information, and\nhave _zero_ motivation to go and get it for you.\n\n> [...]\n>> Either way, if obvious fixes that are one-liners require an essay for\n>> you, I give up.\n>\n> I guess it is fair to call a reasonable subject line plus a couple of\n> sentences an essay. Yes, obvious fixes especially require that, since\n> the bug caused by an obvious fix is one of the worst kinds.\n\nYes, I've written essays for one-line fixes, in the Linux kernel,\nwhere details matter, and things are not so obvious.\n\nThis is not the case here. This is as obvious and simple as things\nget. If there was a problem with it, somebody would have found it by\nnow.\n\nLet not the perfect be the enemy of the good. Or do. Up to you.\n\n-- \nFelipe Contreras\n"},{"id":"202293","messageId":"5090E9D7.1010706@gmail.com","threadId":"31975","inReplyTo":"CA+EOSBmTjwmf+dO-dgU+rGQaVEKDZw7u9ujrh5jYZkPM2zisOA@mail.gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Stefano Lattarini","fromEmail":"stefano.lattarini@gmail.com","sentAt":"2012-10-31T09:05:27Z","receivedAt":"2012-10-31T09:05:27Z","isPatch":true,"sender":{"key":"stefano.lattarini@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1429199?v=4"},"body":"On 10/30/2012 11:17 PM, Elia Pinto wrote:\n> Thanks. I know that posix support these usages, but exists some\n> traditional shell that not support it.\n>\nTrue, but those shells are not POSIX shells -- the major example that\ncomes to mind is the accursed Solaris /bin/sh.\n\nSince Git assumes a POSIX shell in its scripts and testsuite, use of\nany POSIX feature should be fine -- until someone can show a real-world\nPOSIX shell that (likely due to a bug) fails to grasp such feature, in\nwhich case a \"pragmatic\" workaround is needed.\n\nOh, and BTW, there are talks (and mostly consensus) among the Autotools\ndevelopers to start requiring a POSIX shell in the configure scripts\nand Makefile recipes in the near future:\n\n \n\nAnd also, related:\n\n \n \n\n>These are described in the\n> autoconf manual, last time i have checked. As the construct ; export\n> var = x should be portable, but it is not.\n>\nI don't think POSIX requires that to be portable.\n\n> If this is important these days i don't know.\n>\nI hope the above helps to clarify the matter a little.\n\nRegards,\n Stefano\n"},{"id":"202336","messageId":"509167C8.6090600@kdbg.org","threadId":"31975","inReplyTo":"CAMP44s3WODA2Vru0Q1b5EWA6_1vdHnPmFfUmDg0Phh0S=76O9w@mail.gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2012-10-31T18:02:48Z","receivedAt":"2012-10-31T18:02:48Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 31.10.2012 03:28, schrieb Felipe Contreras:\n> On Wed, Oct 31, 2012 at 3:13 AM, Jonathan Nieder wrote:\n>> Felipe Contreras wrote:\n>>\n>>> It's all fun and games to write explanations for things, but it's not\n>>> that easy when you want those explanations to be actually true, and\n>>> corrent--you have to spend time to make sure of that.\n>>\n>> That's why it's useful for the patch submitter to write them, asking\n>> for help when necessary.\n>>\n>> As a bonus, it helps reviewers understand the effect of the patch.\n>> Bugs averted!\n> \n> Yeah, that would be nice. Too bad I don't have that information, and\n> have _zero_ motivation to go and get it for you.\n\nJust to clarify: That information is not just for Jonathan, but for\neveryone on this list and those who dig the history a year down the\nroad. Contributors who have _zero_ motiviation to find out that\ninformation are not welcome here because they cause friction and take\naway time from many others for _zero_ gain.\n\n-- Hannes\n"},{"id":"202339","messageId":"CAMP44s28e4Lxuq5_jZhaOV2PE9X1Qf1o60G7ENqG2ym05kRGfg@mail.gmail.com","threadId":"31975","inReplyTo":"509167C8.6090600@kdbg.org","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-10-31T18:28:36Z","receivedAt":"2012-10-31T18:28:36Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Wed, Oct 31, 2012 at 7:02 PM, Johannes Sixt wrote:\n> Am 31.10.2012 03:28, schrieb Felipe Contreras:\n\n>> Yeah, that would be nice. Too bad I don't have that information, and\n>> have _zero_ motivation to go and get it for you.\n>\n> Just to clarify: That information is not just for Jonathan, but for\n> everyone on this list and those who dig the history a year down the\n> road.\n\nInformation that nobody has requested but Johannes.\n\n> Contributors who have _zero_ motiviation to find out that\n> information are not welcome here because they cause friction and take\n> away time from many others for _zero_ gain.\n\nFine, stay with the broken code.\n\nCheers.\n\n--\nFelipe Contreras\n"},{"id":"202417","messageId":"20121102131726.GC2598@sigill.intra.peff.net","threadId":"31975","inReplyTo":"509167C8.6090600@kdbg.org","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-11-02T13:17:26Z","receivedAt":"2012-11-02T13:17:26Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Oct 31, 2012 at 07:02:48PM +0100, Johannes Sixt wrote:\n\n> Am 31.10.2012 03:28, schrieb Felipe Contreras:\n> > On Wed, Oct 31, 2012 at 3:13 AM, Jonathan Nieder wrote:\n> >> Felipe Contreras wrote:\n> >>\n> >>> It's all fun and games to write explanations for things, but it's not\n> >>> that easy when you want those explanations to be actually true, and\n> >>> corrent--you have to spend time to make sure of that.\n> >>\n> >> That's why it's useful for the patch submitter to write them, asking\n> >> for help when necessary.\n> >>\n> >> As a bonus, it helps reviewers understand the effect of the patch.\n> >> Bugs averted!\n> > \n> > Yeah, that would be nice. Too bad I don't have that information, and\n> > have _zero_ motivation to go and get it for you.\n> \n> Just to clarify: That information is not just for Jonathan, but for\n> everyone on this list and those who dig the history a year down the\n> road. Contributors who have _zero_ motiviation to find out that\n> information are not welcome here because they cause friction and take\n> away time from many others for _zero_ gain.\n\nAnd me, who is trying to figure out what to do with this patch. It is\npresented on its own, outside of a series, with only the description \"no\nreason not to do this\". But AFAICT, it is _required_ for the tests in\nthe remote-hg series to work. Isn't that kind of an important\nmotivation?\n\nYet it is not in the commit message, nor does the remote-hg series\nindicate that it should be built on top. Or am I wrong that the one is\ndependent on the other?\n\n-Peff\n"},{"id":"202436","messageId":"CAMP44s2bZa4BnTnSv0Zgdh52Vy613R3cWE3nSxXdR4dDVhJAyw@mail.gmail.com","threadId":"31975","inReplyTo":"20121102131726.GC2598@sigill.intra.peff.net","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-11-02T15:17:27Z","receivedAt":"2012-11-02T15:17:27Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, Nov 2, 2012 at 2:17 PM, Jeff King wrote:\n> On Wed, Oct 31, 2012 at 07:02:48PM +0100, Johannes Sixt wrote:\n>\n>> Am 31.10.2012 03:28, schrieb Felipe Contreras:\n>> > On Wed, Oct 31, 2012 at 3:13 AM, Jonathan Nieder wrote:\n>> >> Felipe Contreras wrote:\n>> >>\n>> >>> It's all fun and games to write explanations for things, but it's not\n>> >>> that easy when you want those explanations to be actually true, and\n>> >>> corrent--you have to spend time to make sure of that.\n>> >>\n>> >> That's why it's useful for the patch submitter to write them, asking\n>> >> for help when necessary.\n>> >>\n>> >> As a bonus, it helps reviewers understand the effect of the patch.\n>> >> Bugs averted!\n>> >\n>> > Yeah, that would be nice. Too bad I don't have that information, and\n>> > have _zero_ motivation to go and get it for you.\n>>\n>> Just to clarify: That information is not just for Jonathan, but for\n>> everyone on this list and those who dig the history a year down the\n>> road. Contributors who have _zero_ motiviation to find out that\n>> information are not welcome here because they cause friction and take\n>> away time from many others for _zero_ gain.\n>\n> And me, who is trying to figure out what to do with this patch. It is\n> presented on its own, outside of a series, with only the description \"no\n> reason not to do this\".\n\nYeah, because I think it stands on its own. But I'll include it in the\nremote-hg patch series, I already have it queued up.\n\n> But AFAICT, it is _required_ for the tests in\n> the remote-hg series to work. Isn't that kind of an important\n> motivation?\n\nIt's not _requied_, you will see that error at the end, and the\naggregate results would all be 0, but the tests would still work.\n\n> Yet it is not in the commit message, nor does the remote-hg series\n> indicate that it should be built on top. Or am I wrong that the one is\n> dependent on the other?\n\nThey are not dependent.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"202438","messageId":"20121102152051.GB24622@sigill.intra.peff.net","threadId":"31975","inReplyTo":"CAMP44s2bZa4BnTnSv0Zgdh52Vy613R3cWE3nSxXdR4dDVhJAyw@mail.gmail.com","subject":"Re: [PATCH] test-lib: avoid full path to store test results","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-11-02T15:20:51Z","receivedAt":"2012-11-02T15:20:51Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Nov 02, 2012 at 04:17:27PM +0100, Felipe Contreras wrote:\n\n> > And me, who is trying to figure out what to do with this patch. It is\n> > presented on its own, outside of a series, with only the description \"no\n> > reason not to do this\".\n> \n> Yeah, because I think it stands on its own. But I'll include it in the\n> remote-hg patch series, I already have it queued up.\n\nThanks.\n\n-Peff\n"}]}