{"thread":{"id":"31952","subject":"[PATCH] Fix t9200 on case insensitive file systems","startedAt":"2012-10-26T16:18:24Z","lastAt":"2012-10-28T15:28:19Z","messageCount":4,"participants":["Torsten Bögershausen","Ben Walton","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"201965","messageId":"201210261818.25620.tboegi@web.de","threadId":"31952","inReplyTo":null,"subject":"[PATCH] Fix t9200 on case insensitive file systems","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2012-10-26T16:18:24Z","receivedAt":"2012-10-26T16:18:24Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"t9200 defines $CVSROOT where cvs should init its repository\n$CVSROOT is set to $PWD/cvsroot.\ncvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT\n\n\"cvs init\" (e.g. version  1.11.23) checks if the last element of the path is\n\"CVSROOT\", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists.\n\nFor such a $CVSROOT cvs refuses to init a repository here:\n\"Cannot initialize repository under existing CVSROOT:\n\nOn a case insenstive file system cvsroot and CVSROOT are the same directories\nand t9200 fails.\n\nSolution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t9200-git-cvsexportcommit.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\nindex b59be9a..69934b2 100755\n--- a/t/t9200-git-cvsexportcommit.sh\n+++ b/t/t9200-git-cvsexportcommit.sh\n@@ -19,7 +19,7 @@ then\n     test_done\n fi\n \n-CVSROOT=$PWD/cvsroot\n+CVSROOT=$PWD/tmpcvsroot\n CVSWORK=$PWD/cvswork\n GIT_DIR=$PWD/.git\n export CVSROOT CVSWORK GIT_DIR\n-- \n1.7.12\n"},{"id":"202014","messageId":"CAP30j160xHL+N=v_=c=6gvLTYynB9oPSNuTHu_NCYz71=YNyfQ@mail.gmail.com","threadId":"31952","inReplyTo":"201210261818.25620.tboegi@web.de","subject":"Re: [PATCH] Fix t9200 on case insensitive file systems","fromName":"Ben Walton","fromEmail":"bdwalton@gmail.com","sentAt":"2012-10-27T21:36:27Z","receivedAt":"2012-10-27T21:36:27Z","isPatch":true,"sender":{"key":"bdwalton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/396061?v=4"},"body":"On Fri, Oct 26, 2012 at 5:18 PM, Torsten Bögershausen <tboegi@web.de> wrote:\n>  t/t9200-git-cvsexportcommit.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\n> index b59be9a..69934b2 100755\n> --- a/t/t9200-git-cvsexportcommit.sh\n> +++ b/t/t9200-git-cvsexportcommit.sh\n> @@ -19,7 +19,7 @@ then\n>      test_done\n>  fi\n>\n> -CVSROOT=$PWD/cvsroot\n> +CVSROOT=$PWD/tmpcvsroot\n\nFWIW, this looks obviously correct given the code snippet from the cvs\nversion you shared the other day.\n\nThanks\n-Ben\n-- \n---------------------------------------------------------------------------------------------------------------------------\nTake the risk of thinking for yourself.  Much more happiness,\ntruth, beauty and wisdom will come to you that way.\n\n-Christopher Hitchens\n---------------------------------------------------------------------------------------------------------------------------\n"},{"id":"202037","messageId":"20121028111053.GC11434@sigill.intra.peff.net","threadId":"31952","inReplyTo":"201210261818.25620.tboegi@web.de","subject":"Re: [PATCH] Fix t9200 on case insensitive file systems","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-28T11:10:53Z","receivedAt":"2012-10-28T11:10:53Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Oct 26, 2012 at 06:18:24PM +0200, Torsten Bögershausen wrote:\n\n> t9200 defines $CVSROOT where cvs should init its repository\n> $CVSROOT is set to $PWD/cvsroot.\n> cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT\n> \n> \"cvs init\" (e.g. version  1.11.23) checks if the last element of the path is\n> \"CVSROOT\", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists.\n> \n> For such a $CVSROOT cvs refuses to init a repository here:\n> \"Cannot initialize repository under existing CVSROOT:\n> \n> On a case insenstive file system cvsroot and CVSROOT are the same directories\n> and t9200 fails.\n> \n> Solution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot\n\nWouldn't tmp/cvsroot have the same problem, since the basename is still\ncvsroot?\n\n> diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\n> index b59be9a..69934b2 100755\n> --- a/t/t9200-git-cvsexportcommit.sh\n> +++ b/t/t9200-git-cvsexportcommit.sh\n> @@ -19,7 +19,7 @@ then\n>      test_done\n>  fi\n>  \n> -CVSROOT=$PWD/cvsroot\n> +CVSROOT=$PWD/tmpcvsroot\n\nAh, but here you do something different, which makes sense. Should I\ntweak the commit message?\n\n-Peff\n"},{"id":"202048","messageId":"508D4F13.1090209@web.de","threadId":"31952","inReplyTo":"20121028111053.GC11434@sigill.intra.peff.net","subject":"Re: [PATCH] Fix t9200 on case insensitive file systems","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2012-10-28T15:28:19Z","receivedAt":"2012-10-28T15:28:19Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 28.10.12 12:10, Jeff King wrote:\n> On Fri, Oct 26, 2012 at 06:18:24PM +0200, Torsten Bögershausen wrote:\n> \n>> t9200 defines $CVSROOT where cvs should init its repository\n>> $CVSROOT is set to $PWD/cvsroot.\n>> cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT\n>>\n>> \"cvs init\" (e.g. version  1.11.23) checks if the last element of the path is\n>> \"CVSROOT\", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists.\n>>\n>> For such a $CVSROOT cvs refuses to init a repository here:\n>> \"Cannot initialize repository under existing CVSROOT:\n>>\n>> On a case insenstive file system cvsroot and CVSROOT are the same directories\n>> and t9200 fails.\n>>\n>> Solution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot\n> \n> Wouldn't tmp/cvsroot have the same problem, since the basename is still\n> cvsroot?\n> \n>> diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\n>> index b59be9a..69934b2 100755\n>> --- a/t/t9200-git-cvsexportcommit.sh\n>> +++ b/t/t9200-git-cvsexportcommit.sh\n>> @@ -19,7 +19,7 @@ then\n>>      test_done\n>>  fi\n>>  \n>> -CVSROOT=$PWD/cvsroot\n>> +CVSROOT=$PWD/tmpcvsroot\n> \n> Ah, but here you do something different, which makes sense. Should I\n> tweak the commit message?\n> \n\nYes, please do so.\n\nThanks for spotting,\n/torsten\n"}]}