{"thread":{"id":"31940","subject":"RE: [PATCH v2] fix 'make test' for HP NonStop","startedAt":"2012-10-25T10:57:10Z","lastAt":"2012-10-30T11:13:09Z","messageCount":4,"participants":["Joachim Schmitz","Jeff King"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"201891","messageId":"003101cdb29f$7c8d9490$75a8bdb0$@schmitz-digital.de","threadId":"31940","inReplyTo":null,"subject":"RE: [PATCH v2] fix 'make test' for HP NonStop","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-25T10:57:10Z","receivedAt":"2012-10-25T10:57:10Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"This fixes the vast majority of test failures on HP NonStop.\n\nSigned-off-by: Joachim Schmitz <jojo@schmitz-digital.de>\n---\nv2: hardcode /usr/local rather than using ${prefix}\n\nMakefile | 9 +++++++++\n1 file changed, 9 insertions(+)\n\ndiff --git a/Makefile b/Makefile\nindex f69979e..35380dd 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1381,6 +1381,15 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n\tMKDIR_WO_TRAILING_SLASH = YesPlease\n\t# RFE 10-120912-4693 submitted to HP NonStop development.\n\tNO_SETITIMER = UnfortunatelyYes\n+\n+\t# for 'make test'\n+\t# some test don't work with /bin/diff, some fail with /bin/tar\n+\t# some need bash, and some need /usr/local/bin in PATH first\n+\tSHELL_PATH=/usr/local/bin/bash\n+\tSANE_TOOL_PATH=/usr/local/bin\n+\t# as of H06.25/J06.14, we might better use this\n+\t#SHELL_PATH=/usr/coreutils/bin/bash\n+\t#SANE_TOOL_PATH=/usr/coreutils/bin:/usr/local/bin\nendif\nifneq (,$(findstring MINGW,$(uname_S)))\n\tpathsep = ;\n"},{"id":"202094","messageId":"20121029070642.GD5102@sigill.intra.peff.net","threadId":"31940","inReplyTo":"003101cdb29f$7c8d9490$75a8bdb0$@schmitz-digital.de","subject":"Re: [PATCH v2] fix 'make test' for HP NonStop","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-29T07:06:42Z","receivedAt":"2012-10-29T07:06:42Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Oct 25, 2012 at 12:57:10PM +0200, Joachim Schmitz wrote:\n\n> diff --git a/Makefile b/Makefile\n> index f69979e..35380dd 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1381,6 +1381,15 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n> \tMKDIR_WO_TRAILING_SLASH = YesPlease\n> \t# RFE 10-120912-4693 submitted to HP NonStop development.\n> \tNO_SETITIMER = UnfortunatelyYes\n> +\n> +\t# for 'make test'\n> +\t# some test don't work with /bin/diff, some fail with /bin/tar\n> +\t# some need bash, and some need /usr/local/bin in PATH first\n> +\tSHELL_PATH=/usr/local/bin/bash\n> +\tSANE_TOOL_PATH=/usr/local/bin\n\nI think we can drop these comments, as the reasoning really should just\ngo in the commit message.\n\n> +\t# as of H06.25/J06.14, we might better use this\n> +\t#SHELL_PATH=/usr/coreutils/bin/bash\n> +\t#SANE_TOOL_PATH=/usr/coreutils/bin:/usr/local/bin\n\nIs there any reason not to put both into the default SANE_TOOL_PATH? If\n/usr/coreutils/bin does not exist on older versions, it will be a\nharmless no-op. I guess we arestuck with picking one $SHELL_PATH,\nthough.\n\n-Peff\n"},{"id":"202185","messageId":"005701cdb67f$f8b44d00$ea1ce700$@schmitz-digital.de","threadId":"31940","inReplyTo":"20121029070642.GD5102@sigill.intra.peff.net","subject":"RE: [PATCH v2] fix 'make test' for HP NonStop","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-30T09:21:40Z","receivedAt":"2012-10-30T09:21:40Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Jeff King [mailto:peff@peff.net]\n> Sent: Monday, October 29, 2012 8:07 AM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: [PATCH v2] fix 'make test' for HP NonStop\n> \n> On Thu, Oct 25, 2012 at 12:57:10PM +0200, Joachim Schmitz wrote:\n> \n> > diff --git a/Makefile b/Makefile\n> > index f69979e..35380dd 100644\n> > --- a/Makefile\n> > +++ b/Makefile\n> > @@ -1381,6 +1381,15 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n> > \tMKDIR_WO_TRAILING_SLASH = YesPlease\n> > \t# RFE 10-120912-4693 submitted to HP NonStop development.\n> > \tNO_SETITIMER = UnfortunatelyYes\n> > +\n> > +\t# for 'make test'\n> > +\t# some test don't work with /bin/diff, some fail with /bin/tar\n> > +\t# some need bash, and some need /usr/local/bin in PATH first\n> > +\tSHELL_PATH=/usr/local/bin/bash\n> > +\tSANE_TOOL_PATH=/usr/local/bin\n> \n> I think we can drop these comments, as the reasoning really should just\n> go in the commit message.\n\nOK by me.\n \n> > +\t# as of H06.25/J06.14, we might better use this\n> > +\t#SHELL_PATH=/usr/coreutils/bin/bash\n> > +\t#SANE_TOOL_PATH=/usr/coreutils/bin:/usr/local/bin\n> \n> Is there any reason not to put both into the default SANE_TOOL_PATH? If\n> /usr/coreutils/bin does not exist on older versions, it will be a\n> harmless no-op. I guess we arestuck with picking one $SHELL_PATH,\n> though.\n\nAnd because of that have to modify something anyway...\nBut I don't really mind about an extended SANE_TOOL_PATH\n \n> -Peff\n\nBye, Jojo\n\n-- 8< --\nThis fixes the vast majority of test failures on HP NonStop.\nSome test don't work with /bin/diff, some fail with /bin/tar,\nso let's put /usr/local/bin in PATH first. \nSome tests fail with /bin/sh (link to /bin/ksh) so use bash instead\n\nSigned-off-by: Joachim Schmitz <jojo@schmitz-digital.de>\n---\n\nMakefile | 9 +++++++++\n1 file changed, 9 insertions(+)\n\ndiff --git a/Makefile b/Makefile\nindex f69979e..35380dd 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1381,6 +1381,10 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n\tMKDIR_WO_TRAILING_SLASH = YesPlease\n\t# RFE 10-120912-4693 submitted to HP NonStop development.\n\tNO_SETITIMER = UnfortunatelyYes\n+\tSANE_TOOL_PATH=/usr/coreutils/bin:/usr/local/bin \n+\tSHELL_PATH=/usr/local/bin/bash\n+\t# as of H06.25/J06.14, we might better use this\n+\t#SHELL_PATH=/usr/coreutils/bin/bash\nendif\nifneq (,$(findstring MINGW,$(uname_S)))\n\tpathsep = ;\n"},{"id":"202196","messageId":"20121030111308.GA32150@sigill.intra.peff.net","threadId":"31940","inReplyTo":"005701cdb67f$f8b44d00$ea1ce700$@schmitz-digital.de","subject":"Re: [PATCH v2] fix 'make test' for HP NonStop","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-30T11:13:09Z","receivedAt":"2012-10-30T11:13:09Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Oct 30, 2012 at 10:21:40AM +0100, Joachim Schmitz wrote:\n\n> This fixes the vast majority of test failures on HP NonStop.\n> Some test don't work with /bin/diff, some fail with /bin/tar,\n> so let's put /usr/local/bin in PATH first. \n> Some tests fail with /bin/sh (link to /bin/ksh) so use bash instead\n> \n> Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>\n> ---\n> \n> Makefile | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/Makefile b/Makefile\n> index f69979e..35380dd 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1381,6 +1381,10 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n> \tMKDIR_WO_TRAILING_SLASH = YesPlease\n> \t# RFE 10-120912-4693 submitted to HP NonStop development.\n> \tNO_SETITIMER = UnfortunatelyYes\n> +\tSANE_TOOL_PATH=/usr/coreutils/bin:/usr/local/bin \n> +\tSHELL_PATH=/usr/local/bin/bash\n> +\t# as of H06.25/J06.14, we might better use this\n> +\t#SHELL_PATH=/usr/coreutils/bin/bash\n> endif\n> ifneq (,$(findstring MINGW,$(uname_S)))\n> \tpathsep = ;\n\nYour patch was whitespace damaged, but I was able to fix it up. Thanks.\n\n-Peff\n"}]}