{"thread":{"id":"31916","subject":"[PATCH] Document git-svn fetch --log-window-size parameter","startedAt":"2012-10-23T10:33:26Z","lastAt":"2012-10-29T22:36:30Z","messageCount":8,"participants":["Gunnlaugur Þór Briem","Jeff King","Eric Wong","Gunnlaugur Thor Briem"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"201727","messageId":"1350988406-97624-1-git-send-email-gunnlaugur@gmail.com","threadId":"31916","inReplyTo":null,"subject":"[PATCH] Document git-svn fetch --log-window-size parameter","fromName":"Gunnlaugur Þór Briem","fromEmail":"gunnlaugur@gmail.com","sentAt":"2012-10-23T10:33:26Z","receivedAt":"2012-10-23T10:33:26Z","isPatch":true,"sender":{"key":"gunnlaugur@gmail.com","avatar":"https://avatars.githubusercontent.com/u/153580?v=4"},"body":"The --log-window-size parameter to git-svn fetch is undocumented.\n\nMinimally describe what it does and why the user might change it.\n\nSigned-off-by: Gunnlaugur Þór Briem \n---\n Documentation/git-svn.txt | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex cfe8d2b..64756c9 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -146,6 +146,12 @@ Skip \"branches\" and \"tags\" of first level directories;;\n ------------------------------------------------------------------------\n --\n \n+--log-window-size=;;\n+ Fetch log entries per request when scanning Subversion history.\n+ The default is 100. For very large Subversion repositories, larger\n+ values may be needed for 'clone'/'fetch' to complete in reasonable\n+ time. But overly large values may lead to request timeouts.\n+\n 'clone'::\n \tRuns 'init' and 'fetch'. It will automatically create a\n \tdirectory based on the basename of the URL passed to it;\n-- \n1.7.12.3\n"},{"id":"201880","messageId":"20121025095202.GK8390@sigill.intra.peff.net","threadId":"31916","inReplyTo":"1350988406-97624-1-git-send-email-gunnlaugur@gmail.com","subject":"Re: [PATCH] Document git-svn fetch --log-window-size parameter","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-25T09:52:02Z","receivedAt":"2012-10-25T09:52:02Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Oct 23, 2012 at 10:33:26AM +0000, Gunnlaugur Þór Briem wrote:\n\n> The --log-window-size parameter to git-svn fetch is undocumented.\n> \n> Minimally describe what it does and why the user might change it.\n\nThanks. Your description makes sense to me, but I do not have enough\ngit-svn knowledge to know if it covers all intended uses of the flag.\nEric?\n\n> +--log-window-size=;;\n> + Fetch log entries per request when scanning Subversion history.\n> + The default is 100. For very large Subversion repositories, larger\n> + values may be needed for 'clone'/'fetch' to complete in reasonable\n> + time. But overly large values may lead to request timeouts.\n\n-Peff\n"},{"id":"201933","messageId":"20121026094602.GA7887@dcvr.yhbt.net","threadId":"31916","inReplyTo":"20121025095202.GK8390@sigill.intra.peff.net","subject":"Re: [PATCH] Document git-svn fetch --log-window-size parameter","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2012-10-26T09:46:02Z","receivedAt":"2012-10-26T09:46:02Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Jeff King wrote:\n> On Tue, Oct 23, 2012 at 10:33:26AM +0000, Gunnlaugur Þór Briem wrote:\n> \n> > The --log-window-size parameter to git-svn fetch is undocumented.\n> > \n> > Minimally describe what it does and why the user might change it.\n> \n> Thanks. Your description makes sense to me, but I do not have enough\n> git-svn knowledge to know if it covers all intended uses of the flag.\n> Eric?\n> \n> > +--log-window-size=;;\n> > + Fetch log entries per request when scanning Subversion history.\n> > + The default is 100. For very large Subversion repositories, larger\n> > + values may be needed for 'clone'/'fetch' to complete in reasonable\n> > + time. But overly large values may lead to request timeouts.\n\nOverly large values also lead to excessive memory usage. I may have\nonly had 256M in my dev machine at the time I added this parameter:\n\n commit 6af1db447b10c03db4c04a55000efaa9aad38caa\n Author: Eric Wong \n Date: Wed Feb 14 16:04:10 2007 -0800\n\n git-svn: allow --log-window-size to be specified, default to 100\n \n The newer default value should should lower memory usage for\n large fetches and also help with fetching from less reliable\n servers. Previously the value was 1000 and memory usage\n got a bit high on some repositories and fetching became\n less reliable in some cases.\n \n Signed-off-by: Eric Wong \n"},{"id":"201942","messageId":"20121026133250.GI1455@sigill.intra.peff.net","threadId":"31916","inReplyTo":"20121026094602.GA7887@dcvr.yhbt.net","subject":"Re: [PATCH] Document git-svn fetch --log-window-size parameter","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-26T13:32:50Z","receivedAt":"2012-10-26T13:32:50Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Oct 26, 2012 at 09:46:02AM +0000, Eric Wong wrote:\n\n> > Thanks. Your description makes sense to me, but I do not have enough\n> > git-svn knowledge to know if it covers all intended uses of the flag.\n> > Eric?\n> > \n> > > +--log-window-size=;;\n> > > + Fetch log entries per request when scanning Subversion history.\n> > > + The default is 100. For very large Subversion repositories, larger\n> > > + values may be needed for 'clone'/'fetch' to complete in reasonable\n> > > + time. But overly large values may lead to request timeouts.\n> \n> Overly large values also lead to excessive memory usage. I may have\n> only had 256M in my dev machine at the time I added this parameter:\n\nThat's probably worth mentioning. Gunnlaugur, any objection to me\namending your commit with:\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 64756c9..8b0d3ad 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -150,7 +150,8 @@ Skip \"branches\" and \"tags\" of first level directories;;\n Fetch log entries per request when scanning Subversion history.\n The default is 100. For very large Subversion repositories, larger\n values may be needed for 'clone'/'fetch' to complete in reasonable\n- time. But overly large values may lead to request timeouts.\n+ time. But overly large values may lead to higher memory usage and\n+ request timeouts.\n \n 'clone'::\n \tRuns 'init' and 'fetch'. It will automatically create a\n\n?\n\n-Peff\n"},{"id":"201946","messageId":"CAPs+M8+oa7AEBw-Lvs4TkeLrQ_Amx9_8NmCC6zYUPknMLaFNRA@mail.gmail.com","threadId":"31916","inReplyTo":"20121026133250.GI1455@sigill.intra.peff.net","subject":"Re: [PATCH] Document git-svn fetch --log-window-size parameter","fromName":"Gunnlaugur Thor Briem","fromEmail":"gunnlaugur@gmail.com","sentAt":"2012-10-26T13:45:57Z","receivedAt":"2012-10-26T13:45:57Z","isPatch":true,"sender":{"key":"gunnlaugur@gmail.com","avatar":"https://avatars.githubusercontent.com/u/153580?v=4"},"body":"On Fri, Oct 26, 2012 at 1:32 PM, Jeff King wrote:\n> That's probably worth mentioning. Gunnlaugur, any objection to me\n> amending your commit with:\n>\n> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\n> index 64756c9..8b0d3ad 100644\n> --- a/Documentation/git-svn.txt\n> +++ b/Documentation/git-svn.txt\n> @@ -150,7 +150,8 @@ Skip \"branches\" and \"tags\" of first level directories;;\n> Fetch log entries per request when scanning Subversion history.\n> The default is 100. For very large Subversion repositories, larger\n> values may be needed for 'clone'/'fetch' to complete in reasonable\n> - time. But overly large values may lead to request timeouts.\n> + time. But overly large values may lead to higher memory usage and\n> + request timeouts.\n>\n> 'clone'::\n> Runs 'init' and 'fetch'. It will automatically create a\n>\n> ?\n\nNo objection, that sounds fine to me.\n\n-Gulli\n"},{"id":"202135","messageId":"20121029201847.GA22021@dcvr.yhbt.net","threadId":"31916","inReplyTo":"20121026133250.GI1455@sigill.intra.peff.net","subject":"Re: [PATCH] Document git-svn fetch --log-window-size parameter","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2012-10-29T20:18:47Z","receivedAt":"2012-10-29T20:18:47Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Jeff King wrote:\n> On Fri, Oct 26, 2012 at 09:46:02AM +0000, Eric Wong wrote:\n> > Overly large values also lead to excessive memory usage. I may have\n> > only had 256M in my dev machine at the time I added this parameter:\n> \n> That's probably worth mentioning. Gunnlaugur, any objection to me\n> amending your commit with:\n\nThanks both, I've amended and S-o-b on my end. Shall I add:\nSigned-off-by: Jeff King \n\nand push?\n"},{"id":"202145","messageId":"20121029220208.GH20513@sigill.intra.peff.net","threadId":"31916","inReplyTo":"20121029201847.GA22021@dcvr.yhbt.net","subject":"Re: [PATCH] Document git-svn fetch --log-window-size parameter","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-29T22:02:08Z","receivedAt":"2012-10-29T22:02:08Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Oct 29, 2012 at 08:18:47PM +0000, Eric Wong wrote:\n\n> Jeff King wrote:\n> > On Fri, Oct 26, 2012 at 09:46:02AM +0000, Eric Wong wrote:\n> > > Overly large values also lead to excessive memory usage. I may have\n> > > only had 256M in my dev machine at the time I added this parameter:\n> > \n> > That's probably worth mentioning. Gunnlaugur, any objection to me\n> > amending your commit with:\n> \n> Thanks both, I've amended and S-o-b on my end. Shall I add:\n> Signed-off-by: Jeff King \n\nSince it was such a small topic, I just went ahead and queued bc22b27 in\nmy repo. If that's not OK, I can revert it from 'next' and wait to get\nit by pulling from you.\n\n-Peff\n"},{"id":"202153","messageId":"20121029223630.GB29353@dcvr.yhbt.net","threadId":"31916","inReplyTo":"20121029220208.GH20513@sigill.intra.peff.net","subject":"Re: [PATCH] Document git-svn fetch --log-window-size parameter","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2012-10-29T22:36:30Z","receivedAt":"2012-10-29T22:36:30Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Jeff King wrote:\n> Since it was such a small topic, I just went ahead and queued bc22b27 in\n> my repo. If that's not OK, I can revert it from 'next' and wait to get\n> it by pulling from you.\n\nThat's fine, thanks!\n"}]}