{"thread":{"id":"31886","subject":"[PATCH] Add -S, --gpg-sign option to manpage of \"git commit\"","startedAt":"2012-10-21T19:46:37Z","lastAt":"2012-10-29T07:49:32Z","messageCount":4,"participants":["Tom Jones","Junio C Hamano","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"201648","messageId":"20121021195455.43D8F7D4C@ralph.oxix.org","threadId":"31886","inReplyTo":null,"subject":"[PATCH] Add -S, --gpg-sign option to manpage of \"git commit\"","fromName":"Tom Jones","fromEmail":"tom@oxix.org","sentAt":"2012-10-21T19:46:37Z","receivedAt":"2012-10-21T19:46:37Z","isPatch":true,"sender":{"key":"tom@oxix.org","avatar":"https://avatars.githubusercontent.com/u/1994887?v=4"},"body":"git commit -S, --gpg-sign was mentioned in the program's help message,\nbut not in the manpage.\n\nThis adds an equivalent entry for the option in the manpage.\n---\n Documentation/git-commit.txt | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex 9594ac8..0e0a22c 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -13,7 +13,7 @@ SYNOPSIS\n \t [-F | -m ] [--reset-author] [--allow-empty]\n \t [--allow-empty-message] [--no-verify] [-e] [--author=]\n \t [--date=] [--cleanup=] [--status | --no-status]\n-\t [-i | -o] [--] [...]\n+\t [-i | -o] [--] [-S[keyid]] [...]\n \n DESCRIPTION\n -----------\n@@ -276,6 +276,10 @@ configuration variable documented in linkgit:git-config[1].\n \tcommit message template when using an editor to prepare the\n \tdefault commit message.\n \n+-S[]::\n+--gpg-sign[=]::\n+\tGPG-sign commit.\n+\n \\--::\n \tDo not interpret any more arguments as options.\n \n-- \n1.7.2.5\n"},{"id":"201775","messageId":"20121023225101.189E57D4C@ralph.oxix.org","threadId":"31886","inReplyTo":"7vbofvfup7.fsf@alter.siamese.dyndns.org","subject":"[PATCH] Add -S, --gpg-sign option to manpage of \"git commit\"","fromName":"Tom Jones","fromEmail":"tom@oxix.org","sentAt":"2012-10-21T19:46:37Z","receivedAt":"2012-10-21T19:46:37Z","isPatch":true,"sender":{"key":"tom@oxix.org","avatar":"https://avatars.githubusercontent.com/u/1994887?v=4"},"body":"git commit -S, --gpg-sign was mentioned in the program's help message,\nbut not in the manpage.\n\nThis adds an equivalent entry for the option in the manpage.\n\nSigned-off-by: Tom Jones \n---\nOn Sun, Oct 21, 2012 at 01:15:16PM -0700, Junio C Hamano wrote:\n> Are you sure about this? The order [...]\n\nGood point. Please find a revised patch, with the newly documented\noption before the optional double dashes, below.\n\n> Sign off?\n\nNow added, too.\n\n Documentation/git-commit.txt | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex 9594ac8..4b78bd0 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -13,7 +13,7 @@ SYNOPSIS\n \t [-F | -m ] [--reset-author] [--allow-empty]\n \t [--allow-empty-message] [--no-verify] [-e] [--author=]\n \t [--date=] [--cleanup=] [--status | --no-status]\n-\t [-i | -o] [--] [...]\n+\t [-i | -o] [-S[keyid]] [--] [...]\n \n DESCRIPTION\n -----------\n@@ -276,6 +276,10 @@ configuration variable documented in linkgit:git-config[1].\n \tcommit message template when using an editor to prepare the\n \tdefault commit message.\n \n+-S[]::\n+--gpg-sign[=]::\n+\tGPG-sign commit.\n+\n \\--::\n \tDo not interpret any more arguments as options.\n \n-- \n1.7.2.5\n"},{"id":"201650","messageId":"7vbofvfup7.fsf@alter.siamese.dyndns.org","threadId":"31886","inReplyTo":"20121021195455.43D8F7D4C@ralph.oxix.org","subject":"Re: [PATCH] Add -S, --gpg-sign option to manpage of \"git commit\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-10-21T20:15:16Z","receivedAt":"2012-10-21T20:15:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tom Jones writes:\n\n> git commit -S, --gpg-sign was mentioned in the program's help message,\n> but not in the manpage.\n>\n> This adds an equivalent entry for the option in the manpage.\n> ---\n\nSign off?\n\n> Documentation/git-commit.txt | 6 +++++-\n> 1 files changed, 5 insertions(+), 1 deletions(-)\n>\n> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\n> index 9594ac8..0e0a22c 100644\n> --- a/Documentation/git-commit.txt\n> +++ b/Documentation/git-commit.txt\n> @@ -13,7 +13,7 @@ SYNOPSIS\n> \t [-F | -m ] [--reset-author] [--allow-empty]\n> \t [--allow-empty-message] [--no-verify] [-e] [--author=]\n> \t [--date=] [--cleanup=] [--status | --no-status]\n> -\t [-i | -o] [--] [...]\n> +\t [-i | -o] [--] [-S[keyid]] [...]\n\nAre you sure about this? The order, described in \"git help cli\", of\nthe command line arguments is options (such as -F \n-S[]) first, then revs (irrelevant for \"git commit\" and lack\nof it in this manual is correct), and then paths. Optionally \"--\"\ncan be used to mark the beginning of \"paths\" part (e.g. \"git commit\n-- -S\" or \"git commit ./-S\" is used when you want to commit a file\nwhose name is \"-S\").\n\n\n\n\n> DESCRIPTION\n> -----------\n> @@ -276,6 +276,10 @@ configuration variable documented in linkgit:git-config[1].\n> \tcommit message template when using an editor to prepare the\n> \tdefault commit message.\n> \n> +-S[]::\n> +--gpg-sign[=]::\n> +\tGPG-sign commit.\n> +\n> \\--::\n> \tDo not interpret any more arguments as options.\n"},{"id":"202101","messageId":"20121029074932.GG5102@sigill.intra.peff.net","threadId":"31886","inReplyTo":"20121023225101.189E57D4C@ralph.oxix.org","subject":"Re: [PATCH] Add -S, --gpg-sign option to manpage of \"git commit\"","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-29T07:49:32Z","receivedAt":"2012-10-29T07:49:32Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Oct 21, 2012 at 08:46:37PM +0100, Tom Jones wrote:\n\n> git commit -S, --gpg-sign was mentioned in the program's help message,\n> but not in the manpage.\n> \n> This adds an equivalent entry for the option in the manpage.\n> \n> Signed-off-by: Tom Jones \n\nThanks. This slipped through the cracks last week, but I've picked it up\nnow.\n\n> DESCRIPTION\n> -----------\n> @@ -276,6 +276,10 @@ configuration variable documented in linkgit:git-config[1].\n> \tcommit message template when using an editor to prepare the\n> \tdefault commit message.\n> \n> +-S[]::\n> +--gpg-sign[=]::\n> +\tGPG-sign commit.\n> +\n\nPotentially we could say more (like how to verify), but I will leave\nthat for somebody to build on top if they want.\n\n-Peff\n"}]}