{"thread":{"id":"31847","subject":"L10n regression in 1.8.0.rc2: diffstat summary (git diff --stat, git format-patch)","startedAt":"2012-10-17T10:53:20Z","lastAt":"2012-10-24T07:54:38Z","messageCount":4,"participants":["Peter Krefting","Nguyen Thai Ngoc Duy"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"201418","messageId":"alpine.DEB.2.00.1210171145360.12699@ds9.cixit.se","threadId":"31847","inReplyTo":null,"subject":"L10n regression in 1.8.0.rc2: diffstat summary (git diff --stat, git format-patch)","fromName":"Peter Krefting","fromEmail":"peter@softwolves.pp.se","sentAt":"2012-10-17T10:53:20Z","receivedAt":"2012-10-17T10:53:20Z","isPatch":false,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"Hi!\n\nThe output of \"git format-patch\" and \"git diff --stat\" no longer \nbecomes localized when using 1.8.0.rc2, compared to 1.7.12\n\nRunning both versions of \"git format-patch -1\" from the same \nrepository, with the same settings otherwise, has 1.7.12 output the \ndiffstat summary in Swedish, while 1.8.0.rc2 doesn't:\n\n   diff 1.7.12.txt 1.8.0.rc2.txt\n   8c8\n   <  1 fil ändrad, 1 tillägg(+)\n   ---\n   >  1 file changed, 1 insertion(+)\n   18c18\n   < 1.7.12\n   ---\n   > 1.8.0.rc2\n\nThe same applies to \"git diff --stat\" and \"git show --stat\". I can \nunderstand for \"git format-patch\" to default to English (but as its \noutput is ignored on read, it doesn't hurt to have it localized), but \nfor diff and show, it is annoying (even if the rest of the \"git diff\" \noutput also needs to be translated eventually).\n\n-- \n\\\\// Peter - http://www.softwolves.pp.se/\n"},{"id":"201419","messageId":"CACsJy8CS9TKGaT8+MQ_JOEQD+fgnc9HVAbr1pjQ3JE_3ZjE9=A@mail.gmail.com","threadId":"31847","inReplyTo":"alpine.DEB.2.00.1210171145360.12699@ds9.cixit.se","subject":"Re: L10n regression in 1.8.0.rc2: diffstat summary (git diff --stat, git format-patch)","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-10-17T11:51:21Z","receivedAt":"2012-10-17T11:51:21Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Wed, Oct 17, 2012 at 5:53 PM, Peter Krefting <peter@softwolves.pp.se> wrote:\n> Hi!\n>\n> The output of \"git format-patch\" and \"git diff --stat\" no longer becomes\n> localized when using 1.8.0.rc2, compared to 1.7.12\n\nIt's the result of this discussion [1]. I don't remember exactly the\nopen issues. But I think it involves drawing a line between team\nlanguage vs local language, whether team language can be anything\nother than English, the maintenance cost for supporting it. You're\nwelcome to revive the discussion. Maybe we can find a solution that is\nagreed by all parties.\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/204285/focus=204283\n-- \nDuy\n"},{"id":"201583","messageId":"alpine.DEB.2.00.1210200035220.15821@ds9.cixit.se","threadId":"31847","inReplyTo":"CACsJy8CS9TKGaT8+MQ_JOEQD+fgnc9HVAbr1pjQ3JE_3ZjE9=A@mail.gmail.com","subject":"Re: L10n regression in 1.8.0.rc2: diffstat summary (git diff --stat, git format-patch)","fromName":"Peter Krefting","fromEmail":"peter@softwolves.pp.se","sentAt":"2012-10-19T23:38:42Z","receivedAt":"2012-10-19T23:38:42Z","isPatch":false,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"Nguyen Thai Ngoc Duy:\n\n> It's the result of this discussion [1]. I don't remember exactly the\n> open issues. But I think it involves drawing a line between team\n> language vs local language, whether team language can be anything\n> other than English, the maintenance cost for supporting it\n\nLike I said, I can see that defaulting format-patch to output English \nis a good idea (since its output is \"protocol data\" and not something \nfor human consumption), it is the output from diff and show that I \nwant to have localized.\n\nI'll see if I can come up with a patch that cater for both use-cases. \nMaybe I can also fix so that log output is fully localized at the same \ntime (translating \"commit\", \"author\", \"date\" and outputting locale \ndates (although my locale usess ISO dates, so I can get proper \nformatting there already)).\n\n-- \n\\\\// Peter - http://www.softwolves.pp.se/\n"},{"id":"201798","messageId":"alpine.DEB.2.00.1210240853220.22443@ds9.cixit.se","threadId":"31847","inReplyTo":"alpine.DEB.2.00.1210200035220.15821@ds9.cixit.se","subject":"Re: L10n regression in 1.8.0.rc2: diffstat summary (git diff --stat, git format-patch)","fromName":"Peter Krefting","fromEmail":"peter@softwolves.pp.se","sentAt":"2012-10-24T07:54:38Z","receivedAt":"2012-10-24T07:54:38Z","isPatch":false,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"> I'll see if I can come up with a patch that cater for both use-cases.\n\nI see that I forgot to Cc you; please see the patch series starting \nwith the Subject \"[RFC PATCH 0/2] Localize log output\", which I posted \nhere yesterday.\n\n-- \n\\\\// Peter - http://www.softwolves.pp.se/\n"}]}