{"thread":{"id":"31822","subject":"make test","startedAt":"2012-10-15T10:36:00Z","lastAt":"2012-10-17T08:30:11Z","messageCount":12,"participants":["Joachim Schmitz","Johannes Sixt","Andreas Schwab"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"201239","messageId":"k5gov5$fe1$1@ger.gmane.org","threadId":"31822","inReplyTo":null,"subject":"make test","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-15T10:36:00Z","receivedAt":"2012-10-15T10:36:00Z","isPatch":false,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"Hi folks\n\nI'm trying to understand why certain tests in 'make test' fail. Here's the \nfirst one\n\n$ ../git --version\ngit version 1.8.0.rc2.5.g6b89306\n$ GIT_TEST_CMP_USE_COPIED_CONTEXT=true ./t0000-basic.sh # our diff doesn't \nunderstand -u\nok 1 - .git/objects should be empty after git init in an empty repo\n...\nok 3 - success is reported like this\nnot ok 4 - pretend we have a known breakage # TODO known breakage\n\n    This is expected, right?\n\nok 5 - pretend we have fixed a known breakage (run in sub test-lib)\n...\nok 11 - tests clean up after themselves\n\n    the next is not though? Why might it be failing, where to check?\n\nnot ok - 12 tests clean up even on failures\n#\n#               mkdir failing-cleanup &&\n#               (\n#               cd failing-cleanup &&\n#\n#               cat >failing-cleanup.sh <<-EOF &&\n#               #!/bin/sh\n#\n#               test_description='Failing tests with cleanup commands'\n#\n#               # Point to the t/test-lib.sh, which isn't in ../ as usual\n#               TEST_DIRECTORY=\"/home/jojo/git/git/t\"\n#               . \"$TEST_DIRECTORY\"/test-lib.sh\n#\n#               test_expect_success 'tests clean up even after a failure' '\n#                       touch clean-after-failure &&\n#                       test_when_finished rm clean-after-failure &&\n#                       (exit 1)\n#               '\n#               test_expect_success 'failure to clean up causes the test to \nfail' '\n#                       test_when_finished \"(exit 2)\"\n#               '\n#               test_done\n#\n#               EOF\n#\n#               chmod +x failing-cleanup.sh &&\n#               test_must_fail ./failing-cleanup.sh >out 2>err &&\n#               ! test -s err &&\n#               ! test -f \"trash \ndirectory.failing-cleanup/clean-after-failure\" &&\n#               sed -e 's/Z$//' -e 's/^> //' >expect <<-\\EOF &&\n#               > not ok - 1 tests clean up even after a failure\n#               > #     Z\n#               > #     touch clean-after-failure &&\n#               > #     test_when_finished rm clean-after-failure &&\n#               > #     (exit 1)\n#               > #     Z\n#               > not ok - 2 failure to clean up causes the test to fail\n#               > #     Z\n#               > #     test_when_finished \"(exit 2)\"\n#               > #     Z\n#               > # failed 2 among 2 test(s)\n#               > 1..2\n#               EOF\n#               test_cmp expect out\n#               )\n#\nok 13 - git update-index without --add should fail adding\n...\nok 47 - very long name in the index handled sanely\n# still have 1 known breakage(s)\n# failed 1 among remaining 46 test(s)\n1..47\n\nBye, Jojo \n"},{"id":"201241","messageId":"507BEB12.9040101@viscovery.net","threadId":"31822","inReplyTo":"k5gov5$fe1$1@ger.gmane.org","subject":"Re: make test","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2012-10-15T10:53:06Z","receivedAt":"2012-10-15T10:53:06Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 10/15/2012 12:36, schrieb Joachim Schmitz:\n> not ok 4 - pretend we have a known breakage # TODO known breakage\n> \n>    This is expected, right?\n\nRight.\n\n>    the next is not though? Why might it be failing, where to check?\n> \n> not ok - 12 tests clean up even on failures\n> #\n> #               mkdir failing-cleanup &&\n> #...\n> #               test_cmp expect out\n> #               )\n> #\n\nFirst thing:\n\n  ./t0000-basic.sh -v -i\n\nand if that does not give sufficient clues,\n\n  $SHELL_PATH -x ./t0000-basic.sh -v -i\n\n(Beware, though: in some cases, the latter gives additional failures, in\nparticular, when the stderr of a command is checked for with test_cmp\ninstead of grep because the 'actual' results contain the shell command\nlogs, which are not in the 'expected' results.)\n\n-- Hannes,\n"},{"id":"201243","messageId":"003101cdaac4$430b7a30$c9226e90$@schmitz-digital.de","threadId":"31822","inReplyTo":"507BEB12.9040101@viscovery.net","subject":"RE: make test","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-15T11:00:14Z","receivedAt":"2012-10-15T11:00:14Z","isPatch":false,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Johannes Sixt [mailto:j.sixt@viscovery.net]\n> Sent: Monday, October 15, 2012 12:53 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: make test\n> \n> Am 10/15/2012 12:36, schrieb Joachim Schmitz:\n> > not ok 4 - pretend we have a known breakage # TODO known breakage\n> >\n> >    This is expected, right?\n> \n> Right.\n> \n> >    the next is not though? Why might it be failing, where to check?\n> >\n> > not ok - 12 tests clean up even on failures\n> > #\n> > #               mkdir failing-cleanup &&\n> > #...\n> > #               test_cmp expect out\n> > #               )\n> > #\n> \n> First thing:\n> \n>   ./t0000-basic.sh -v -i\n\nOK, I should have mentioned that I did look with -v :\nnot ok - 12 tests clean up even on failures\n#\n#               mkdir failing-cleanup &&\n#               (\n#               cd failing-cleanup &&\n#\n#               cat >failing-cleanup.sh <<-EOF &&\n#               #!/bin/sh\n#\n#               test_description='Failing tests with cleanup commands'\n#\n#               # Point to the t/test-lib.sh, which isn't in ../ as usual\n#               TEST_DIRECTORY=\"/home/jojo/git/git/t\"\n#               . \"$TEST_DIRECTORY\"/test-lib.sh\n#\n#               test_expect_success 'tests clean up even after a failure' '\n#                       touch clean-after-failure &&\n#                       test_when_finished rm clean-after-failure &&\n#                       (exit 1)\n#               '\n#               test_expect_success 'failure to clean up causes the test to fail' '\n#                       test_when_finished \"(exit 2)\"\n#               '\n#               test_done\n#\n#               EOF\n#\n#               chmod +x failing-cleanup.sh &&\n#               test_must_fail ./failing-cleanup.sh >out 2>err &&\n#               ! test -s err &&\n#               ! test -f \"trash directory.failing-cleanup/clean-after-failure\" &&\n#               sed -e 's/Z$//' -e 's/^> //' >expect <<-\\EOF &&\n#               > not ok - 1 tests clean up even after a failure\n#               > #     Z\n#               > #     touch clean-after-failure &&\n#               > #     test_when_finished rm clean-after-failure &&\n#               > #     (exit 1)\n#               > #     Z\n#               > not ok - 2 failure to clean up causes the test to fail\n#               > #     Z\n#               > #     test_when_finished \"(exit 2)\"\n#               > #     Z\n#               > # failed 2 among 2 test(s)\n#               > 1..2\n#               EOF\n#               test_cmp expect out\n#               )\n#\n\n> and if that does not give sufficient clues,\n> \n>   $SHELL_PATH -x ./t0000-basic.sh -v -i\n\nnot ok - 12 tests clean up even on failures\n#\n#               mkdir failing-cleanup &&\n#               (\n#               cd failing-cleanup &&\n#\n#               cat >failing-cleanup.sh <<-EOF &&\n#               #!/bin/sh\n#\n#               test_description='Failing tests with cleanup commands'\n#\n#               # Point to the t/test-lib.sh, which isn't in ../ as usual\n#               TEST_DIRECTORY=\"/home/jojo/git/git/t\"\n#               . \"$TEST_DIRECTORY\"/test-lib.sh\n#\n#               test_expect_success 'tests clean up even after a failure' '\n#                       touch clean-after-failure &&\n#                       test_when_finished rm clean-after-failure &&\n#                       (exit 1)\n#               '\n#               test_expect_success 'failure to clean up causes the test to fail' '\n#                       test_when_finished \"(exit 2)\"\n#               '\n#               test_done\n#\n#               EOF\n#\n#               chmod +x failing-cleanup.sh &&\n#               test_must_fail ./failing-cleanup.sh >out 2>err &&\n#               ! test -s err &&\n#               ! test -f \"trash directory.failing-cleanup/clean-after-failure\" &&\n#               sed -e 's/Z$//' -e 's/^> //' >expect <<-\\EOF &&\n#               > not ok - 1 tests clean up even after a failure\n#               > #     Z\n#               > #     touch clean-after-failure &&\n#               > #     test_when_finished rm clean-after-failure &&\n#               > #     (exit 1)\n#               > #     Z\n#               > not ok - 2 failure to clean up causes the test to fail\n#               > #     Z\n#               > #     test_when_finished \"(exit 2)\"\n#               > #     Z\n#               > # failed 2 among 2 test(s)\n#               > 1..2\n#               EOF\n#               test_cmp expect out\n#               )\n#\n+ die\n\nLooks identical, except for the \"die\" at the end. And still leaves me without a clue...\n\n> (Beware, though: in some cases, the latter gives additional failures, in\n> particular, when the stderr of a command is checked for with test_cmp\n> instead of grep because the 'actual' results contain the shell command\n> logs, which are not in the 'expected' results.)\n> \n> -- Hannes,\n\nBye, Jojo\n"},{"id":"201245","messageId":"507BF0EA.7000805@viscovery.net","threadId":"31822","inReplyTo":"003101cdaac4$430b7a30$c9226e90$@schmitz-digital.de","subject":"Re: make test","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2012-10-15T11:18:02Z","receivedAt":"2012-10-15T11:18:02Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 10/15/2012 13:00, schrieb Joachim Schmitz:\n>> From: Johannes Sixt [mailto:j.sixt@viscovery.net]\n>> and if that does not give sufficient clues,\n>>\n>>   $SHELL_PATH -x ./t0000-basic.sh -v -i\n> \n> not ok - 12 tests clean up even on failures\n> #...\n> + die\n> \n> Looks identical, except for the \"die\" at the end. And still leaves me without a clue...\n\nWhen I do that it begins like this (I'm on Windows):\n\nD:\\Src\\mingw-git\\t>bash -x t0000-basic.sh -v -i\n+ test_description='Test the very basics part #1.\n...\n'\n+ . ./test-lib.sh\n++ ORIGINAL_TERM=cygwin\n++ test -z ''\n+++ pwd\n++ TEST_DIRECTORY=/d/Src/mingw-git/t\n++ test -z ''\n++ TEST_OUTPUT_DIRECTORY=/d/Src/mingw-git/t\n++ GIT_BUILD_DIR=/d/Src/mingw-git/t/..\n++ /d/Src/mingw-git/t/../git\n++ test 1 '!=' 1\n++ . /d/Src/mingw-git/t/../GIT-BUILD-OPTIONS\n+++ SHELL_PATH=/bin/sh\n+++ PERL_PATH=/usr/bin/perl\n+++ DIFF=diff\n+++ PYTHON_PATH=/usr/bin/python\n+++ TAR=tar\n...\n\nIt seems you need a shell that is verbose under -x.\n\n-- Hannes\n"},{"id":"201246","messageId":"003801cdaac9$81d5bff0$85813fd0$@schmitz-digital.de","threadId":"31822","inReplyTo":"507BF0EA.7000805@viscovery.net","subject":"RE: make test","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-15T11:37:49Z","receivedAt":"2012-10-15T11:37:49Z","isPatch":false,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Johannes Sixt [mailto:j.sixt@viscovery.net]\n> Sent: Monday, October 15, 2012 1:18 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: make test\n> \n> Am 10/15/2012 13:00, schrieb Joachim Schmitz:\n> >> From: Johannes Sixt [mailto:j.sixt@viscovery.net]\n> >> and if that does not give sufficient clues,\n> >>\n> >>   $SHELL_PATH -x ./t0000-basic.sh -v -i\n> >\n> > not ok - 12 tests clean up even on failures\n> > #...\n> > + die\n> >\n> > Looks identical, except for the \"die\" at the end. And still leaves me without a clue...\n> \n> When I do that it begins like this (I'm on Windows):\n> \n> D:\\Src\\mingw-git\\t>bash -x t0000-basic.sh -v -i\n> + test_description='Test the very basics part #1.\n> ...\n> '\n> + . ./test-lib.sh\n> ++ ORIGINAL_TERM=cygwin\n> ++ test -z ''\n> +++ pwd\n> ++ TEST_DIRECTORY=/d/Src/mingw-git/t\n> ++ test -z ''\n> ++ TEST_OUTPUT_DIRECTORY=/d/Src/mingw-git/t\n> ++ GIT_BUILD_DIR=/d/Src/mingw-git/t/..\n> ++ /d/Src/mingw-git/t/../git\n> ++ test 1 '!=' 1\n> ++ . /d/Src/mingw-git/t/../GIT-BUILD-OPTIONS\n> +++ SHELL_PATH=/bin/sh\n> +++ PERL_PATH=/usr/bin/perl\n> +++ DIFF=diff\n> +++ PYTHON_PATH=/usr/bin/python\n> +++ TAR=tar\n> ...\n> \n> It seems you need a shell that is verbose under -x.\n\n\nErm, no, I left that part out...\n\n+ . ./test-lib.sh\n++ ORIGINAL_TERM=dumb\n++ test -z ''\n+++ pwd\n++ TEST_DIRECTORY=/home/jojo/git/git/t\n++ test -z ''\n++ TEST_OUTPUT_DIRECTORY=/home/jojo/git/git/t\n++ GIT_BUILD_DIR=/home/jojo/git/git/t/..\n++ /home/jojo/git/git/t/../git\n++ test 1 '!=' 1\n++ . /home/jojo/git/git/t/../GIT-BUILD-OPTIONS\n+++ SHELL_PATH=/bin/sh\n+++ PERL_PATH=/usr/local/bin/perl\n+++ DIFF=diff\n+++ PYTHON_PATH=/usr/local/bin/python\n+++ TAR=tar\n+++ NO_CURL=\n+++ USE_LIBPCRE=\n+++ NO_PERL=\n+++ NO_PYTHON=\n+++ NO_UNIX_SOCKETS=\n+++ GIT_TEST_CMP_USE_COPIED_CONTEXT=YesPlease\n+++ NO_GETTEXT=\n+++ GETTEXT_POISON=\n++ export PERL_PATH SHELL_PATH\n++ case \"$GIT_TEST_TEE_STARTED, $* \" in\n++ LANG=C\n++ LC_ALL=C\n++ PAGER=cat\n++ TZ=UTC\n++ TERM=dumb\n++ export LANG LC_ALL PAGER TERM TZ\n++ EDITOR=:\n+++ /usr/local/bin/perl -e '\n        my @env = keys %ENV;\n        my $ok = join(\"|\", qw(\n                TRACE\n                DEBUG\n                USE_LOOKUP\n                TEST\n                .*_TEST\n                PROVE\n                VALGRIND\n                PERF_AGGREGATING_LATER\n        ));\n        my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n        print join(\"\\n\", @vars);\n'\n++ unset VISUAL EMAIL LANGUAGE COLUMNS GIT_AUTHOR_NAME GIT_MERGE_AUTOEDIT GIT_EXEC_PATH GIT_ATTR_NOSYSTEM GIT_MERGE_VERBOSITY\nGIT_TEMPLATE_DIR GIT_CONFIG_NOSYSTEM GIT_AUTHOR_EMAIL GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL\n++ unset XDG_CONFIG_HOME\n++ GIT_AUTHOR_EMAIL=author@example.com\n++ GIT_AUTHOR_NAME='A U Thor'\n++ GIT_COMMITTER_EMAIL=committer@example.com\n++ GIT_COMMITTER_NAME='C O Mitter'\n++ GIT_MERGE_VERBOSITY=5\n++ GIT_MERGE_AUTOEDIT=no\n++ export GIT_MERGE_VERBOSITY GIT_MERGE_AUTOEDIT\n++ export GIT_AUTHOR_EMAIL GIT_AUTHOR_NAME\n++ export GIT_COMMITTER_EMAIL GIT_COMMITTER_NAME\n++ export EDITOR\n++ expr '  ' : '.* --valgrind '\n++ test -n ''\n++ unset CDPATH\n++ unset GREP_OPTIONS\n++ case $(echo $GIT_TRACE |tr \"[A-Z]\" \"[a-z]\") in\n+++ echo\n+++ tr '[A-Z]' '[a-z]'\n++ _x05='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'\n++\n_x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-\nf][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0\n-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'\n++ _z40=0000000000000000000000000000000000000000\n++ LF='\n'\n++ export _x05 _x40 _z40 LF\n++ '[' xdumb '!=' xdumb ']'\n++ test 2 -ne 0\n++ case \"$1\" in\n++ verbose=t\n++ shift\n++ test 1 -ne 0\n++ case \"$1\" in\n++ immediate=t\n++ shift\n++ test 0 -ne 0\n++ test -n ''\n++ test 'Test the very basics part #1.\nThe rest of the test suite does not check the basic operation of git\nplumbing commands to work very carefully.  Their job is to concentrate\non tricky features that caused bugs in the past to detect regression.\n\nThis test runs very basic features, like registering things in cache,\nwriting tree, etc.\n\nNote that this test *deliberately* hard-codes many expected object\nIDs.  When object ID computation changes, like in the previous case of\nswapping compression and hashing order, the person who is making the\nmodification *should* take notice and update the test vectors here.\n' '!=' ''\n++ test '' = t\n++ exec\n++ exec\n++ test t = t\n++ exec\n++ test_failure=0\n++ test_count=0\n++ test_fixed=0\n++ test_broken=0\n++ test_success=0\n++ test_external_has_tap=0\n++ GIT_EXIT_OK=\n++ trap die EXIT\n++ . /home/jojo/git/git/t/test-lib-functions.sh\n+++ satisfied_prereq=' '\n+++ lazily_testable_prereq=\n+++ lazily_tested_prereq=\n++ test -n ''\n++ test -n ''\n++ git_bin_dir=/home/jojo/git/git/t/../bin-wrappers\n++ test -x /home/jojo/git/git/t/../bin-wrappers/git\n++\nPATH=/home/jojo/git/git/t/../bin-wrappers:/home/jojo/git/git/t/../bin-wrappers:/bin:/bin/unsupported:/usr/bin:/usr/ucb:/usr/local/bi\nn:/usr/tandem/java/bin:/home/jojo/bin\n++ GIT_EXEC_PATH=/home/jojo/git/git/t/..\n++ test -n ''\n++ GIT_TEMPLATE_DIR=/home/jojo/git/git/t/../templates/blt\n++ unset GIT_CONFIG\n++ GIT_CONFIG_NOSYSTEM=1\n++ GIT_ATTR_NOSYSTEM=1\n++ export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG_NOSYSTEM GIT_ATTR_NOSYSTEM\n++ test -z ''\n++ test -n YesPlease\n++ GIT_TEST_CMP='diff -c'\n++ GITPERLLIB=/home/jojo/git/git/t/../perl/blib/lib:/home/jojo/git/git/t/../perl/blib/arch/auto/Git\n++ export GITPERLLIB\n++ test -d /home/jojo/git/git/t/../templates/blt\n++ test -z ''\n++ test -z ''\n++ GITPYTHONLIB=/home/jojo/git/git/t/../git_remote_helpers/build/lib\n++ export GITPYTHONLIB\n++ test -d /home/jojo/git/git/t/../git_remote_helpers/build\n++ test -x /home/jojo/git/git/t/../test-chmtime\n+++ basename ./t0000-basic.sh .sh\n++ test='trash directory.t0000-basic'\n++ test -n ''\n++ case \"$test\" in\n++ TRASH_DIRECTORY='/home/jojo/git/git/t/trash directory.t0000-basic'\n++ test '!' -z ''\n++ remove_trash='/home/jojo/git/git/t/trash directory.t0000-basic'\n++ rm -fr 'trash directory.t0000-basic'\n++ HOME='/home/jojo/git/git/t/trash directory.t0000-basic'\n++ export HOME\n++ test -z ''\n++ test_create_repo 'trash directory.t0000-basic'\n++ test 1 = 1\n++ repo='trash directory.t0000-basic'\n++ mkdir -p 'trash directory.t0000-basic'\n++ cd 'trash directory.t0000-basic'\n++ /home/jojo/git/git/t/../git-init --template=/home/jojo/git/git/t/../templates/blt/\nInitialized empty Git repository in /home/jojo/git/git/t/trash directory.t0000-basic/.git/\n++ mv .git/hooks .git/hooks-disabled\n++ cd -P 'trash directory.t0000-basic'\n++ this_test=t0000-basic.sh\n++ this_test=t0000\n++ case $(uname -s) in\n+++ uname -s\n++ test_set_prereq POSIXPERM\n++ satisfied_prereq=' POSIXPERM '\n++ test_set_prereq BSLASHPSPEC\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC '\n++ test_set_prereq EXECKEEPSPID\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID '\n++ test_set_prereq NOT_MINGW\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW '\n++ COLUMNS=1\n++ test 1 = 1\n++ test_set_prereq COLUMNS_CAN_BE_1\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW COLUMNS_CAN_BE_1 '\n++ test -z ''\n++ test_set_prereq PERL\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW COLUMNS_CAN_BE_1 PERL '\n++ test -z ''\n++ test_set_prereq PYTHON\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW COLUMNS_CAN_BE_1 PERL PYTHON '\n++ test -n ''\n++ test -z ''\n++ test_set_prereq GETTEXT\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW COLUMNS_CAN_BE_1 PERL PYTHON GETTEXT '\n++ test -n ''\n++ test_set_prereq C_LOCALE_OUTPUT\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW COLUMNS_CAN_BE_1 PERL PYTHON GETTEXT C_LOCALE_OUTPUT '\n++ test_lazy_prereq SYMLINKS '\n        # test whether the filesystem supports symbolic links\n        ln -s x y && test -h y\n'\n++ lazily_testable_prereq='SYMLINKS '\n++ eval 'test_prereq_lazily_SYMLINKS=$2'\n+++ test_prereq_lazily_SYMLINKS='\n        # test whether the filesystem supports symbolic links\n        ln -s x y && test -h y\n'\n++ test_lazy_prereq CASE_INSENSITIVE_FS '\n        echo good >CamelCase &&\n        echo bad >camelcase &&\n        test \"$(cat CamelCase)\" != good\n'\n++ lazily_testable_prereq='SYMLINKS CASE_INSENSITIVE_FS '\n++ eval 'test_prereq_lazily_CASE_INSENSITIVE_FS=$2'\n+++ test_prereq_lazily_CASE_INSENSITIVE_FS='\n        echo good >CamelCase &&\n        echo bad >camelcase &&\n        test \"$(cat CamelCase)\" != good\n'\n++ test_lazy_prereq UTF8_NFD_TO_NFC '\n        # check whether FS converts nfd unicode to nfc\n        auml=$(printf \"\\303\\244\")\n        aumlcdiar=$(printf \"\\141\\314\\210\")\n        >\"$auml\" &&\n        case \"$(echo *)\" in\n        \"$aumlcdiar\")\n                true ;;\n        *)\n                false ;;\n        esac\n'\n++ lazily_testable_prereq='SYMLINKS CASE_INSENSITIVE_FS UTF8_NFD_TO_NFC '\n++ eval 'test_prereq_lazily_UTF8_NFD_TO_NFC=$2'\n+++ test_prereq_lazily_UTF8_NFD_TO_NFC='\n        # check whether FS converts nfd unicode to nfc\n        auml=$(printf \"\\303\\244\")\n        aumlcdiar=$(printf \"\\141\\314\\210\")\n        >\"$auml\" &&\n        case \"$(echo *)\" in\n        \"$aumlcdiar\")\n                true ;;\n        *)\n                false ;;\n        esac\n'\n++ test -w /\n++ test_set_prereq SANITY\n++ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW COLUMNS_CAN_BE_1 PERL PYTHON GETTEXT C_LOCALE_OUTPUT SANITY '\n+ test_expect_success '.git/objects should be empty after git init in an empty repo' '\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n'\n+ test 2 = 3\n+ test_prereq=\n+ test 2 = 2\n+ export test_prereq\n+ test_skip '.git/objects should be empty after git init in an empty repo' '\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n'\n+ test_count=1\n+ to_skip=\n+ test -z ''\n+ test -n ''\n+ case \"$to_skip\" in\n+ false\n+ say 'expecting success:\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n'\n+ say_color info 'expecting success:\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n'\n+ test -z info\n+ shift\n+ echo 'expecting success:\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n'\nexpecting success:\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n\n+ test_run_ '\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n'\n+ test_cleanup=:\n+ expecting_failure=\n+ test_eval_ '\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n'\n+ eval '\n        find .git/objects -type f -print >should-be-empty &&\n        test_line_count = 0 should-be-empty\n'\n++ find .git/objects -type f -print\n++ test_line_count = 0 should-be-empty\n++ test 3 '!=' 3\n+++ wc -l\n++ test 0 = 0\n+ eval_ret=0\n+ test -z t\n+ test 0 = 0\n+ setup_malloc_check\n+ MALLOC_CHECK_=3\n+ MALLOC_PERTURB_=165\n+ export MALLOC_CHECK_ MALLOC_PERTURB_\n+ test_eval_ :\n+ eval :\n++\n+ teardown_malloc_check\n+ unset MALLOC_CHECK_ MALLOC_PERTURB_\n+ test t = t\n+ test -n ''\n+ return 0\n+ test_ok_ '.git/objects should be empty after git init in an empty repo'\n+ test_success=1\n+ say_color '' 'ok 1 - .git/objects should be empty after git init in an empty repo'\n+ test -z ''\n+ test -n ''\n+ shift\n+ echo 'ok 1 - .git/objects should be empty after git init in an empty repo'\nok 1 - .git/objects should be empty after git init in an empty repo\n+ echo ''\n\n+ test_expect_success '.git/objects should have 3 subdirectories' '\n        find .git/objects -type d -print >full-of-directories &&\n        test_line_count = 3 full-of-directories\n'\n+ test 2 = 3\n+ test_prereq=\n...\n\nBye, Jojo\n"},{"id":"201248","messageId":"507BF8FE.1060502@viscovery.net","threadId":"31822","inReplyTo":"003801cdaac9$81d5bff0$85813fd0$@schmitz-digital.de","subject":"Re: make test","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2012-10-15T11:52:30Z","receivedAt":"2012-10-15T11:52:30Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 10/15/2012 13:37, schrieb Joachim Schmitz:\n> ...\n> + eval '\n>         find .git/objects -type f -print >should-be-empty &&\n>         test_line_count = 0 should-be-empty\n> '\n> ++ find .git/objects -type f -print\n> ++ test_line_count = 0 should-be-empty\n> ++ test 3 '!=' 3\n> +++ wc -l\n> ++ test 0 = 0\n> + eval_ret=0\n\nThis is the key line. If it is 'eval_ret=1' (or other non-zero value),\nthen the test failed, and the lines above it usually indicate where in the\ntest snippet the failure occurred.\n\n-- Hannes\n"},{"id":"201250","messageId":"003901cdaacc$6f87e640$4e97b2c0$@schmitz-digital.de","threadId":"31822","inReplyTo":"507BF8FE.1060502@viscovery.net","subject":"RE: make test","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-15T11:58:46Z","receivedAt":"2012-10-15T11:58:46Z","isPatch":false,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"\n\n> -----Original Message-----\n> From: Johannes Sixt [mailto:j.sixt@viscovery.net]\n> Sent: Monday, October 15, 2012 1:53 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: make test\n> \n> Am 10/15/2012 13:37, schrieb Joachim Schmitz:\n> > ...\n> > + eval '\n> >         find .git/objects -type f -print >should-be-empty &&\n> >         test_line_count = 0 should-be-empty\n> > '\n> > ++ find .git/objects -type f -print\n> > ++ test_line_count = 0 should-be-empty\n> > ++ test 3 '!=' 3\n> > +++ wc -l\n> > ++ test 0 = 0\n> > + eval_ret=0\n> \n> This is the key line. If it is 'eval_ret=1' (or other non-zero value),\n> then the test failed, and the lines above it usually indicate where in the\n> test snippet the failure occurred.\n\n\n...\n++ mkdir failing-cleanup\n++ cd failing-cleanup\n++ cat\n++ chmod +x failing-cleanup.sh\n++ test_must_fail ./failing-cleanup.sh\n+ eval_ret=1\n+ test -z t\n+ test 1 = 0\n+ test -n ''\n+ test t = t\n+ test -n ''\n+ return 1\n+ test_failure_ 'tests clean up even on failures' '\n...\n\nThis part?\n"},{"id":"201251","messageId":"507BFD03.7060208@viscovery.net","threadId":"31822","inReplyTo":"003901cdaacc$6f87e640$4e97b2c0$@schmitz-digital.de","subject":"Re: make test","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2012-10-15T12:09:39Z","receivedAt":"2012-10-15T12:09:39Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 10/15/2012 13:58, schrieb Joachim Schmitz:\n> ++ mkdir failing-cleanup\n> ++ cd failing-cleanup\n> ++ cat\n> ++ chmod +x failing-cleanup.sh\n> ++ test_must_fail ./failing-cleanup.sh\n> + eval_ret=1\n\nI wonder why the log does not show the commands of function\ntest_must_fail. Is there a 'set +x' hidden somewhere? Run\n./failing-cleanup.sh manually. Check its exit code (it should be non-zero,\nbut not something strange like 127 and above; see test_must_fail()) and\ndig further from there. I'll stop here.\n\n-- Hannes\n"},{"id":"201252","messageId":"m2mwznrk0c.fsf@igel.home","threadId":"31822","inReplyTo":"507BFD03.7060208@viscovery.net","subject":"Re: make test","fromName":"Andreas Schwab","fromEmail":"schwab@linux-m68k.org","sentAt":"2012-10-15T12:34:59Z","receivedAt":"2012-10-15T12:34:59Z","isPatch":false,"sender":{"key":"schwab@linux-m68k.org","avatar":"https://avatars.githubusercontent.com/u/2175493?v=4"},"body":"Johannes Sixt <j.sixt@viscovery.net> writes:\n\n> Am 10/15/2012 13:58, schrieb Joachim Schmitz:\n>> ++ mkdir failing-cleanup\n>> ++ cd failing-cleanup\n>> ++ cat\n>> ++ chmod +x failing-cleanup.sh\n>> ++ test_must_fail ./failing-cleanup.sh\n>> + eval_ret=1\n>\n> I wonder why the log does not show the commands of function\n> test_must_fail.\n\nThat's because stderr is redirected.\n\nAndreas.\n\n-- \nAndreas Schwab, schwab@linux-m68k.org\nGPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5\n\"And now for something completely different.\"\n"},{"id":"201253","messageId":"003f01cdaad7$82969690$87c3c3b0$@schmitz-digital.de","threadId":"31822","inReplyTo":"507BFD03.7060208@viscovery.net","subject":"RE: make test","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-15T13:18:03Z","receivedAt":"2012-10-15T13:18:03Z","isPatch":false,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Johannes Sixt [mailto:j.sixt@viscovery.net]\n> Sent: Monday, October 15, 2012 2:10 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: make test\n> \n> Am 10/15/2012 13:58, schrieb Joachim Schmitz:\n> > ++ mkdir failing-cleanup\n> > ++ cd failing-cleanup\n> > ++ cat\n> > ++ chmod +x failing-cleanup.sh\n> > ++ test_must_fail ./failing-cleanup.sh\n> > + eval_ret=1\n> \n> I wonder why the log does not show the commands of function\n> test_must_fail. Is there a 'set +x' hidden somewhere? Run\n> ./failing-cleanup.sh manually. Check its exit code (it should be non-zero,\n> but not something strange like 127 and above; see test_must_fail()) and\n> dig further from there. I'll stop here.\n\n\nIt returns 0.\n"},{"id":"201254","messageId":"004001cdaad7$8bb72aa0$a3257fe0$@schmitz-digital.de","threadId":"31822","inReplyTo":"m2mwznrk0c.fsf@igel.home","subject":"RE: make test","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-15T13:18:19Z","receivedAt":"2012-10-15T13:18:19Z","isPatch":false,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Andreas Schwab [mailto:schwab@linux-m68k.org]\n> Sent: Monday, October 15, 2012 2:35 PM\n> To: Johannes Sixt\n> Cc: Joachim Schmitz; git@vger.kernel.org\n> Subject: Re: make test\n> \n> Johannes Sixt <j.sixt@viscovery.net> writes:\n> \n> > Am 10/15/2012 13:58, schrieb Joachim Schmitz:\n> >> ++ mkdir failing-cleanup\n> >> ++ cd failing-cleanup\n> >> ++ cat\n> >> ++ chmod +x failing-cleanup.sh\n> >> ++ test_must_fail ./failing-cleanup.sh\n> >> + eval_ret=1\n> >\n> > I wonder why the log does not show the commands of function\n> > test_must_fail.\n> \n> That's because stderr is redirected.\n> \n\ncat err\n++ ./failing-cleanup.sh\n++ exit_code=0\n++ test 0 = 0\n++ echo 'test_must_fail: command succeeded: ./failing-cleanup.sh'\ntest_must_fail: command succeeded: ./failing-cleanup.sh\n++ return 1\n"},{"id":"201415","messageId":"002901cdac41$a0d381c0$e27a8540$@schmitz-digital.de","threadId":"31822","inReplyTo":"m2mwznrk0c.fsf@igel.home","subject":"RE: make test","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-10-17T08:30:11Z","receivedAt":"2012-10-17T08:30:11Z","isPatch":false,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Joachim Schmitz [mailto:jojo@schmitz-digital.de]\n> Sent: Monday, October 15, 2012 3:18 PM\n> To: 'Andreas Schwab'; 'Johannes Sixt'\n> Cc: 'git@vger.kernel.org'\n> Subject: RE: make test\n> \n> > From: Andreas Schwab [mailto:schwab@linux-m68k.org]\n> > Sent: Monday, October 15, 2012 2:35 PM\n> > To: Johannes Sixt\n> > Cc: Joachim Schmitz; git@vger.kernel.org\n> > Subject: Re: make test\n> >\n> > Johannes Sixt <j.sixt@viscovery.net> writes:\n> >\n> > > Am 10/15/2012 13:58, schrieb Joachim Schmitz:\n> > >> ++ mkdir failing-cleanup\n> > >> ++ cd failing-cleanup\n> > >> ++ cat\n> > >> ++ chmod +x failing-cleanup.sh\n> > >> ++ test_must_fail ./failing-cleanup.sh\n> > >> + eval_ret=1\n> > >\n> > > I wonder why the log does not show the commands of function\n> > > test_must_fail.\n> >\n> > That's because stderr is redirected.\n> >\n> \n> cat err\n> ++ ./failing-cleanup.sh\n> ++ exit_code=0\n> ++ test 0 = 0\n> ++ echo 'test_must_fail: command succeeded: ./failing-cleanup.sh'\n> test_must_fail: command succeeded: ./failing-cleanup.sh\n> ++ return 1\n\nThat test (as well as quite a few more) do pass when using bash rather than our sh (which really is a ksh)\n\nBye, Jojo\n"}]}