{"thread":{"id":"31802","subject":"[PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes","startedAt":"2012-10-13T17:44:33Z","lastAt":"2012-10-14T02:37:09Z","messageCount":2,"participants":["Ramsay Jones","Nguyen Thai Ngoc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"201084","messageId":"5079A881.7010802@ramsay1.demon.co.uk","threadId":"31802","inReplyTo":null,"subject":"[PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2012-10-13T17:44:33Z","receivedAt":"2012-10-13T17:44:33Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Junio,\n\nThis test in the current pu branch (commit bb0e6bf \"Merge branch\n'aw/rebase-am-failure-detection' into pu\", 11-10-2012) overwrites\nthe contents of t/.gitattributes. Note that the merge of the two\nbranches 'nd/wildmatch' and 'nd/attr-match-optim-more' both add\nnew tests at the end, and *both* sets initially 'cd ..' ...\n\nATB,\nRamsay Jones\n\n t/t0003-attributes.sh | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh\nindex 7ed288f..fe80af7 100755\n--- a/t/t0003-attributes.sh\n+++ b/t/t0003-attributes.sh\n@@ -247,7 +247,6 @@ test_expect_success 'patterns starting with exclamation' '\n '\n \n test_expect_success '\"**\" test' '\n-\tcd .. &&\n \techo \"**/f foo=bar\" >.gitattributes &&\n \tcat <<\\EOF >expect &&\n f: foo: bar\n-- \n1.7.12\n"},{"id":"201113","messageId":"CACsJy8B0n8O74pXMqbzEjSuoJSuWd=MW+zZJakTZ5z6WhVMWng@mail.gmail.com","threadId":"31802","inReplyTo":"5079A881.7010802@ramsay1.demon.co.uk","subject":"Re: [PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-10-14T02:37:09Z","receivedAt":"2012-10-14T02:37:09Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Sun, Oct 14, 2012 at 12:44 AM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n>\n> Hi Junio,\n>\n> This test in the current pu branch (commit bb0e6bf \"Merge branch\n> 'aw/rebase-am-failure-detection' into pu\", 11-10-2012) overwrites\n> the contents of t/.gitattributes. Note that the merge of the two\n> branches 'nd/wildmatch' and 'nd/attr-match-optim-more' both add\n> new tests at the end, and *both* sets initially 'cd ..' ...\n\nI'm resending nd/wildmatch to move the tests before bare repo tests so\n\"cd ..\" is no longer necessary. nd/attr-match-optim-more has the same\nfix.\n\n>  t/t0003-attributes.sh | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh\n> index 7ed288f..fe80af7 100755\n> --- a/t/t0003-attributes.sh\n> +++ b/t/t0003-attributes.sh\n> @@ -247,7 +247,6 @@ test_expect_success 'patterns starting with exclamation' '\n>  '\n>\n>  test_expect_success '\"**\" test' '\n> -       cd .. &&\n>         echo \"**/f foo=bar\" >.gitattributes &&\n>         cat <<\\EOF >expect &&\n>  f: foo: bar\n> --\n> 1.7.12\n>\n\n\n\n-- \nDuy\n"}]}