{"thread":{"id":"31767","subject":"[PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH","startedAt":"2012-10-09T14:26:11Z","lastAt":"2012-10-09T14:26:11Z","messageCount":1,"participants":["Øyvind A. Holm"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"200836","messageId":"1349792771-7936-1-git-send-email-sunny@sunbase.org","threadId":"31767","inReplyTo":null,"subject":"[PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH","fromName":"Øyvind A. Holm","fromEmail":"sunny@sunbase.org","sentAt":"2012-10-09T14:26:11Z","receivedAt":"2012-10-09T14:26:11Z","isPatch":true,"sender":{"key":"sunny@sunbase.org","avatar":"https://avatars.githubusercontent.com/u/113445?v=4"},"body":"From: \"Øyvind A. Holm\" <sunny@sunbase.org>\n\n40bfbde (\"build: don't duplicate substitution of make variables\",\n2012-09-11) breaks make by removing a necessary comma at the end of\n\"CC_LD_DYNPATH=-rpath\" in line 414.\n\nWhen executing \"./configure --with-zlib=PATH\", this resulted in\n\n      [...]\n      CC xdiff/xhistogram.o\n      AR xdiff/lib.a\n      LINK git-credential-store\n  /usr/bin/ld: bad -rpath option\n  collect2: ld returned 1 exit status\n  make: *** [git-credential-store] Error 1\n  $\n\nduring make.\n\nSigned-off-by: Øyvind A. Holm <sunny@sunbase.org>\n---\n configure.ac | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex da1f41f..c85888c 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -411,7 +411,7 @@ else\n       LDFLAGS=\"${SAVE_LDFLAGS}\"\n    ])\n    if test \"$git_cv_ld_wl_rpath\" = \"yes\"; then\n-      CC_LD_DYNPATH=-Wl,-rpath\n+      CC_LD_DYNPATH=-Wl,-rpath,\n    else\n       AC_CACHE_CHECK([if linker supports -rpath], git_cv_ld_rpath, [\n          SAVE_LDFLAGS=\"${LDFLAGS}\"\n-- \n1.8.0.rc0.18.gf84667d\n"}]}