{"thread":{"id":"31612","subject":"[PATCH] Improve legibility of test_expect_code output","startedAt":"2012-09-19T22:38:30Z","lastAt":"2012-09-20T18:05:00Z","messageCount":9,"participants":["Adam Spiers","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"199542","messageId":"1348094310-11214-1-git-send-email-git@adamspiers.org","threadId":"31612","inReplyTo":null,"subject":"[PATCH] Improve legibility of test_expect_code output","fromName":"Adam Spiers","fromEmail":"git@adamspiers.org","sentAt":"2012-09-19T22:38:30Z","receivedAt":"2012-09-19T22:38:30Z","isPatch":true,"sender":{"key":"git@adamspiers.org","avatar":"https://avatars.githubusercontent.com/u/100738?v=4"},"body":"---\n t/test-lib-functions.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n mode change 100644 => 100755 t/test-lib-functions.sh\n\ndiff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh\nold mode 100644\nnew mode 100755\nindex 8889ba5..e022e73\n--- a/t/test-lib-functions.sh\n+++ b/t/test-lib-functions.sh\n@@ -562,7 +562,7 @@ test_expect_code () {\n \t\treturn 0\n \tfi\n \n-\techo >&2 \"test_expect_code: command exited with $exit_code, we wanted $want_code $*\"\n+\techo >&2 \"test_expect_code: command exited with $exit_code, we wanted $want_code from: $*\"\n \treturn 1\n }\n \n-- \n1.7.12.147.g6d168f4\n"},{"id":"199554","messageId":"7vboh1eew2.fsf@alter.siamese.dyndns.org","threadId":"31612","inReplyTo":"1348094310-11214-1-git-send-email-git@adamspiers.org","subject":"Re: [PATCH] Improve legibility of test_expect_code output","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-20T00:06:53Z","receivedAt":"2012-09-20T00:06:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Adam Spiers <git@adamspiers.org> writes:\n\n> ---\n\nNo explanation why this is a good idea, nor sign-off?\n\n>  t/test-lib-functions.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>  mode change 100644 => 100755 t/test-lib-functions.sh\n>\n> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh\n> old mode 100644\n> new mode 100755\n> index 8889ba5..e022e73\n> --- a/t/test-lib-functions.sh\n> +++ b/t/test-lib-functions.sh\n> @@ -562,7 +562,7 @@ test_expect_code () {\n>  \t\treturn 0\n>  \tfi\n>  \n> -\techo >&2 \"test_expect_code: command exited with $exit_code, we wanted $want_code $*\"\n> +\techo >&2 \"test_expect_code: command exited with $exit_code, we wanted $want_code from: $*\"\n>  \treturn 1\n>  }\n"},{"id":"199557","messageId":"CAOkDyE-x5NeZX2tpp3C9Kkwb1kPniHptB9ERvtpx2XODufaW=A@mail.gmail.com","threadId":"31612","inReplyTo":"7vboh1eew2.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Improve legibility of test_expect_code output","fromName":"Adam Spiers","fromEmail":"git@adamspiers.org","sentAt":"2012-09-20T00:25:51Z","receivedAt":"2012-09-20T00:25:51Z","isPatch":true,"sender":{"key":"git@adamspiers.org","avatar":"https://avatars.githubusercontent.com/u/100738?v=4"},"body":"On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:\n> Adam Spiers <git@adamspiers.org> writes:\n>\n>> ---\n>\n> No explanation why this is a good idea, nor sign-off?\n\nI realised I forgot the sign-off seconds after sending :-(\n\nIsn't it completely self-explanatory? e.g.\n\n    test_expect_code: command exited with 0, we wanted 128 git foo bar\n\nclearly makes more sense than\n\n    test_expect_code: command exited with 0, we wanted 128 from: git foo bar\n"},{"id":"199558","messageId":"7vy5k5cyzg.fsf@alter.siamese.dyndns.org","threadId":"31612","inReplyTo":"CAOkDyE-x5NeZX2tpp3C9Kkwb1kPniHptB9ERvtpx2XODufaW=A@mail.gmail.com","subject":"Re: [PATCH] Improve legibility of test_expect_code output","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-20T00:35:47Z","receivedAt":"2012-09-20T00:35:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Adam Spiers <git@adamspiers.org> writes:\n\n> On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:\n>> Adam Spiers <git@adamspiers.org> writes:\n>>\n>>> ---\n>>\n>> No explanation why this is a good idea, nor sign-off?\n>\n> I realised I forgot the sign-off seconds after sending :-(\n>\n> Isn't it completely self-explanatory? e.g.\n>\n>     test_expect_code: command exited with 0, we wanted 128 git foo bar\n>\n> clearly makes more sense than\n>\n>     test_expect_code: command exited with 0, we wanted 128 from: git foo bar\n\nIf it were \"..., we wanted 128 from 'git foo bar'\", then I would,\nbut otherwise, not really.\n"},{"id":"199560","messageId":"CAOkDyE95x0_ZVCsrsC8kJWdrzMo8b0nQ19N+QKXy64vQ4N6E+A@mail.gmail.com","threadId":"31612","inReplyTo":"7vy5k5cyzg.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Improve legibility of test_expect_code output","fromName":"Adam Spiers","fromEmail":"git@adamspiers.org","sentAt":"2012-09-20T00:48:20Z","receivedAt":"2012-09-20T00:48:20Z","isPatch":true,"sender":{"key":"git@adamspiers.org","avatar":"https://avatars.githubusercontent.com/u/100738?v=4"},"body":"On Thu, Sep 20, 2012 at 1:35 AM, Junio C Hamano <gitster@pobox.com> wrote:\n> If it were \"..., we wanted 128 from 'git foo bar'\", then I would,\n> but otherwise, not really.\n\nThat's fine by me.  Both are better than the status quo.\n"},{"id":"199589","messageId":"7vtxusbpub.fsf@alter.siamese.dyndns.org","threadId":"31612","inReplyTo":"CAOkDyE-x5NeZX2tpp3C9Kkwb1kPniHptB9ERvtpx2XODufaW=A@mail.gmail.com","subject":"Re: [PATCH] Improve legibility of test_expect_code output","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-20T16:50:52Z","receivedAt":"2012-09-20T16:50:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Adam Spiers <git@adamspiers.org> writes:\n\n> On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:\n>> Adam Spiers <git@adamspiers.org> writes:\n>>\n>>> ---\n>>\n>> No explanation why this is a good idea, nor sign-off?\n>\n> I realised I forgot the sign-off seconds after sending :-(\n>\n> Isn't it completely self-explanatory? e.g.\n>\n>     test_expect_code: command exited with 0, we wanted 128 git foo bar\n>\n> clearly makes more sense than\n>\n>     test_expect_code: command exited with 0, we wanted 128 from: git foo bar\n\ntest_expect_code: command exited with 0, we wanted 128: git foo bar\n\nwould be shorter and equally legible, I would think.\n\nIn any case, the proposed commit log message should have explained\nthese differences in the first place so that I or others do not have\nto ask.\n\nDo you want this queued on top of your other series, or as an\nindependent change?\n"},{"id":"199591","messageId":"CAOkDyE9hvBz5wYbj+q=oYTz7zWnP2E9dqtKZ-V=6jBW-FomfbQ@mail.gmail.com","threadId":"31612","inReplyTo":"7vtxusbpub.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Improve legibility of test_expect_code output","fromName":"Adam Spiers","fromEmail":"git@adamspiers.org","sentAt":"2012-09-20T16:57:54Z","receivedAt":"2012-09-20T16:57:54Z","isPatch":true,"sender":{"key":"git@adamspiers.org","avatar":"https://avatars.githubusercontent.com/u/100738?v=4"},"body":"On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Do you want this queued on top of your other series, or as an\n> independent change?\n\nIndependent please.\n"},{"id":"199596","messageId":"7vipb8bnbo.fsf@alter.siamese.dyndns.org","threadId":"31612","inReplyTo":"CAOkDyE9hvBz5wYbj+q=oYTz7zWnP2E9dqtKZ-V=6jBW-FomfbQ@mail.gmail.com","subject":"Re: [PATCH] Improve legibility of test_expect_code output","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-20T17:45:15Z","receivedAt":"2012-09-20T17:45:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Adam Spiers <git@adamspiers.org> writes:\n\n> On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano <gitster@pobox.com> wrote:\n>> Do you want this queued on top of your other series, or as an\n>> independent change?\n>\n> Independent please.\n\nWith a sign-off?\n"},{"id":"199599","messageId":"CAOkDyE-fi6y5kc9hP9q48kWN0PNmU2CSgWid0EwA9RwQd5fSiA@mail.gmail.com","threadId":"31612","inReplyTo":"7vipb8bnbo.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Improve legibility of test_expect_code output","fromName":"Adam Spiers","fromEmail":"git@adamspiers.org","sentAt":"2012-09-20T18:05:00Z","receivedAt":"2012-09-20T18:05:00Z","isPatch":true,"sender":{"key":"git@adamspiers.org","avatar":"https://avatars.githubusercontent.com/u/100738?v=4"},"body":"On Thu, Sep 20, 2012 at 6:45 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Adam Spiers <git@adamspiers.org> writes:\n>> On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano <gitster@pobox.com> wrote:\n>>> Do you want this queued on top of your other series, or as an\n>>> independent change?\n>>\n>> Independent please.\n>\n> With a sign-off?\n\nYep.\n"}]}