{"thread":{"id":"31607","subject":"[PATCH] Documentation/Makefile: Allow custom XMLTO binary","startedAt":"2012-09-19T17:06:37Z","lastAt":"2012-09-19T23:27:04Z","messageCount":4,"participants":["dborowitz@google.com","Junio C Hamano","Dave Borowitz"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"199482","messageId":"1348074397-29978-1-git-send-email-dborowitz@google.com","threadId":"31607","inReplyTo":null,"subject":"[PATCH] Documentation/Makefile: Allow custom XMLTO binary","fromName":"","fromEmail":"dborowitz@google.com","sentAt":"2012-09-19T17:06:37Z","receivedAt":"2012-09-19T17:06:37Z","isPatch":true,"sender":{"key":"dborowitz@google.com","avatar":"https://avatars.githubusercontent.com/u/194927?v=4"},"body":"From: Dave Borowitz \n\nSigned-off-by: Dave Borowitz \n---\n Documentation/Makefile | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex cf5916f..b045628 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -47,6 +47,7 @@ man7dir=$(mandir)/man7\n ASCIIDOC=asciidoc\n ASCIIDOC_EXTRA =\n MANPAGE_XSL = manpage-normal.xsl\n+XMLTO=xmlto\n XMLTO_EXTRA =\n INSTALL?=install\n RM ?= rm -f\n@@ -245,7 +246,7 @@ manpage-base-url.xsl: manpage-base-url.xsl.in\n \n %.1 %.5 %.7 : %.xml manpage-base-url.xsl\n \t$(QUIET_XMLTO)$(RM) $@ && \\\n-\txmlto -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $<\n+\t$(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $<\n \n %.xml : %.txt\n \t$(QUIET_ASCIIDOC)$(RM) $@+ $@ && \\\n-- \n1.7.12.1\n"},{"id":"199501","messageId":"7vehlxhp0v.fsf@alter.siamese.dyndns.org","threadId":"31607","inReplyTo":"1348074397-29978-1-git-send-email-dborowitz@google.com","subject":"Re: [PATCH] Documentation/Makefile: Allow custom XMLTO binary","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-19T17:59:44Z","receivedAt":"2012-09-19T17:59:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"dborowitz@google.com writes:\n\n> From: Dave Borowitz \n>\n> Signed-off-by: Dave Borowitz \n> ---\n\nThanks; the patch sort-of makes sense but makes me wonder what your\nuse case is. Do you have xmlto2 program you want to use in place of\nxmlto or you have xmlto but not on your $PATH?\n\n> Documentation/Makefile | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index cf5916f..b045628 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> @@ -47,6 +47,7 @@ man7dir=$(mandir)/man7\n> ASCIIDOC=asciidoc\n> ASCIIDOC_EXTRA =\n> MANPAGE_XSL = manpage-normal.xsl\n> +XMLTO=xmlto\n> XMLTO_EXTRA =\n> INSTALL?=install\n> RM ?= rm -f\n> @@ -245,7 +246,7 @@ manpage-base-url.xsl: manpage-base-url.xsl.in\n> \n> %.1 %.5 %.7 : %.xml manpage-base-url.xsl\n> \t$(QUIET_XMLTO)$(RM) $@ && \\\n> -\txmlto -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $<\n> +\t$(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $<\n> \n> %.xml : %.txt\n> \t$(QUIET_ASCIIDOC)$(RM) $@+ $@ && \\\n"},{"id":"199536","messageId":"CAD0k6qTMm7MKLYOOMaB72cWc=Z8nJfe8qseWfyM6x_NzCorgZg@mail.gmail.com","threadId":"31607","inReplyTo":"7vehlxhp0v.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Documentation/Makefile: Allow custom XMLTO binary","fromName":"Dave Borowitz","fromEmail":"dborowitz@google.com","sentAt":"2012-09-19T20:49:19Z","receivedAt":"2012-09-19T20:49:19Z","isPatch":true,"sender":{"key":"dborowitz@google.com","avatar":"https://avatars.githubusercontent.com/u/194927?v=4"},"body":"On Wed, Sep 19, 2012 at 10:59 AM, Junio C Hamano wrote:\n> dborowitz@google.com writes:\n>\n>> From: Dave Borowitz \n>>\n>> Signed-off-by: Dave Borowitz \n>> ---\n>\n> Thanks; the patch sort-of makes sense but makes me wonder what your\n> use case is. Do you have xmlto2 program you want to use in place of\n> xmlto or you have xmlto but not on your $PATH?\n\nThe latter; I can easily symlink it into my $PATH of course. But since\nI was already specifying ASCIIDOC on the make command line for the\nsame reason, I was surprised to find I couldn't also specify XMLTO,\nhence the patch.\n\n>> Documentation/Makefile | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/Documentation/Makefile b/Documentation/Makefile\n>> index cf5916f..b045628 100644\n>> --- a/Documentation/Makefile\n>> +++ b/Documentation/Makefile\n>> @@ -47,6 +47,7 @@ man7dir=$(mandir)/man7\n>> ASCIIDOC=asciidoc\n>> ASCIIDOC_EXTRA =\n>> MANPAGE_XSL = manpage-normal.xsl\n>> +XMLTO=xmlto\n>> XMLTO_EXTRA =\n>> INSTALL?=install\n>> RM ?= rm -f\n>> @@ -245,7 +246,7 @@ manpage-base-url.xsl: manpage-base-url.xsl.in\n>>\n>> %.1 %.5 %.7 : %.xml manpage-base-url.xsl\n>> $(QUIET_XMLTO)$(RM) $@ && \\\n>> - xmlto -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $<\n>> + $(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $<\n>>\n>> %.xml : %.txt\n>> $(QUIET_ASCIIDOC)$(RM) $@+ $@ && \\\n"},{"id":"199546","messageId":"7vvcf9egqf.fsf@alter.siamese.dyndns.org","threadId":"31607","inReplyTo":"CAD0k6qTMm7MKLYOOMaB72cWc=Z8nJfe8qseWfyM6x_NzCorgZg@mail.gmail.com","subject":"Re: [PATCH] Documentation/Makefile: Allow custom XMLTO binary","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-19T23:27:04Z","receivedAt":"2012-09-19T23:27:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dave Borowitz writes:\n\n> On Wed, Sep 19, 2012 at 10:59 AM, Junio C Hamano wrote:\n>> dborowitz@google.com writes:\n>>\n>>> From: Dave Borowitz \n>>>\n>>> Signed-off-by: Dave Borowitz \n>>> ---\n>>\n>> Thanks; the patch sort-of makes sense but makes me wonder what your\n>> use case is. Do you have xmlto2 program you want to use in place of\n>> xmlto or you have xmlto but not on your $PATH?\n>\n> The latter; I can easily symlink it into my $PATH of course. But since\n> I was already specifying ASCIIDOC on the make command line for the\n> same reason, I was surprised to find I couldn't also specify XMLTO,\n> hence the patch.\n\nOK. Was just curious.\n"}]}