{"thread":{"id":"31577","subject":"[PATCH/RFC] git-svn: use path accessor for Git::SVN objects","startedAt":"2012-09-18T00:09:31Z","lastAt":"2012-09-18T18:10:05Z","messageCount":3,"participants":["Eric Wong","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"199311","messageId":"20120918000931.GB17939@dcvr.yhbt.net","threadId":"31577","inReplyTo":null,"subject":"[PATCH/RFC] git-svn: use path accessor for Git::SVN objects","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2012-09-18T00:09:31Z","receivedAt":"2012-09-18T00:09:31Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"The accessors should improve maintainability and enforce\nconsistent access to Git::SVN objects.\n\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n---\n  (RFC since I could've missed something)\n\n  Eric Wong <normalperson@yhbt.net> wrote:\n  > I'll apply the following (on top of a patch which fixes some\n  > {path} usages):\n\n git-svn.perl       | 2 +-\n perl/Git/SVN/Ra.pm | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 0d77ffb..bd5266c 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1314,7 +1314,7 @@ sub get_svnprops {\n \t$path = $cmd_dir_prefix . $path;\n \tfatal(\"No such file or directory: $path\") unless -e $path;\n \tmy $is_dir = -d $path ? 1 : 0;\n-\t$path = join_paths($gs->{path}, $path);\n+\t$path = join_paths($gs->path, $path);\n \n \t# canonicalize the path (otherwise libsvn will abort or fail to\n \t# find the file)\ndiff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm\nindex 90ec30b..049c97b 100644\n--- a/perl/Git/SVN/Ra.pm\n+++ b/perl/Git/SVN/Ra.pm\n@@ -416,7 +416,7 @@ sub gs_fetch_loop_common {\n \t\t}\n \t\t$SVN::Error::handler = $err_handler;\n \n-\t\tmy %exists = map { $_->{path} => $_ } @$gsv;\n+\t\tmy %exists = map { $_->path => $_ } @$gsv;\n \t\tforeach my $r (sort {$a <=> $b} keys %revs) {\n \t\t\tmy ($paths, $logged) = @{$revs{$r}};\n \n-- \n1.7.12.441.g0590587.dirty\n"},{"id":"199371","messageId":"20120918142941.GA2925@elie.Belkin","threadId":"31577","inReplyTo":"20120918000931.GB17939@dcvr.yhbt.net","subject":"Re: [PATCH/RFC] git-svn: use path accessor for Git::SVN objects","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-09-18T14:29:42Z","receivedAt":"2012-09-18T14:29:42Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Eric Wong wrote:\n\n> The accessors should improve maintainability and enforce\n> consistent access to Git::SVN objects.\n>\n> Signed-off-by: Eric Wong <normalperson@yhbt.net>\n> ---\n>   (RFC since I could've missed something)\n[...]\n>  git-svn.perl       | 2 +-\n>  perl/Git/SVN/Ra.pm | 2 +-\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n\nI think that's all of them, so for what it's worth,\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n"},{"id":"199382","messageId":"7v1uhznqwy.fsf@alter.siamese.dyndns.org","threadId":"31577","inReplyTo":"20120918142941.GA2925@elie.Belkin","subject":"Re: [PATCH/RFC] git-svn: use path accessor for Git::SVN objects","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-18T18:10:05Z","receivedAt":"2012-09-18T18:10:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Eric Wong wrote:\n>\n>> The accessors should improve maintainability and enforce\n>> consistent access to Git::SVN objects.\n>>\n>> Signed-off-by: Eric Wong <normalperson@yhbt.net>\n>> ---\n>>   (RFC since I could've missed something)\n> [...]\n>>  git-svn.perl       | 2 +-\n>>  perl/Git/SVN/Ra.pm | 2 +-\n>>  2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> I think that's all of them, so for what it's worth,\n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks for helping to move things forward.\n"}]}